h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-06 21:02:59 +08:00
Code Issues Releases Wiki Activity

change show/hide page selector logic for small code quality improvement

Browse Source
This commit is contained in:
SailorSnoW 2024-12-20 01:28:51 +01:00
parent 80ba0a05b4
commit 2c256475e0
2 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Overlays/PagedTabControlOverlayHeader.cs
View File

@ -32,8 +32,12 @@ namespace osu.Game.Overlays
}); });
} }
public void ShowPageSelector() => pageSelector.Show(); public void ShowPageSelector(bool visible)
{
public void HidePageSelector() => pageSelector.Hide(); if (visible)
pageSelector.Show();
else
pageSelector.Hide();
}
} }
} }

11
osu.Game/Overlays/RankingsOverlay.cs
View File

@ -50,9 +50,10 @@ namespace osu.Game.Overlays
if (!Country.IsDefault) if (!Country.IsDefault)
{ {
Header.Current.Value = RankingsScope.Performance; Header.Current.Value = RankingsScope.Performance;
Header.HidePageSelector();
} }
else Header.ShowPageSelector();
// Hide page selection with country filter
Header.ShowPageSelector(Country.IsDefault);
Scheduler.AddOnce(triggerTabChanged); Scheduler.AddOnce(triggerTabChanged);
}); });
@ -86,11 +87,7 @@ namespace osu.Game.Overlays
Country.SetDefault(); Country.SetDefault();
// Hide page selection for spotlights scope // Hide page selection for spotlights scope
if (tab == RankingsScope.Spotlights) Header.ShowPageSelector(tab != RankingsScope.Spotlights);
{
Header.HidePageSelector();
}
else Header.ShowPageSelector();
Scheduler.AddOnce(triggerTabChanged); Scheduler.AddOnce(triggerTabChanged);
} }