From 2c256475e06c585e12e9df6949e417c827bcef4c Mon Sep 17 00:00:00 2001
From: SailorSnoW <sailorsnow@pm.me>
Date: Fri, 20 Dec 2024 01:28:51 +0100
Subject: [PATCH] change show/hide page selector logic for small code quality
 improvement

---
 osu.Game/Overlays/PagedTabControlOverlayHeader.cs | 10 +++++++---
 osu.Game/Overlays/RankingsOverlay.cs              | 11 ++++-------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/osu.Game/Overlays/PagedTabControlOverlayHeader.cs b/osu.Game/Overlays/PagedTabControlOverlayHeader.cs
index 8d565469fe..07f1e31cc1 100644
--- a/osu.Game/Overlays/PagedTabControlOverlayHeader.cs
+++ b/osu.Game/Overlays/PagedTabControlOverlayHeader.cs
@@ -32,8 +32,12 @@ namespace osu.Game.Overlays
                 });
         }
 
-        public void ShowPageSelector() => pageSelector.Show();
-
-        public void HidePageSelector() => pageSelector.Hide();
+        public void ShowPageSelector(bool visible)
+        {
+            if (visible)
+                pageSelector.Show();
+            else
+                pageSelector.Hide();
+        }
     }
 }
diff --git a/osu.Game/Overlays/RankingsOverlay.cs b/osu.Game/Overlays/RankingsOverlay.cs
index 082d885a1d..1a8b410424 100644
--- a/osu.Game/Overlays/RankingsOverlay.cs
+++ b/osu.Game/Overlays/RankingsOverlay.cs
@@ -50,9 +50,10 @@ namespace osu.Game.Overlays
                 if (!Country.IsDefault)
                 {
                     Header.Current.Value = RankingsScope.Performance;
-                    Header.HidePageSelector();
                 }
-                else Header.ShowPageSelector();
+
+                // Hide page selection with country filter
+                Header.ShowPageSelector(Country.IsDefault);
 
                 Scheduler.AddOnce(triggerTabChanged);
             });
@@ -86,11 +87,7 @@ namespace osu.Game.Overlays
                 Country.SetDefault();
 
             // Hide page selection for spotlights scope
-            if (tab == RankingsScope.Spotlights)
-            {
-                Header.HidePageSelector();
-            }
-            else Header.ShowPageSelector();
+            Header.ShowPageSelector(tab != RankingsScope.Spotlights);
 
             Scheduler.AddOnce(triggerTabChanged);
         }