h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-05 14:22:55 +08:00
Code Issues Releases Wiki Activity

style(editor/checks): add issues for delays with no silence

Browse Source
This commit is contained in:
tsrk 2023-08-25 11:46:09 +02:00
parent 4c32e9a479
commit 29a46f5b36
No known key found for this signature in database
GPG Key ID: EBD46BB3049B56D6
1 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
osu.Game/Rulesets/Edit/Checks/CheckDelayedHitsounds.cs
View File

@ -32,7 +32,9 @@ namespace osu.Game.Rulesets.Edit.Checks
{ {
new IssueTemplateConsequentDelay(this), new IssueTemplateConsequentDelay(this),
new IssueTemplateDelay(this), new IssueTemplateDelay(this),
new IssuTemplateMinorDelay(this) new IssueTemplateDelayNoSilence(this),
new IssuTemplateMinorDelay(this),
new IssuTemplateMinorDelayNoSilence(this),
}; };
private float getAverageAmplitude(Waveform.Point point) => (point.AmplitudeLeft + point.AmplitudeRight) / 2; private float getAverageAmplitude(Waveform.Point point) => (point.AmplitudeLeft + point.AmplitudeRight) / 2;
@ -93,9 +95,19 @@ namespace osu.Game.Rulesets.Edit.Checks
if (consequentDelay >= delay_threshold) if (consequentDelay >= delay_threshold)
yield return new IssueTemplateConsequentDelay(this).Create(file.Filename, consequentDelay); yield return new IssueTemplateConsequentDelay(this).Create(file.Filename, consequentDelay);
else if (consequentDelay + delay >= delay_threshold) else if (consequentDelay + delay >= delay_threshold)
yield return new IssueTemplateDelay(this).Create(file.Filename, consequentDelay, delay); {
if (consequentDelay > 0)
yield return new IssueTemplateDelay(this).Create(file.Filename, consequentDelay, delay);
else
yield return new IssueTemplateDelayNoSilence(this).Create(file.Filename, delay);
}
else if (consequentDelay + delay >= delay_threshold_negligible) else if (consequentDelay + delay >= delay_threshold_negligible)
yield return new IssuTemplateMinorDelay(this).Create(file.Filename, consequentDelay, delay); {
if (consequentDelay > 0)
yield return new IssuTemplateMinorDelay(this).Create(file.Filename, consequentDelay, delay);
else
yield return new IssuTemplateMinorDelayNoSilence(this).Create(file.Filename, delay);
}
} }
} }
} }
@ -138,6 +150,17 @@ namespace osu.Game.Rulesets.Edit.Checks
public Issue Create(string filename, int consequentDelay, int delay) => new Issue(this, filename, delay, consequentDelay); public Issue Create(string filename, int consequentDelay, int delay) => new Issue(this, filename, delay, consequentDelay);
} }
public class IssueTemplateDelayNoSilence : IssueTemplate
{
public IssueTemplateDelayNoSilence(ICheck check)
: base(check, IssueType.Warning,
"\"{0}\" has a transient delay of ~{1:0.##} ms.")
{
}
public Issue Create(string filename, int delay) => new Issue(this, filename, delay);
}
public class IssuTemplateMinorDelay : IssueTemplate public class IssuTemplateMinorDelay : IssueTemplate
{ {
public IssuTemplateMinorDelay(ICheck check) public IssuTemplateMinorDelay(ICheck check)
@ -148,5 +171,16 @@ namespace osu.Game.Rulesets.Edit.Checks
public Issue Create(string filename, int consequentDelay, int delay) => new Issue(this, filename, delay, consequentDelay); public Issue Create(string filename, int consequentDelay, int delay) => new Issue(this, filename, delay, consequentDelay);
} }
public class IssuTemplateMinorDelayNoSilence : IssueTemplate
{
public IssuTemplateMinorDelayNoSilence(ICheck check)
: base(check, IssueType.Negligible,
"\"{0}\" has a transient delay of ~{1:0.##} ms.")
{
}
public Issue Create(string filename, int delay) => new Issue(this, filename, delay);
}
} }
} }