h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 20:32:55 +08:00
Code Issues Releases Wiki Activity

Make missing beatmap notification simple

Browse Source 
Progress didn't work for several reasons:

- It was spinning when nothing was actually happening yet
  (especially egregious with autodownload off)

- It was blocking exits (as all progress notifications do)

- When actually going to download, two progress notifications would
  pertain to one thing

- It wasn't helping much with the actual implementation of score
  re-import, cancelling the progress notification would result in
  similarly jank UX of beatmap importing but not the score.
This commit is contained in:
Bartłomiej Dach 2023-09-18 14:30:06 +02:00
parent b2c98da330
commit 27471ad170
No known key found for this signature in database
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Database/MissingBeatmapNotification.cs
View File

@ -18,7 +18,7 @@ using osu.Game.Localisation;
namespace osu.Game.Database namespace osu.Game.Database
{ {
public partial class MissingBeatmapNotification : ProgressNotification public partial class MissingBeatmapNotification : SimpleNotification
{ {
[Resolved] [Resolved]
private BeatmapModelDownloader beatmapDownloader { get; set; } = null!; private BeatmapModelDownloader beatmapDownloader { get; set; } = null!;
@ -93,7 +93,7 @@ namespace osu.Game.Database
if (sender.Any(s => s.Beatmaps.Any(b => b.MD5Hash == beatmapHash))) if (sender.Any(s => s.Beatmaps.Any(b => b.MD5Hash == beatmapHash)))
{ {
var importTask = new ImportTask(scoreStream, "score.osr"); var importTask = new ImportTask(scoreStream, "score.osr");
scoreManager.Import(this, new[] { importTask }); scoreManager.Import(new[] { importTask });
realmSubscription?.Dispose(); realmSubscription?.Dispose();
} }
} }