From 27471ad170bfaf4e2df5e42520f9c19613bf67eb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Mon, 18 Sep 2023 14:30:06 +0200 Subject: [PATCH] Make missing beatmap notification simple Progress didn't work for several reasons: - It was spinning when nothing was actually happening yet (especially egregious with autodownload off) - It was blocking exits (as all progress notifications do) - When actually going to download, two progress notifications would pertain to one thing - It wasn't helping much with the actual implementation of score re-import, cancelling the progress notification would result in similarly jank UX of beatmap importing but not the score. --- osu.Game/Database/MissingBeatmapNotification.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/osu.Game/Database/MissingBeatmapNotification.cs b/osu.Game/Database/MissingBeatmapNotification.cs index e2c72f35de..07382a0e3b 100644 --- a/osu.Game/Database/MissingBeatmapNotification.cs +++ b/osu.Game/Database/MissingBeatmapNotification.cs @@ -18,7 +18,7 @@ using osu.Game.Localisation; namespace osu.Game.Database { - public partial class MissingBeatmapNotification : ProgressNotification + public partial class MissingBeatmapNotification : SimpleNotification { [Resolved] private BeatmapModelDownloader beatmapDownloader { get; set; } = null!; @@ -93,7 +93,7 @@ namespace osu.Game.Database if (sender.Any(s => s.Beatmaps.Any(b => b.MD5Hash == beatmapHash))) { var importTask = new ImportTask(scoreStream, "score.osr"); - scoreManager.Import(this, new[] { importTask }); + scoreManager.Import(new[] { importTask }); realmSubscription?.Dispose(); } }