h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-21 10:42:54 +08:00
Code Issues Releases Wiki Activity

Merge pull request #10200 from peppy/fix-hit-object-container-unbinding

Browse Source 
Fix HitObjectContainer not correctly unbinding from startTime fast enough
This commit is contained in:
Dean Herbert 2020-09-23 21:17:31 +09:00 committed by GitHub
commit 26d1c4322d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Rulesets/UI/HitObjectContainer.cs
View File

@ -43,10 +43,20 @@ namespace osu.Game.Rulesets.UI
return true; return true;
} }
protected override void Dispose(bool isDisposing)
{
base.Dispose(isDisposing);
unbindStartTimeMap();
}
public virtual void Clear(bool disposeChildren = true) public virtual void Clear(bool disposeChildren = true)
{ {
ClearInternal(disposeChildren); ClearInternal(disposeChildren);
unbindStartTimeMap();
}
private void unbindStartTimeMap()
{
foreach (var kvp in startTimeMap) foreach (var kvp in startTimeMap)
kvp.Value.bindable.UnbindAll(); kvp.Value.bindable.UnbindAll();
startTimeMap.Clear(); startTimeMap.Clear();