h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 17:43:05 +08:00
Code Issues Releases Wiki Activity

Merge pull request #5005 from peppy/fix-social-overlay-performance

Browse Source 
Fix abysmal load performance when showing the social overlay
This commit is contained in:
Dean Herbert 2019-06-12 21:14:33 +09:00 committed by GitHub
commit 224e417f68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 38 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
osu.Game/Users/UserCoverBackground.cs
View File

@ -21,31 +21,45 @@ namespace osu.Game.Users
set => Model = value;
}
[Resolved]
private LargeTextureStore textures { get; set; }
protected override Drawable CreateDrawable(User user) => new Cover(user);
protected override Drawable CreateDrawable(User user)
private class Cover : CompositeDrawable
{
if (user == null)
private readonly User user;
public Cover(User user)
{
return new Box
{
RelativeSizeAxes = Axes.Both,
Colour = ColourInfo.GradientVertical(Color4.Black.Opacity(0.1f), Color4.Black.Opacity(0.75f))
};
this.user = user;
RelativeSizeAxes = Axes.Both;
}
else
[BackgroundDependencyLoader]
private void load(LargeTextureStore textures)
{
var sprite = new Sprite
if (user == null)
{
RelativeSizeAxes = Axes.Both,
Texture = textures.Get(user.CoverUrl),
FillMode = FillMode.Fill,
Anchor = Anchor.Centre,
Origin = Anchor.Centre
};
sprite.OnLoadComplete += d => d.FadeInFromZero(400);
return sprite;
InternalChild = new Box
{
RelativeSizeAxes = Axes.Both,
Colour = ColourInfo.GradientVertical(Color4.Black.Opacity(0.1f), Color4.Black.Opacity(0.75f))
};
}
else
InternalChild = new Sprite
{
RelativeSizeAxes = Axes.Both,
Texture = textures.Get(user.CoverUrl),
FillMode = FillMode.Fill,
Anchor = Anchor.Centre,
Origin = Anchor.Centre
};
}
protected override void LoadComplete()
{
base.LoadComplete();
this.FadeInFromZero(400);
}
}
}

11
osu.Game/Users/UserPanel.cs
View File

@ -66,8 +66,6 @@ namespace osu.Game.Users
FillFlowContainer infoContainer;
UserCoverBackground coverBackground;
AddInternal(content = new Container
{
RelativeSizeAxes = Axes.Both,
@ -82,13 +80,16 @@ namespace osu.Game.Users
Children = new Drawable[]
{
new DelayedLoadWrapper(coverBackground = new UserCoverBackground
new DelayedLoadUnloadWrapper(() => new UserCoverBackground
{
RelativeSizeAxes = Axes.Both,
Anchor = Anchor.Centre,
Origin = Anchor.Centre,
User = user,
}, 300) { RelativeSizeAxes = Axes.Both },
}, 300, 5000)
{
RelativeSizeAxes = Axes.Both,
},
new Box
{
RelativeSizeAxes = Axes.Both,
@ -189,8 +190,6 @@ namespace osu.Game.Users
}
});
coverBackground.OnLoadComplete += d => d.FadeInFromZero(400, Easing.Out);
if (user.IsSupporter)
{
infoContainer.Add(new SupporterIcon