h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 10:33:30 +08:00
Code Issues Releases Wiki Activity

Just assert doesn't throw and don't catch at LegacyDecoder

Browse Source
This commit is contained in:
David Zhao 2019-08-07 19:25:40 +09:00
parent da15e19912
commit 15a592e25e
3 changed files with 3 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapDecoderTest.cs
View File

@ -484,20 +484,14 @@ namespace osu.Game.Tests.Beatmaps.Formats
}
[Test]
public void TestDecodeInvalidEvents()
public void TestInvalidEventStillPasses()
{
var decoder = new LegacyBeatmapDecoder { ApplyOffsets = false };
using (var goodResStream = TestResources.OpenResource("valid-events.osu"))
using (var goodStream = new StreamReader(goodResStream))
using (var badResStream = TestResources.OpenResource("invalid-events.osu"))
using (var badStream = new StreamReader(badResStream))
{
var goodBeatmap = decoder.Decode(goodStream);
var badBeatmap = decoder.Decode(badStream);
Assert.AreEqual(goodBeatmap.Breaks[0].Duration, badBeatmap.Breaks[0].Duration);
Assert.AreEqual(goodBeatmap.Metadata.BackgroundFile, badBeatmap.Metadata.BackgroundFile);
Assert.DoesNotThrow(() => decoder.Decode(badStream));
}
}
}

12
osu.Game.Tests/Resources/valid-events.osu
View File

@ -1,12 +0,0 @@
osu file format v14
[Events]
//Background and Video events
0,0,"machinetop_background.jpg",0,0
//Break Periods
2,122474,140135
//Storyboard Layer 0 (Background)
//Storyboard Layer 1 (Fail)
//Storyboard Layer 2 (Pass)
//Storyboard Layer 3 (Foreground)
//Storyboard Sound Samples

9
osu.Game/Beatmaps/Formats/LegacyDecoder.cs
View File

@ -43,14 +43,7 @@ namespace osu.Game.Beatmaps.Formats
continue;
}
try
{
ParseLine(output, section, line);
}
catch (Exception e)
{
Logger.Error(e, $"Failed to process line \"{line}\" into {output}");
}
ParseLine(output, section, line);
}
}