h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-19 05:09:54 +08:00
Code Issues Releases Wiki Activity

Merge pull request #33665 from bdach/map-upload-status-better

Browse Source 
Pick better initial beatmap status when submitting
This commit is contained in:
Dean Herbert
2025-06-19 18:35:36 +09:00
committed by GitHub
Unverified
parent eacf0eeec6 a38e25115b
commit 0b8fac73df
3 changed files with 35 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Edit/Submission/BeatmapSubmissionScreen.cs
+7
View File
@@ -191,6 +191,13 @@ namespace osu.Game.Screens.Edit.Submission
});
completedSample = audio.Samples.Get(@"UI/bss-complete");
if (Beatmap.Value.BeatmapSetInfo.OnlineID > 0)
{
var req = new GetBeatmapSetRequest(Beatmap.Value.BeatmapSetInfo.OnlineID);
api.Queue(req);
settings.LatestOnlineStateRequest = req;
}
}
private void createBeatmapSet()
osu.Game/Screens/Edit/Submission/BeatmapSubmissionSettings.cs
+2
View File
@@ -8,6 +8,8 @@ namespace osu.Game.Screens.Edit.Submission
{
public class BeatmapSubmissionSettings
{
public GetBeatmapSetRequest? LatestOnlineStateRequest { get; set; }
public Bindable<BeatmapSubmissionTarget> Target { get; } = new Bindable<BeatmapSubmissionTarget>();
public Bindable<bool> NotifyOnDiscussionReplies { get; } = new Bindable<bool>();
osu.Game/Screens/Edit/Submission/ScreenSubmissionSettings.cs
+26 -1
View File
@@ -1,16 +1,19 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System.Diagnostics;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Framework.Localisation;
using osu.Game.Beatmaps;
using osu.Game.Configuration;
using osu.Game.Graphics;
using osu.Game.Graphics.Containers;
using osu.Game.Graphics.UserInterfaceV2;
using osu.Game.Localisation;
using osu.Game.Online.API;
using osu.Game.Online.API.Requests;
using osu.Game.Overlays;
using osuTK;
@@ -25,8 +28,11 @@ namespace osu.Game.Screens.Edit.Submission
public override LocalisableString? NextStepText => BeatmapSubmissionStrings.ConfirmSubmission;
[Resolved]
private BeatmapSubmissionSettings settings { get; set; } = null!;
[BackgroundDependencyLoader]
private void load(OsuConfigManager configManager, OsuColour colours, BeatmapSubmissionSettings settings)
private void load(OsuConfigManager configManager, OsuColour colours)
{
configManager.BindWith(OsuSetting.EditorSubmissionNotifyOnDiscussionReplies, settings.NotifyOnDiscussionReplies);
configManager.BindWith(OsuSetting.EditorSubmissionLoadInBrowserAfterSubmission, loadInBrowserAfterSubmission);
@@ -63,6 +69,25 @@ namespace osu.Game.Screens.Edit.Submission
},
}
});
switch (settings.LatestOnlineStateRequest?.CompletionState)
{
case APIRequestCompletionState.Completed:
setSubmissionTargetFromLatestOnlineState();
break;
case APIRequestCompletionState.Waiting:
settings.Target.Disabled = true;
settings.LatestOnlineStateRequest.Success += _ => setSubmissionTargetFromLatestOnlineState();
break;
}
}
private void setSubmissionTargetFromLatestOnlineState()
{
Debug.Assert(settings.LatestOnlineStateRequest != null);
settings.Target.Disabled = false;
settings.Target.Value = settings.LatestOnlineStateRequest.Response?.Status >= BeatmapOnlineStatus.Pending ? BeatmapSubmissionTarget.Pending : BeatmapSubmissionTarget.WIP;
}
}
}