h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-26 18:52:55 +08:00
Code Issues Releases Wiki Activity

Merge pull request #21045 from peppy/improve-ruleset-load-fail-message

Browse Source 
Improve messaging when ruleset load fails
This commit is contained in:
Dan Balasescu 2022-11-01 14:36:40 +09:00 committed by GitHub
commit 00bd77ce76
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Rulesets/RulesetStore.cs
View File

@ -158,7 +158,7 @@ namespace osu.Game.Rulesets
} }
catch (Exception e) catch (Exception e)
{ {
LogFailedLoad(assembly.FullName, e); LogFailedLoad(assembly.GetName().Name.Split('.').Last(), e);
} }
} }
@ -168,14 +168,14 @@ namespace osu.Game.Rulesets
GC.SuppressFinalize(this); GC.SuppressFinalize(this);
} }
protected virtual void Dispose(bool disposing) protected void Dispose(bool disposing)
{ {
AppDomain.CurrentDomain.AssemblyResolve -= resolveRulesetDependencyAssembly; AppDomain.CurrentDomain.AssemblyResolve -= resolveRulesetDependencyAssembly;
} }
protected void LogFailedLoad(string name, Exception exception) protected void LogFailedLoad(string name, Exception exception)
{ {
Logger.Log($"Could not load ruleset {name}. Please check for an update from the developer.", level: LogLevel.Error); Logger.Log($"Could not load ruleset \"{name}\". Please check for an update from the developer.", level: LogLevel.Error);
Logger.Log($"Ruleset load failed: {exception}"); Logger.Log($"Ruleset load failed: {exception}");
} }