1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 04:27:52 +08:00
osu-lazer/osu.Game/Rulesets/Edit/Checks/CheckBreaks.cs

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

124 lines
4.6 KiB
C#
Raw Normal View History

2023-07-17 04:03:21 +08:00
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System.Collections.Generic;
using osu.Game.Beatmaps.Timing;
using osu.Game.Rulesets.Edit.Checks.Components;
using osu.Game.Rulesets.Objects;
namespace osu.Game.Rulesets.Edit.Checks
{
public class CheckBreaks : ICheck
{
// Breaks may be off by 1 ms.
private const int leniency_threshold = 1;
private const double minimum_gap_before_break = 200;
2023-07-17 04:03:21 +08:00
// Break end time depends on the upcoming object's pre-empt time.
// As things stand, "pre-empt time" is only defined for osu! standard
// This is a generic value representing AR=10
// Relevant: https://github.com/ppy/osu/issues/14330#issuecomment-1002158551
private const double min_end_threshold = 450;
public CheckMetadata Metadata => new CheckMetadata(CheckCategory.Events, "Breaks not achievable using the editor");
public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[]
{
new IssueTemplateEarlyStart(this),
new IssueTemplateLateEnd(this),
new IssueTemplateTooShort(this)
};
public IEnumerable<Issue> Run(BeatmapVerifierContext context)
{
foreach (var breakPeriod in context.Beatmap.Breaks)
{
if (breakPeriod.Duration < BreakPeriod.MIN_BREAK_DURATION)
yield return new IssueTemplateTooShort(this).Create(breakPeriod.StartTime);
2023-07-20 05:32:35 +08:00
var previousObject = getPreviousObject(breakPeriod.StartTime, context.Beatmap.HitObjects);
var nextObject = getNextObject(breakPeriod.EndTime, context.Beatmap.HitObjects);
2023-07-17 04:03:21 +08:00
2023-07-20 05:32:35 +08:00
if (previousObject != null)
{
double gapBeforeBreak = breakPeriod.StartTime - previousObject.GetEndTime();
if (gapBeforeBreak < minimum_gap_before_break - leniency_threshold)
yield return new IssueTemplateEarlyStart(this).Create(breakPeriod.StartTime, minimum_gap_before_break - gapBeforeBreak);
2023-07-20 05:32:35 +08:00
}
if (nextObject != null)
{
double gapAfterBreak = nextObject.StartTime - breakPeriod.EndTime;
if (gapAfterBreak < min_end_threshold - leniency_threshold)
yield return new IssueTemplateLateEnd(this).Create(breakPeriod.StartTime, min_end_threshold - gapAfterBreak);
2023-07-17 04:03:21 +08:00
}
}
}
2023-07-20 05:32:35 +08:00
private HitObject? getPreviousObject(double time, IReadOnlyList<HitObject> hitObjects)
{
int left = 0;
int right = hitObjects.Count - 1;
while (left <= right)
{
int mid = left + (right - left) / 2;
if (hitObjects[mid].GetEndTime() < time)
left = mid + 1;
else
right = mid - 1;
}
return right >= 0 ? hitObjects[right] : null;
}
private HitObject? getNextObject(double time, IReadOnlyList<HitObject> hitObjects)
{
int left = 0;
int right = hitObjects.Count - 1;
while (left <= right)
{
int mid = left + (right - left) / 2;
if (hitObjects[mid].StartTime <= time)
left = mid + 1;
else
right = mid - 1;
}
return left < hitObjects.Count ? hitObjects[left] : null;
}
2023-07-17 04:03:21 +08:00
public class IssueTemplateEarlyStart : IssueTemplate
{
public IssueTemplateEarlyStart(ICheck check)
: base(check, IssueType.Problem, "Break starts {0} ms early.")
{
}
public Issue Create(double startTime, double diff) => new Issue(startTime, this, (int)diff);
}
public class IssueTemplateLateEnd : IssueTemplate
{
public IssueTemplateLateEnd(ICheck check)
: base(check, IssueType.Problem, "Break ends {0} ms late.")
{
}
public Issue Create(double startTime, double diff) => new Issue(startTime, this, (int)diff);
}
public class IssueTemplateTooShort : IssueTemplate
{
public IssueTemplateTooShort(ICheck check)
: base(check, IssueType.Warning, "Break is non-functional due to being less than {0} ms.")
2023-07-17 04:03:21 +08:00
{
}
public Issue Create(double startTime) => new Issue(startTime, this, BreakPeriod.MIN_BREAK_DURATION);
2023-07-17 04:03:21 +08:00
}
}
}