1728 Commits

• refactor: fix nullable params
  Breno A. · 2024-06-09 10:26:58 -03:00
  d4ce7aac08
• refactor: number comparison
  Breno A. · 2024-06-09 10:09:59 -03:00
  3b68645330
• chore: fix codestyle indentation
  Breno A. · 2024-06-09 10:06:57 -03:00
  db280387ba
• refactor: null check is not necessary, we have instanceof
  Breno A. · 2024-06-09 10:02:56 -03:00
  809009f96c
• perf: stream api can be simplified here
  Breno A. · 2024-06-09 10:01:03 -03:00
  45bf5edb13
• perf: we can just equalsIgnoreCase
  Breno A. · 2024-06-09 10:00:07 -03:00
  3d00abcc91
• perf: remove redundant collection operation
  Breno A. · 2024-06-09 09:59:16 -03:00
  85ca8777c9
• perf: simplify optional chain
  Breno A. · 2024-06-09 09:58:25 -03:00
  8f8a6a7bfe
• perf: size cannot be negative
  Breno A. · 2024-06-09 09:57:41 -03:00
  f01da54eaa
• perf: this is just Math.min
  Breno A. · 2024-06-09 09:56:58 -03:00
  4b03304cdc
• refactor(lombok): add Setter where possible
  Breno A. · 2024-06-09 09:55:51 -03:00
  dd9f59fbfc
• refactor(lombok): add Getter where possible
  Breno A. · 2024-06-09 09:52:49 -03:00
  8f4120fcd3
• perf: add Serial annotation here
  Breno A. · 2024-06-09 09:46:29 -03:00
  7ee644c794
• perf: equals "" can be isEmpty here
  Breno A. · 2024-06-09 09:45:05 -03:00
  aeadf6bba7
• perf: we can chain append here
  Breno A. · 2024-06-09 09:44:23 -03:00
  1e2ccc9fc6
• perf: fix redundant addAll
  Breno A. · 2024-06-09 09:43:31 -03:00
  1424405c64
• perf: findAny().isPresent() is cleaner here
  Breno A. · 2024-06-09 09:42:43 -03:00
  33d5c5238a
• perf: count > 0 can be anyMatch
  Breno A. · 2024-06-09 09:42:06 -03:00
  b7735295f1
• perf: class initializer may be static
  Breno A. · 2024-06-09 09:39:46 -03:00
  e4123f47d6
• perf: Call to 'asList()' with only one argument
  Breno A. · 2024-06-09 09:39:21 -03:00
  4f1ad7b576
• refactor: implicit cast from double to float may be lossy
  Breno A. · 2024-06-09 09:38:33 -03:00
  6e3b3b20a0
• fix: integer division in floating point
  Breno A. · 2024-06-09 09:37:06 -03:00
  d5ad077ce1
• refactor: replace concatenation log with parameterized
  Breno A. · 2024-06-09 09:35:38 -03:00
  6e7418a89d
• refactor: fix javadoc issues
  Breno A. · 2024-06-09 09:33:59 -03:00
  77e246213f
• refactor: replace switch with enhanced switch
  Breno A. · 2024-06-09 09:25:14 -03:00
  c9b42a6dfb
• refactor: Integer.ParseInt is more appropriate here
  Breno A. · 2024-06-09 09:20:19 -03:00
  7db8b6f0c7
• refactor: Integer.ParseInt is more appropriate here
  Breno A. · 2024-06-09 09:19:41 -03:00
  6d669bd47a
• refactor: replace for loop with enhanced loop
  Breno A. · 2024-06-09 09:18:48 -03:00
  bb82e21c82
• refactor: we don't need explicit types here
  Breno A. · 2024-06-09 09:17:05 -03:00
  b5d0afd0fe
• refactor: replace statement with expression lambda
  Breno A. · 2024-06-09 09:15:22 -03:00
  fcd409320d
• refactor: simplify map operations

  we can use computeIfAbsent here

  Breno A. · 2024-06-09 09:13:18 -03:00
  c7119aae68
• refactor: replace lambda with method reference
  Breno A. · 2024-06-09 09:11:58 -03:00
  3119e0fffc
• refactor: replace lambda with method reference
  Breno A. · 2024-06-09 09:10:48 -03:00
  870085fc91
• refactor: replace Collections.sort with list.sort

  Collections.sort is just a wrapper, so it is better to use an instance method directly.

  Breno A. · 2024-06-09 09:09:45 -03:00
  8c35c89bf5
• chore: remove unused import
  Breno A. · 2024-06-09 09:07:54 -03:00
  9c946e9d2e
• fix: variable is assigned to itself
  Breno A. · 2024-06-09 09:06:12 -03:00
  427a1cf5f5
• refactor: replace protected with private for final class
  Breno A. · 2024-06-09 09:04:26 -03:00
  0161b4d73d
• refactor: replace protected with private for final class
  Breno A. · 2024-06-09 09:03:50 -03:00
  ca6ddfd2cc
• refactor: this can also be final
  Breno A. · 2024-06-09 09:00:39 -03:00
  7d3abb083b
• refactor: unwrap redundant code block
  Breno A. · 2024-06-09 08:58:01 -03:00
  9fa0f2bcad
• refactor: remove unnecessary semicolons
  Breno A. · 2024-06-09 08:56:58 -03:00
  029ef823e1
• refactor: remove unnecessary toString call
  Breno A. · 2024-06-09 08:55:58 -03:00
  c3eafba072
• refactor: replace size() == 0 with isEmpty()
  Breno A. · 2024-06-09 08:54:37 -03:00
  ef58ab3e5a
• refactor: make getGoodsLimit one liner
  Breno A. · 2024-06-09 08:50:40 -03:00
  da61d30f44
• fix: make those fields final
  Breno A. · 2024-06-09 08:47:56 -03:00
  6bb349d92b
• Configuration Update - Shown Email (#2509)

  * This version will allow the private server owner to show a different email then "@grasscutter.io" if they want.
  
  * Update src/main/java/emu/grasscutter/config/ConfigContainer.java
  
  Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
  
  * Update src/main/java/emu/grasscutter/game/Account.java
  
  Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
  
  * Update src/main/java/emu/grasscutter/game/Account.java
  
  Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
  
  ---------
  
  Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>

  KittenPixel · 2024-05-13 21:58:46 -04:00
  4022267888
• Add documentation on 404 error page. (#2463)

  * Update HttpServer.java
  
  * Update HttpServer.java
  
  ---------
  
  Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>

  OmegaPobretón · 2024-01-18 23:30:03 -05:00
  6e1913aacb
• Format code [skip actions]
  github-actions · 2023-12-14 05:36:30 +00:00
  770a793c69
• Fix some more dungeons (#2449)

  * Monds weapon mats domain: Fix time between kill not refreshing
  * Inaz husk domain: Fix broken domain challenge
      * `EVENT_ANY_MONSTER_LIVE` is likely sent on tick, not on create. See scene40801_group240801001.lua:
          1. `condition_EVENT_ANY_MONSTER_LIVE_1023` checks for mob 1008 to spawn AND for variable `challenge` to be 1
          2. Mob 1008 spawns during `action_EVENT_SELECT_OPTION_1003`, at `ScriptLib.AddExtraGroupSuite(context, 240801001, 2)`
          3. This spawn triggers `EVENT_ANY_MONSTER_LIVE` for mob 1008 but still fails the condition because `challenge` is still 0.
          4. `challenge` is set to 1 at the end of `action_EVENT_SELECT_OPTION_1003`. By now, `EVENT_ANY_MONSTER_LIVE` for mob 1008 no longer fires, causing the domain challenge to fail to start.

  longfruit · 2023-12-14 00:34:50 -05:00
  c4402cc287
• Format code [skip actions]
  github-actions · 2023-11-17 04:58:02 +00:00
  cdb0dc560a