diff --git a/bukkit/src/main/java/me/lucko/luckperms/bukkit/migration/MigrationPermissionsEx.java b/bukkit/src/main/java/me/lucko/luckperms/bukkit/migration/MigrationPermissionsEx.java index 76312e8b..96342dd3 100644 --- a/bukkit/src/main/java/me/lucko/luckperms/bukkit/migration/MigrationPermissionsEx.java +++ b/bukkit/src/main/java/me/lucko/luckperms/bukkit/migration/MigrationPermissionsEx.java @@ -91,7 +91,6 @@ public class MigrationPermissionsEx extends SubCommand { super(CommandSpec.MIGRATION_COMMAND.localize(locale), "permissionsex", CommandPermission.MIGRATION, Predicates.alwaysFalse()); } - @SuppressWarnings("deprecation") @Override public CommandResult execute(LuckPermsPlugin plugin, Sender sender, Object o, List args, String label) { ProgressLogger log = new ProgressLogger(Message.MIGRATION_LOG, Message.MIGRATION_LOG_PROGRESS, "PermissionsEx"); @@ -187,7 +186,6 @@ public class MigrationPermissionsEx extends SubCommand { private static Map> getPermanentPermissions(PermissionEntity entity) { try { - //noinspection unchecked PermissionsData data = (PermissionsData) GET_DATA_METHOD.invoke(entity); return data.getPermissionsMap(); } catch (IllegalAccessException | InvocationTargetException e) { diff --git a/common/src/main/java/me/lucko/luckperms/common/cacheddata/type/MetaAccumulator.java b/common/src/main/java/me/lucko/luckperms/common/cacheddata/type/MetaAccumulator.java index 027bc2b5..2a7e182a 100644 --- a/common/src/main/java/me/lucko/luckperms/common/cacheddata/type/MetaAccumulator.java +++ b/common/src/main/java/me/lucko/luckperms/common/cacheddata/type/MetaAccumulator.java @@ -65,6 +65,8 @@ public class MetaAccumulator { private enum State { /** Marks that the accumulator is still gaining (accumulating) new data. */ ACCUMULATING, + /** Marks that this accumulator is being completed. */ + COMPLETING, /** Marks that the process of gaining (accumulating) new data is complete. */ COMPLETE } @@ -102,7 +104,7 @@ public class MetaAccumulator { * data is read. */ public void complete() { - if (!this.state.compareAndSet(State.ACCUMULATING, State.COMPLETE)) { + if (!this.state.compareAndSet(State.ACCUMULATING, State.COMPLETING)) { return; } @@ -110,6 +112,8 @@ public class MetaAccumulator { if (!this.meta.containsKey(NodeTypes.WEIGHT_KEY) && this.weight != 0) { this.meta.put(NodeTypes.WEIGHT_KEY, String.valueOf(this.weight)); } + + this.state.set(State.COMPLETE); } // accumulate methods diff --git a/common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionCheckInherits.java b/common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionCheckInherits.java index ffedefad..69036df8 100644 --- a/common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionCheckInherits.java +++ b/common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionCheckInherits.java @@ -71,7 +71,7 @@ public class PermissionCheckInherits extends SharedSubCommand { } String s = MessageUtils.formatTristate(result.getResult()); - Message.CHECK_INHERITS_PERMISSION.send(sender, holder.getFormattedDisplayName(), node, s, MessageUtils.contextSetToString(plugin.getLocaleManager(), context), String.valueOf(location)); + Message.CHECK_INHERITS_PERMISSION.send(sender, holder.getFormattedDisplayName(), node, s, MessageUtils.contextSetToString(plugin.getLocaleManager(), context), location); return CommandResult.SUCCESS; } diff --git a/common/src/main/java/me/lucko/luckperms/common/commands/misc/TreeCommand.java b/common/src/main/java/me/lucko/luckperms/common/commands/misc/TreeCommand.java index d490f70d..12ee6f6d 100644 --- a/common/src/main/java/me/lucko/luckperms/common/commands/misc/TreeCommand.java +++ b/common/src/main/java/me/lucko/luckperms/common/commands/misc/TreeCommand.java @@ -97,7 +97,7 @@ public class TreeCommand extends SingleCommand { Message.TREE_URL.send(sender); Component message = TextComponent.builder(url).color(TextColor.AQUA) - .clickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, String.valueOf(url))) + .clickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, url)) .hoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, TextComponent.of("Click to open the tree view.").color(TextColor.GRAY))) .build(); diff --git a/common/src/main/java/me/lucko/luckperms/common/commands/misc/VerboseCommand.java b/common/src/main/java/me/lucko/luckperms/common/commands/misc/VerboseCommand.java index 2043d8b4..01d8c454 100644 --- a/common/src/main/java/me/lucko/luckperms/common/commands/misc/VerboseCommand.java +++ b/common/src/main/java/me/lucko/luckperms/common/commands/misc/VerboseCommand.java @@ -118,7 +118,7 @@ public class VerboseCommand extends SingleCommand { Message.VERBOSE_RESULTS_URL.send(sender); Component message = TextComponent.builder(url).color(TextColor.AQUA) - .clickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, String.valueOf(url))) + .clickEvent(new ClickEvent(ClickEvent.Action.OPEN_URL, url)) .hoverEvent(new HoverEvent(HoverEvent.Action.SHOW_TEXT, TextComponent.of("Click to open the results page.").color(TextColor.GRAY))) .build(); diff --git a/common/src/main/java/me/lucko/luckperms/common/commands/user/UserInfo.java b/common/src/main/java/me/lucko/luckperms/common/commands/user/UserInfo.java index 7f6860b8..75742fbd 100644 --- a/common/src/main/java/me/lucko/luckperms/common/commands/user/UserInfo.java +++ b/common/src/main/java/me/lucko/luckperms/common/commands/user/UserInfo.java @@ -54,7 +54,6 @@ public class UserInfo extends SubCommand { super(CommandSpec.USER_INFO.localize(locale), "info", CommandPermission.USER_INFO, Predicates.alwaysFalse()); } - @SuppressWarnings("unchecked") @Override public CommandResult execute(LuckPermsPlugin plugin, Sender sender, User user, List args, String label) { if (ArgumentPermissions.checkViewPerms(plugin, sender, getPermission().get(), user)) { diff --git a/common/src/main/java/me/lucko/luckperms/common/context/ContextManager.java b/common/src/main/java/me/lucko/luckperms/common/context/ContextManager.java index f4ffb22e..34cede38 100644 --- a/common/src/main/java/me/lucko/luckperms/common/context/ContextManager.java +++ b/common/src/main/java/me/lucko/luckperms/common/context/ContextManager.java @@ -196,7 +196,6 @@ public abstract class ContextManager { for (ContextCalculator calculator : ContextManager.this.calculators) { try { MutableContextSet ret = calculator.giveApplicableContext(subject, accumulator); - //noinspection ConstantConditions if (ret == null) { throw new IllegalStateException(calculator.getClass() + " returned a null context set"); } @@ -216,7 +215,6 @@ public abstract class ContextManager { for (StaticContextCalculator calculator : this.staticCalculators) { try { MutableContextSet ret = calculator.giveApplicableContext(accumulator); - //noinspection ConstantConditions if (ret == null) { throw new IllegalStateException(calculator.getClass() + " returned a null context set"); } diff --git a/common/src/main/java/me/lucko/luckperms/common/locale/LocaleManager.java b/common/src/main/java/me/lucko/luckperms/common/locale/LocaleManager.java index 88c98831..7a720078 100644 --- a/common/src/main/java/me/lucko/luckperms/common/locale/LocaleManager.java +++ b/common/src/main/java/me/lucko/luckperms/common/locale/LocaleManager.java @@ -75,7 +75,7 @@ public class LocaleManager { EnumMap messages = new EnumMap<>(Message.class); EnumMap commands = new EnumMap<>(CommandSpec.class); - Map data = (Map) new Yaml().load(reader); + Map data = new Yaml().load(reader); for (Map.Entry entry : data.entrySet()) { if (entry.getKey() == null || entry.getKey().isEmpty() || entry.getValue() == null) { continue; diff --git a/common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableNode.java b/common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableNode.java index 416dfe4e..f27498e3 100644 --- a/common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableNode.java +++ b/common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableNode.java @@ -327,8 +327,8 @@ public final class ImmutableNode implements Node { o1.permission == o2.permission && o1.value == o2.value && o1.override == o2.override && - (o1.server == null ? o2.server == null : o1.server.equals(o2.server)) && - (o1.world == null ? o2.world == null : o1.world.equals(o2.world)) && + Objects.equals(o1.server, o2.server) && + Objects.equals(o1.world, o2.world) && o1.expireAt == o2.expireAt && o1.getContexts().equals(o2.getContexts()); } @@ -339,8 +339,8 @@ public final class ImmutableNode implements Node { return o1 == o2 || o1.permission == o2.permission && o1.override == o2.override && - (o1.server == null ? o2.server == null : o1.server.equals(o2.server)) && - (o1.world == null ? o2.world == null : o1.world.equals(o2.world)) && + Objects.equals(o1.server, o2.server) && + Objects.equals(o1.world, o2.world) && o1.expireAt == o2.expireAt && o1.getContexts().equals(o2.getContexts()); } @@ -352,8 +352,8 @@ public final class ImmutableNode implements Node { o1.permission == o2.permission && o1.value == o2.value && o1.override == o2.override && - (o1.server == null ? o2.server == null : o1.server.equals(o2.server)) && - (o1.world == null ? o2.world == null : o1.world.equals(o2.world)) && + Objects.equals(o1.server, o2.server) && + Objects.equals(o1.world, o2.world) && o1.isTemporary() == o2.isTemporary() && o1.getContexts().equals(o2.getContexts()); } @@ -364,8 +364,8 @@ public final class ImmutableNode implements Node { return o1 == o2 || o1.permission == o2.permission && o1.override == o2.override && - (o1.server == null ? o2.server == null : o1.server.equals(o2.server)) && - (o1.world == null ? o2.world == null : o1.world.equals(o2.world)) && + Objects.equals(o1.server, o2.server) && + Objects.equals(o1.world, o2.world) && o1.isTemporary() == o2.isTemporary() && o1.getContexts().equals(o2.getContexts()); } @@ -376,8 +376,8 @@ public final class ImmutableNode implements Node { return o1 == o2 || o1.permission == o2.permission && o1.override == o2.override && - (o1.server == null ? o2.server == null : o1.server.equals(o2.server)) && - (o1.world == null ? o2.world == null : o1.world.equals(o2.world)) && + Objects.equals(o1.server, o2.server) && + Objects.equals(o1.world, o2.world) && o1.getContexts().equals(o2.getContexts()); } }; diff --git a/common/src/main/java/me/lucko/luckperms/common/node/model/NodeHeldPermission.java b/common/src/main/java/me/lucko/luckperms/common/node/model/NodeHeldPermission.java index de2dfeab..7554e091 100644 --- a/common/src/main/java/me/lucko/luckperms/common/node/model/NodeHeldPermission.java +++ b/common/src/main/java/me/lucko/luckperms/common/node/model/NodeHeldPermission.java @@ -71,15 +71,13 @@ public final class NodeHeldPermission> implements HeldPe return this.node.getWorld(); } - @NonNull @Override - public OptionalLong getExpiry() { + public @NonNull OptionalLong getExpiry() { return this.node.isTemporary() ? OptionalLong.of(this.node.getExpiryUnixTime()) : OptionalLong.empty(); } - @NonNull @Override - public ContextSet getContexts() { + public @NonNull ContextSet getContexts() { return this.node.getContexts(); } diff --git a/common/src/main/java/me/lucko/luckperms/common/sender/AbstractSender.java b/common/src/main/java/me/lucko/luckperms/common/sender/AbstractSender.java index 88090edd..4ca86472 100644 --- a/common/src/main/java/me/lucko/luckperms/common/sender/AbstractSender.java +++ b/common/src/main/java/me/lucko/luckperms/common/sender/AbstractSender.java @@ -91,7 +91,6 @@ public final class AbstractSender implements Sender { } } - @SuppressWarnings("deprecation") @Override public void sendMessage(Component message) { if (isConsole()) { diff --git a/common/src/main/java/me/lucko/luckperms/common/sender/DummySender.java b/common/src/main/java/me/lucko/luckperms/common/sender/DummySender.java index 8063eade..304409ef 100644 --- a/common/src/main/java/me/lucko/luckperms/common/sender/DummySender.java +++ b/common/src/main/java/me/lucko/luckperms/common/sender/DummySender.java @@ -56,7 +56,6 @@ public abstract class DummySender implements Sender { consumeMessage(message); } - @SuppressWarnings("deprecation") @Override public void sendMessage(Component message) { consumeMessage(TextUtils.toLegacy(message)); diff --git a/common/src/main/java/me/lucko/luckperms/common/util/ImmutableCollectors.java b/common/src/main/java/me/lucko/luckperms/common/util/ImmutableCollectors.java index 67395d39..42083424 100644 --- a/common/src/main/java/me/lucko/luckperms/common/util/ImmutableCollectors.java +++ b/common/src/main/java/me/lucko/luckperms/common/util/ImmutableCollectors.java @@ -63,7 +63,6 @@ public final class ImmutableCollectors { } public static > Collector, ImmutableSet> toEnumSet(Class clazz) { - //noinspection unchecked return Collector.of( () -> EnumSet.noneOf(clazz), EnumSet::add, diff --git a/common/src/main/java/me/lucko/luckperms/common/util/LoadingMap.java b/common/src/main/java/me/lucko/luckperms/common/util/LoadingMap.java index c4364fae..61ca9c6e 100644 --- a/common/src/main/java/me/lucko/luckperms/common/util/LoadingMap.java +++ b/common/src/main/java/me/lucko/luckperms/common/util/LoadingMap.java @@ -63,6 +63,7 @@ public class LoadingMap extends ForwardingMap implements Map { if (value != null) { return value; } + //noinspection unchecked return this.map.computeIfAbsent((K) key, this.function); } } \ No newline at end of file diff --git a/common/src/main/java/me/lucko/luckperms/common/verbose/VerboseHandler.java b/common/src/main/java/me/lucko/luckperms/common/verbose/VerboseHandler.java index 95d80ade..3f0de026 100644 --- a/common/src/main/java/me/lucko/luckperms/common/verbose/VerboseHandler.java +++ b/common/src/main/java/me/lucko/luckperms/common/verbose/VerboseHandler.java @@ -79,7 +79,6 @@ public class VerboseHandler extends RepeatingTask { return; } - //noinspection ThrowableNotThrown StackTraceElement[] trace = new Exception().getStackTrace(); // add the check data to a queue to be processed later. @@ -104,7 +103,6 @@ public class VerboseHandler extends RepeatingTask { return; } - //noinspection ThrowableNotThrown StackTraceElement[] trace = new Exception().getStackTrace(); // add the check data to a queue to be processed later. diff --git a/sponge/sponge-service-api6/src/main/java/me/lucko/luckperms/sponge/service/proxy/api6/DescriptionBuilder.java b/sponge/sponge-service-api6/src/main/java/me/lucko/luckperms/sponge/service/proxy/api6/DescriptionBuilder.java index 5be56ca0..b22885ee 100644 --- a/sponge/sponge-service-api6/src/main/java/me/lucko/luckperms/sponge/service/proxy/api6/DescriptionBuilder.java +++ b/sponge/sponge-service-api6/src/main/java/me/lucko/luckperms/sponge/service/proxy/api6/DescriptionBuilder.java @@ -115,8 +115,8 @@ public final class DescriptionBuilder implements PermissionDescription.Builder, return this.container.equals(other.container) && this.roles.equals(other.roles) && - (this.id == null ? other.id == null : this.id.equals(other.id)) && - (this.description == null ? other.description == null : this.description.equals(other.description)); + Objects.equals(this.id, other.id) && + Objects.equals(this.description, other.description); } @Override diff --git a/sponge/sponge-service-api7/src/main/java/me/lucko/luckperms/sponge/service/proxy/api7/DescriptionBuilder.java b/sponge/sponge-service-api7/src/main/java/me/lucko/luckperms/sponge/service/proxy/api7/DescriptionBuilder.java index 4d68e3d7..8b843a2a 100644 --- a/sponge/sponge-service-api7/src/main/java/me/lucko/luckperms/sponge/service/proxy/api7/DescriptionBuilder.java +++ b/sponge/sponge-service-api7/src/main/java/me/lucko/luckperms/sponge/service/proxy/api7/DescriptionBuilder.java @@ -114,8 +114,8 @@ public final class DescriptionBuilder implements PermissionDescription.Builder, return this.container.equals(other.container) && this.roles.equals(other.roles) && - (this.id == null ? other.id == null : this.id.equals(other.id)) && - (this.description == null ? other.description == null : this.description.equals(other.description)); + Objects.equals(this.id, other.id) && + Objects.equals(this.description, other.description); } @Override diff --git a/sponge/src/main/java/me/lucko/luckperms/sponge/service/ProxyFactory.java b/sponge/src/main/java/me/lucko/luckperms/sponge/service/ProxyFactory.java index 3fe9798a..c0c3b756 100644 --- a/sponge/src/main/java/me/lucko/luckperms/sponge/service/ProxyFactory.java +++ b/sponge/src/main/java/me/lucko/luckperms/sponge/service/ProxyFactory.java @@ -45,7 +45,6 @@ public final class ProxyFactory { private static final boolean IS_API_7 = isApi7(); private static boolean isApi7() { try { - //noinspection JavaReflectionMemberAccess Subject.class.getDeclaredMethod("asSubjectReference"); return true; } catch (NoSuchMethodException e) { diff --git a/sponge/src/main/java/me/lucko/luckperms/sponge/service/model/calculated/CalculatedSubjectData.java b/sponge/src/main/java/me/lucko/luckperms/sponge/service/model/calculated/CalculatedSubjectData.java index 89f2549c..f2623d02 100644 --- a/sponge/src/main/java/me/lucko/luckperms/sponge/service/model/calculated/CalculatedSubjectData.java +++ b/sponge/src/main/java/me/lucko/luckperms/sponge/service/model/calculated/CalculatedSubjectData.java @@ -240,11 +240,7 @@ public class CalculatedSubjectData implements LPSubjectData { // flatten Set result = new LinkedHashSet<>(); for (Set set : sorted.values()) { - for (LPSubjectReference e : set) { - if (!result.contains(e)) { - result.add(e); - } - } + result.addAll(set); } return result; } diff --git a/velocity/src/main/java/me/lucko/luckperms/velocity/VelocityCommandExecutor.java b/velocity/src/main/java/me/lucko/luckperms/velocity/VelocityCommandExecutor.java index 6f87fe43..5722251e 100644 --- a/velocity/src/main/java/me/lucko/luckperms/velocity/VelocityCommandExecutor.java +++ b/velocity/src/main/java/me/lucko/luckperms/velocity/VelocityCommandExecutor.java @@ -51,7 +51,7 @@ public class VelocityCommandExecutor implements Command { } @Override - public void execute(@NonNull CommandSource source, String[] args) { + public void execute(@NonNull CommandSource source, @NonNull String[] args) { Sender lpSender = this.plugin.getSenderFactory().wrap(source); List arguments = CommandManager.stripQuotes(ARGUMENT_SPLITTER.splitToList(ARGUMENT_JOINER.join(args))); @@ -59,7 +59,7 @@ public class VelocityCommandExecutor implements Command { } @Override - public List suggest(@NonNull CommandSource source, String[] args) { + public List suggest(@NonNull CommandSource source, @NonNull String[] args) { Sender lpSender = this.plugin.getSenderFactory().wrap(source); List arguments = CommandManager.stripQuotes(TAB_COMPLETE_ARGUMENT_SPLITTER.splitToList(ARGUMENT_JOINER.join(args)));