Move stuff into commons, rename PermissionObject, add more javadocs to api

bukkit/src/main/java/me/lucko/luckperms/BukkitCommand.java

@@ -1,49 +1,43 @@
 package me.lucko.luckperms;
 
 import me.lucko.luckperms.commands.CommandManager;
-import me.lucko.luckperms.commands.Sender;
+import me.lucko.luckperms.commands.SenderFactory;
 import org.bukkit.command.Command;
 import org.bukkit.command.CommandExecutor;
 import org.bukkit.command.CommandSender;
 import org.bukkit.command.TabExecutor;
 
-import java.lang.ref.WeakReference;
 import java.util.Arrays;
 import java.util.List;
 
 class BukkitCommand extends CommandManager implements CommandExecutor, TabExecutor {
+    private static final Factory FACTORY = new Factory();
+
     BukkitCommand(LuckPermsPlugin plugin) {
         super(plugin);
     }
 
     @Override
     public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {
-        return onCommand(makeSender(sender), label, Arrays.asList(args));
+        return onCommand(FACTORY.wrap(sender), label, Arrays.asList(args));
     }
 
 
     @Override
     public List<String> onTabComplete(CommandSender sender, Command command, String label, String[] args) {
-        return onTabComplete(makeSender(sender), Arrays.asList(args));
+        return onTabComplete(FACTORY.wrap(sender), Arrays.asList(args));
     }
 
-    private static Sender makeSender(CommandSender sender) {
-        return new Sender() {
-            final WeakReference<CommandSender> cs = new WeakReference<>(sender);
+    private static class Factory extends SenderFactory<CommandSender> {
 
-            @Override
-            public void sendMessage(String s) {
-                final CommandSender c = cs.get();
-                if (c != null) {
-                    c.sendMessage(s);
-                }
-            }
+        @Override
+        protected void sendMessage(CommandSender sender, String s) {
+            sender.sendMessage(s);
+        }
 
-            @Override
-            public boolean hasPermission(String node) {
-                final CommandSender c = cs.get();
-                return c != null && c.hasPermission(node);
-            }
-        };
+        @Override
+        protected boolean hasPermission(CommandSender sender, String node) {
+            return sender.hasPermission(node);
+        }
     }
 }