worldofcraft/LuckPerms-DBA
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

improve speed of NodeTools#removeSamePermission

Browse Source
This commit is contained in:
Luck 2017-04-23 11:51:56 +01:00
parent 7bfd5d4bc8
commit af8fd15929
No known key found for this signature in database
GPG Key ID: EFA9B3EC5FD90F8B
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
common/src/main/java/me/lucko/luckperms/common/utils/NodeTools.java
View File

@ -30,8 +30,10 @@ import lombok.experimental.UtilityClass;
import me.lucko.luckperms.api.Node; import me.lucko.luckperms.api.Node;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.HashSet;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
import java.util.Set;
@UtilityClass @UtilityClass
public class NodeTools { public class NodeTools {
@ -88,19 +90,14 @@ public class NodeTools {
} }
public static <T extends Node> void removeSamePermission(Iterator<T> it) { public static <T extends Node> void removeSamePermission(Iterator<T> it) {
List<T> alreadyIn = new ArrayList<>(); Set<String> alreadyIn = new HashSet<>();
iter:
while (it.hasNext()) { while (it.hasNext()) {
T next = it.next(); T next = it.next();
for (T n : alreadyIn) {
if (next.getPermission().equals(n.getPermission())) {
it.remove();
continue iter;
}
}
alreadyIn.add(next); if (!alreadyIn.add(next.getPermission())) {
it.remove();
}
} }
} }
} }