From 7dc41e15d371de128716fc05438066ff9c6818d1 Mon Sep 17 00:00:00 2001
From: Luck <git@lucko.me>
Date: Sat, 6 May 2017 18:24:44 +0100
Subject: [PATCH] Fix users being cleaned up too early and then logging back
 into the server - closes #271

---
 .../managers/impl/GenericUserManager.java       | 17 ++++++++++++-----
 .../common/storage/AbstractStorage.java         |  5 ++++-
 2 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/common/src/main/java/me/lucko/luckperms/common/managers/impl/GenericUserManager.java b/common/src/main/java/me/lucko/luckperms/common/managers/impl/GenericUserManager.java
index dfc7ab59..780e9ae6 100644
--- a/common/src/main/java/me/lucko/luckperms/common/managers/impl/GenericUserManager.java
+++ b/common/src/main/java/me/lucko/luckperms/common/managers/impl/GenericUserManager.java
@@ -142,12 +142,19 @@ public class GenericUserManager extends AbstractManager<UserIdentifier, User> im
     @Override
     public void scheduleUnload(UUID uuid) {
         plugin.getScheduler().doAsyncLater(() -> {
-            User user = getIfLoaded(plugin.getUuidCache().getUUID(uuid));
-            if (user != null && !plugin.isPlayerOnline(uuid)) {
-                user.unregisterData();
-                unload(user);
+            // check once to see if the user can be unloaded.
+            if (getIfLoaded(plugin.getUuidCache().getUUID(uuid)) != null && !plugin.isPlayerOnline(uuid)) {
+
+                // check again in 40 ticks, we want to be sure the player won't have re-logged before we unload them.
+                plugin.getScheduler().doAsyncLater(() -> {
+                    User user = getIfLoaded(plugin.getUuidCache().getUUID(uuid));
+                    if (user != null && !plugin.isPlayerOnline(uuid)) {
+                        user.unregisterData();
+                        unload(user);
+                        plugin.getUuidCache().clearCache(uuid);
+                    }
+                }, 40L);
             }
-            plugin.getUuidCache().clearCache(uuid);
         }, 40L);
     }
 
diff --git a/common/src/main/java/me/lucko/luckperms/common/storage/AbstractStorage.java b/common/src/main/java/me/lucko/luckperms/common/storage/AbstractStorage.java
index f34be345..cd2a4cb0 100644
--- a/common/src/main/java/me/lucko/luckperms/common/storage/AbstractStorage.java
+++ b/common/src/main/java/me/lucko/luckperms/common/storage/AbstractStorage.java
@@ -104,7 +104,10 @@ public class AbstractStorage implements Storage {
     public CompletableFuture<Boolean> loadUser(UUID uuid, String username) {
         return makeFuture(() -> {
             if (backing.loadUser(uuid, username)) {
-                plugin.getApiProvider().getEventFactory().handleUserLoad(plugin.getUserManager().getIfLoaded(uuid));
+                User u = plugin.getUserManager().getIfLoaded(uuid);
+                if (u != null) {
+                    plugin.getApiProvider().getEventFactory().handleUserLoad(u);
+                }
                 return true;
             }
             return false;