worldofcraft/LuckPerms-DBA
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix connection leaking on batch inserts; fix IDEA analyser warning

Browse Source
This commit is contained in:
bakatrouble 2016-12-25 20:07:02 +03:00 committed by Luck
parent a8fea0fc49
commit 4c93bf7cf0
1 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/src/main/java/me/lucko/luckperms/common/storage/backing/SQLBacking.java
View File

@ -43,6 +43,7 @@ import java.io.InputStream;
import java.io.InputStreamReader; import java.io.InputStreamReader;
import java.lang.reflect.Type; import java.lang.reflect.Type;
import java.nio.charset.StandardCharsets; import java.nio.charset.StandardCharsets;
import java.sql.Connection;
import java.sql.PreparedStatement; import java.sql.PreparedStatement;
import java.sql.SQLException; import java.sql.SQLException;
import java.sql.Statement; import java.sql.Statement;
@ -103,7 +104,7 @@ public class SQLBacking extends AbstractBacking {
return provider.runQuery(query, queryRS); return provider.runQuery(query, queryRS);
} }
public boolean tableExists(String table) throws SQLException { private boolean tableExists(String table) throws SQLException {
return provider.getConnection().getMetaData().getTables(null, null, table.toUpperCase(), null).next(); return provider.getConnection().getMetaData().getTables(null, null, table.toUpperCase(), null).next();
} }
@ -292,7 +293,8 @@ public class SQLBacking extends AbstractBacking {
} }
List<NodeDataHolder> data = user.getNodes().stream().map(NodeDataHolder::fromNode).collect(Collectors.toList()); List<NodeDataHolder> data = user.getNodes().stream().map(NodeDataHolder::fromNode).collect(Collectors.toList());
try (PreparedStatement ps = provider.getConnection().prepareStatement(prefix.apply(USER_PERMISSIONS_INSERT))) { try (Connection connection = provider.getConnection()) {
try (PreparedStatement ps = connection.prepareStatement(prefix.apply(USER_PERMISSIONS_INSERT))) {
for (NodeDataHolder nd : data) { for (NodeDataHolder nd : data) {
ps.setString(1, user.getUuid().toString()); ps.setString(1, user.getUuid().toString());
ps.setString(2, nd.getPermission()); ps.setString(2, nd.getPermission());
@ -304,6 +306,7 @@ public class SQLBacking extends AbstractBacking {
ps.addBatch(); ps.addBatch();
} }
ps.executeBatch(); ps.executeBatch();
}
} catch (SQLException e) { } catch (SQLException e) {
e.printStackTrace(); e.printStackTrace();
} }