worldofcraft/LuckPerms-DBA
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor extended node types, general cleanup

Browse Source
This commit is contained in:
Luck
2018-05-02 20:18:48 +01:00
Unverified
parent b9acb84119
commit 4547b52748
137 changed files with 1401 additions and 1186 deletions
Download Patch File Download Diff File Expand all files Collapse all files
common/src/main/java/me/lucko/luckperms/common/api/delegates/manager/ApiGroupManager.java
+1 -1
View File
@@ -31,7 +31,7 @@ import me.lucko.luckperms.common.api.ApiUtils;
import me.lucko.luckperms.common.api.delegates.model.ApiGroup;
import me.lucko.luckperms.common.managers.group.GroupManager;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.utils.ImmutableCollectors;
common/src/main/java/me/lucko/luckperms/common/api/delegates/manager/ApiUserManager.java
+1 -1
View File
@@ -29,8 +29,8 @@ import me.lucko.luckperms.common.api.ApiUtils;
import me.lucko.luckperms.common.api.delegates.model.ApiUser;
import me.lucko.luckperms.common.managers.user.UserManager;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.model.UserIdentifier;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.UserIdentifier;
import me.lucko.luckperms.common.utils.ImmutableCollectors;
import java.util.Objects;
common/src/main/java/me/lucko/luckperms/common/api/delegates/misc/ApiNodeFactory.java
+1 -1
View File
@@ -29,7 +29,7 @@ import me.lucko.luckperms.api.ChatMetaType;
import me.lucko.luckperms.api.Group;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.common.api.delegates.model.ApiGroup;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import java.util.Objects;
common/src/main/java/me/lucko/luckperms/common/api/delegates/model/ApiPermissionHolder.java
+38 -11
View File
@@ -36,6 +36,7 @@ import me.lucko.luckperms.api.DataMutateResult;
import me.lucko.luckperms.api.LocalizedNode;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.NodeEqualityPredicate;
import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.Tristate;
import me.lucko.luckperms.api.caching.CachedData;
import me.lucko.luckperms.api.context.ContextSet;
@@ -44,14 +45,18 @@ import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.MetaType;
import me.lucko.luckperms.common.node.comparator.NodeWithContextComparator;
import me.lucko.luckperms.common.node.utils.MetaType;
import me.lucko.luckperms.common.node.utils.NodeTools;
import me.lucko.luckperms.common.utils.ImmutableCollectors;
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Set;
import java.util.SortedSet;
import java.util.TreeSet;
import java.util.concurrent.CompletableFuture;
import java.util.function.Predicate;
@@ -99,13 +104,13 @@ public class ApiPermissionHolder implements me.lucko.luckperms.api.PermissionHol
@Nonnull
@Override
public ImmutableSetMultimap<ImmutableContextSet, Node> getNodes() {
return this.handle.getEnduringNodes();
return this.handle.enduringData().immutable();
}
@Nonnull
@Override
public ImmutableSetMultimap<ImmutableContextSet, Node> getTransientNodes() {
return this.handle.getTransientNodes();
return this.handle.transientData().immutable();
}
@Nonnull
@@ -123,33 +128,55 @@ public class ApiPermissionHolder implements me.lucko.luckperms.api.PermissionHol
@Nonnull
@Override
public Set<Node> getEnduringPermissions() {
return ImmutableSet.copyOf(this.handle.getEnduringNodes().values());
return ImmutableSet.copyOf(this.handle.enduringData().immutable().values());
}
@Nonnull
@Override
public Set<Node> getTransientPermissions() {
return ImmutableSet.copyOf(this.handle.getTransientNodes().values());
return ImmutableSet.copyOf(this.handle.transientData().immutable().values());
}
@Nonnull
@Override
public SortedSet<LocalizedNode> getAllNodes(@Nonnull Contexts contexts) {
Objects.requireNonNull(contexts, "contexts");
return ImmutableSortedSet.copyOfSorted(this.handle.resolveInheritancesAlmostEqual(contexts));
List<LocalizedNode> nodes = new LinkedList<>();
this.handle.accumulateInheritancesTo(nodes, contexts);
NodeTools.removeEqual(nodes.iterator(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(nodes);
return ImmutableSortedSet.copyOfSorted(ret);
}
@Nonnull
@Override
public SortedSet<LocalizedNode> getAllNodes() {
return ImmutableSortedSet.copyOfSorted(this.handle.resolveInheritancesAlmostEqual());
List<LocalizedNode> nodes = new LinkedList<>();
this.handle.accumulateInheritancesTo(nodes);
NodeTools.removeEqual(nodes.iterator(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(nodes);
return ImmutableSortedSet.copyOfSorted(ret);
}
@Nonnull
@Override
public Set<LocalizedNode> getAllNodesFiltered(@Nonnull Contexts contexts) {
Objects.requireNonNull(contexts, "contexts");
return ImmutableSet.copyOf(this.handle.getAllNodes(contexts));
List<LocalizedNode> entries = this.handle.getAllEntries(contexts);
NodeTools.removeSamePermission(entries.iterator());
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(entries);
return ImmutableSet.copyOf(ret);
}
@Nonnull
@@ -187,21 +214,21 @@ public class ApiPermissionHolder implements me.lucko.luckperms.api.PermissionHol
@Override
public Tristate hasPermission(@Nonnull Node node) {
Objects.requireNonNull(node, "node");
return this.handle.hasPermission(NodeMapType.ENDURING, node);
return this.handle.hasPermission(NodeMapType.ENDURING, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
}
@Nonnull
@Override
public Tristate hasTransientPermission(@Nonnull Node node) {
Objects.requireNonNull(node, "node");
return this.handle.hasPermission(NodeMapType.TRANSIENT, node);
return this.handle.hasPermission(NodeMapType.TRANSIENT, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
}
@Nonnull
@Override
public Tristate inheritsPermission(@Nonnull Node node) {
Objects.requireNonNull(node, "node");
return this.handle.inheritsPermission(node);
return this.handle.inheritsPermission(node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
}
@Override
common/src/main/java/me/lucko/luckperms/common/api/delegates/model/ApiStorage.java
+1 -1
View File
@@ -33,7 +33,7 @@ import me.lucko.luckperms.api.Track;
import me.lucko.luckperms.api.User;
import me.lucko.luckperms.api.event.cause.CreationCause;
import me.lucko.luckperms.api.event.cause.DeletionCause;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.storage.Storage;
common/src/main/java/me/lucko/luckperms/common/api/delegates/model/ApiUser.java
+4 -2
View File
@@ -28,9 +28,11 @@ package me.lucko.luckperms.common.api.delegates.model;
import com.google.common.base.Preconditions;
import me.lucko.luckperms.api.DataMutateResult;
import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.caching.UserData;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import java.util.Objects;
import java.util.UUID;
@@ -80,7 +82,7 @@ public final class ApiUser extends ApiPermissionHolder implements me.lucko.luckp
return DataMutateResult.ALREADY_HAS;
}
if (!this.handle.hasPermission(NodeFactory.buildGroupNode(group.toLowerCase()).build()).asBoolean()) {
if (!this.handle.hasPermission(NodeMapType.ENDURING, NodeFactory.buildGroupNode(group.toLowerCase()).build(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE).asBoolean()) {
return DataMutateResult.FAIL;
}
common/src/main/java/me/lucko/luckperms/common/assignments/AssignmentExpression.java
+3 -2
View File
@@ -30,8 +30,9 @@ import com.google.common.collect.ImmutableList;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.Tristate;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.LegacyNodeFactory;
import me.lucko.luckperms.common.node.factory.LegacyNodeFactory;
import me.lucko.luckperms.common.utils.Scripting;
import java.util.List;
@@ -61,7 +62,7 @@ public class AssignmentExpression {
throw new NullPointerException("script engine");
}
Predicate<Node> checker = node -> holder.hasPermission(node, StandardNodeEquality.IGNORE_VALUE_OR_IF_TEMPORARY) == tristate;
Predicate<Node> checker = node -> holder.hasPermission(NodeMapType.ENDURING, node, StandardNodeEquality.IGNORE_VALUE_OR_IF_TEMPORARY) == tristate;
String exp = this.expression.stream().map(t -> t.forExpression(checker)).collect(Collectors.joining())
.replace("&", "&&").replace("|", "||");
common/src/main/java/me/lucko/luckperms/common/assignments/AssignmentRule.java
+1 -1
View File
@@ -28,7 +28,7 @@ package me.lucko.luckperms.common.assignments;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.Tristate;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.LegacyNodeFactory;
import me.lucko.luckperms.common.node.factory.LegacyNodeFactory;
import me.lucko.luckperms.common.utils.ImmutableCollectors;
import java.util.List;
common/src/main/java/me/lucko/luckperms/common/backup/Exporter.java
+5 -5
View File
@@ -29,11 +29,11 @@ import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.logging.ProgressLogger;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.HolderType;
import me.lucko.luckperms.common.model.Track;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.storage.Storage;
@@ -127,7 +127,7 @@ public class Exporter implements Runnable {
}
write(writer, "# Export group: " + group.getName());
for (Node node : group.getEnduringNodes().values()) {
for (Node node : group.enduringData().immutable().values()) {
write(writer, "/lp " + NodeFactory.nodeAsCommand(node, group.getName(), HolderType.GROUP, true));
}
write(writer, "");
@@ -217,7 +217,7 @@ public class Exporter implements Runnable {
output.add("# Export user: " + user.getUuid().toString() + " - " + user.getName().orElse("unknown username"));
boolean inDefault = false;
for (Node node : user.getEnduringNodes().values()) {
for (Node node : user.enduringData().immutable().values()) {
if (node.isGroupNode() && node.getGroupName().equalsIgnoreCase(NodeFactory.DEFAULT_GROUP_NAME)) {
inDefault = true;
continue;
@@ -242,7 +242,7 @@ public class Exporter implements Runnable {
}
// all of the threads have been scheduled now and are running. we just need to wait for them all to complete
CompletableFuture<Void> overallFuture = CompletableFuture.allOf(futures.toArray(new CompletableFuture[futures.size()]));
CompletableFuture<Void> overallFuture = CompletableFuture.allOf(futures.toArray(new CompletableFuture[0]));
while (true) {
try {
common/src/main/java/me/lucko/luckperms/common/backup/Importer.java
+1 -1
View File
@@ -142,7 +142,7 @@ public class Importer implements Runnable {
}
// all of the threads have been scheduled now and are running. we just need to wait for them all to complete
CompletableFuture<Void> overallFuture = CompletableFuture.allOf(futures.toArray(new CompletableFuture[futures.size()]));
CompletableFuture<Void> overallFuture = CompletableFuture.allOf(futures.toArray(new CompletableFuture[0]));
this.notify.forEach(s -> Message.IMPORT_INFO.send(s, "All commands have been processed and scheduled - now waiting for the execution to complete."));
common/src/main/java/me/lucko/luckperms/common/bulkupdate/BulkUpdate.java
+3 -3
View File
@@ -27,7 +27,7 @@ package me.lucko.luckperms.common.bulkupdate;
import me.lucko.luckperms.common.bulkupdate.action.Action;
import me.lucko.luckperms.common.bulkupdate.constraint.Constraint;
import me.lucko.luckperms.common.node.NodeModel;
import me.lucko.luckperms.common.node.model.NodeDataContainer;
import java.util.List;
import java.util.Objects;
@@ -59,7 +59,7 @@ public final class BulkUpdate {
* @param node the node to check
* @return true if satisfied
*/
public boolean satisfiesConstraints(NodeModel node) {
public boolean satisfiesConstraints(NodeDataContainer node) {
for (Constraint constraint : this.constraints) {
if (!constraint.isSatisfiedBy(node)) {
return false;
@@ -74,7 +74,7 @@ public final class BulkUpdate {
* @param from the node to base changes from
* @return the new nodemodel instance, or null if the node should be deleted.
*/
public NodeModel apply(NodeModel from) {
public NodeDataContainer apply(NodeDataContainer from) {
if (!satisfiesConstraints(from)) {
return from; // make no change
}
common/src/main/java/me/lucko/luckperms/common/bulkupdate/action/Action.java
+2 -2
View File
@@ -25,7 +25,7 @@
package me.lucko.luckperms.common.bulkupdate.action;
import me.lucko.luckperms.common.node.NodeModel;
import me.lucko.luckperms.common.node.model.NodeDataContainer;
/**
* Represents an action to be applied to a given node.
@@ -45,7 +45,7 @@ public interface Action {
* @param from the node to base changes from
* @return the new nodemodel instance, or null if the node should be deleted.
*/
NodeModel apply(NodeModel from);
NodeDataContainer apply(NodeDataContainer from);
/**
* Gets this action in SQL form.
common/src/main/java/me/lucko/luckperms/common/bulkupdate/action/DeleteAction.java
+2 -2
View File
@@ -25,7 +25,7 @@
package me.lucko.luckperms.common.bulkupdate.action;
import me.lucko.luckperms.common.node.NodeModel;
import me.lucko.luckperms.common.node.model.NodeDataContainer;
public class DeleteAction implements Action {
@@ -42,7 +42,7 @@ public class DeleteAction implements Action {
}
@Override
public NodeModel apply(NodeModel from) {
public NodeDataContainer apply(NodeDataContainer from) {
return null; // this action just deletes nodes, so return null
}
common/src/main/java/me/lucko/luckperms/common/bulkupdate/action/UpdateAction.java
+2 -2
View File
@@ -27,7 +27,7 @@ package me.lucko.luckperms.common.bulkupdate.action;
import me.lucko.luckperms.common.bulkupdate.BulkUpdate;
import me.lucko.luckperms.common.bulkupdate.constraint.QueryField;
import me.lucko.luckperms.common.node.NodeModel;
import me.lucko.luckperms.common.node.model.NodeDataContainer;
public class UpdateAction implements Action {
@@ -52,7 +52,7 @@ public class UpdateAction implements Action {
}
@Override
public NodeModel apply(NodeModel from) {
public NodeDataContainer apply(NodeDataContainer from) {
switch (this.field) {
case PERMISSION:
return from.setPermission(this.value);
common/src/main/java/me/lucko/luckperms/common/bulkupdate/constraint/Constraint.java
+2 -2
View File
@@ -27,7 +27,7 @@ package me.lucko.luckperms.common.bulkupdate.constraint;
import me.lucko.luckperms.common.bulkupdate.BulkUpdate;
import me.lucko.luckperms.common.bulkupdate.comparisons.Comparison;
import me.lucko.luckperms.common.node.NodeModel;
import me.lucko.luckperms.common.node.model.NodeDataContainer;
/**
* Represents a query constraint
@@ -59,7 +59,7 @@ public class Constraint {
* @param node the node
* @return true if satisfied
*/
public boolean isSatisfiedBy(NodeModel node) {
public boolean isSatisfiedBy(NodeDataContainer node) {
switch (this.field) {
case PERMISSION:
return this.comparison.matches(node.getPermission(), this.value);
common/src/main/java/me/lucko/luckperms/common/caching/GroupCachedData.java
+1 -1
View File
@@ -29,7 +29,7 @@ import me.lucko.luckperms.api.Contexts;
import me.lucko.luckperms.api.caching.GroupData;
import me.lucko.luckperms.common.calculators.PermissionCalculatorMetadata;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.model.HolderType;
/**
* Holds an easily accessible cache of a groups's data in a number of contexts
common/src/main/java/me/lucko/luckperms/common/caching/UserCachedData.java
+1 -1
View File
@@ -28,8 +28,8 @@ package me.lucko.luckperms.common.caching;
import me.lucko.luckperms.api.Contexts;
import me.lucko.luckperms.api.caching.UserData;
import me.lucko.luckperms.common.calculators.PermissionCalculatorMetadata;
import me.lucko.luckperms.common.model.HolderType;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.references.HolderType;
/**
* Holds an easily accessible cache of a user's data in a number of contexts
common/src/main/java/me/lucko/luckperms/common/caching/handlers/CachedStateManager.java
-115
View File
@@ -1,115 +0,0 @@
/*
* This file is part of LuckPerms, licensed under the MIT License.
*
* Copyright (c) lucko (Luck) <luck@lucko.me>
* Copyright (c) contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
package me.lucko.luckperms.common.caching.handlers;
import com.google.common.collect.HashMultimap;
import com.google.common.collect.Multimap;
import me.lucko.luckperms.common.references.HolderReference;
import java.util.HashSet;
import java.util.Set;
import java.util.concurrent.locks.ReentrantLock;
/**
* Manages the cached state of all permission holders
*/
public class CachedStateManager {
// Group --> Groups/Users that inherit from that group. (reverse relationship)
private final Multimap<HolderReference, HolderReference> map = HashMultimap.create();
private final ReentrantLock lock = new ReentrantLock();
/**
* Gets a set of holder names that inherit permissions (either directly or via other groups)
* from the given holder name
*
* @param holder the holder name to query for
* @return a set of inherited groups
*/
public Set<HolderReference> getInheritances(HolderReference holder) {
Set<HolderReference> set = new HashSet<>();
set.add(holder);
this.lock.lock();
try {
while (true) {
Set<HolderReference> clone = new HashSet<>(set);
boolean work = false;
for (HolderReference s : clone) {
if (set.addAll(this.map.get(s))) {
work = true;
}
}
if (!work) {
break;
}
}
} finally {
this.lock.unlock();
}
set.remove(holder);
return set;
}
/**
* Registers a holder and the groups they inherit from within this map.
*
* @param holder the holder to add
* @param inheritedGroups a list of groups the holder inherits from
*/
public void putAll(HolderReference holder, Set<HolderReference> inheritedGroups) {
this.lock.lock();
try {
this.map.entries().removeIf(entry -> entry.getValue().equals(holder));
for (HolderReference child : inheritedGroups) {
this.map.put(child, holder);
}
} finally {
this.lock.unlock();
}
}
/**
* Clears defined inheritances for the given holder name.
*
* @param holder the holder name to clear
*/
public void clear(HolderReference holder) {
this.lock.lock();
try {
this.map.entries().removeIf(entry -> entry.getValue().equals(holder));
} finally {
this.lock.unlock();
}
}
}
common/src/main/java/me/lucko/luckperms/common/caching/type/MetaAccumulator.java
+15 -15
View File
@@ -30,10 +30,13 @@ import com.google.common.collect.ListMultimap;
import me.lucko.luckperms.api.ChatMetaType;
import me.lucko.luckperms.api.LocalizedNode;
import me.lucko.luckperms.api.nodetype.types.MetaType;
import me.lucko.luckperms.api.nodetype.types.PrefixType;
import me.lucko.luckperms.api.nodetype.types.SuffixType;
import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.metastacking.MetaStack;
import me.lucko.luckperms.common.metastacking.SimpleMetaStack;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.model.NodeTypes;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import java.util.Comparator;
@@ -73,22 +76,19 @@ public class MetaAccumulator {
}
public void accumulateNode(LocalizedNode n) {
if (n.isMeta()) {
Map.Entry<String, String> entry = n.getMeta();
this.meta.put(entry.getKey(), entry.getValue());
}
n.getTypeData(MetaType.KEY).ifPresent(metaType ->
this.meta.put(metaType.getKey(), metaType.getValue())
);
if (n.isPrefix()) {
Map.Entry<Integer, String> value = n.getPrefix();
this.prefixes.putIfAbsent(value.getKey(), value.getValue());
n.getTypeData(PrefixType.KEY).ifPresent(prefix -> {
this.prefixes.putIfAbsent(prefix.getPriority(), prefix.getPrefix());
this.prefixStack.accumulateToAll(n);
}
});
if (n.isSuffix()) {
Map.Entry<Integer, String> value = n.getSuffix();
this.suffixes.putIfAbsent(value.getKey(), value.getValue());
n.getTypeData(SuffixType.KEY).ifPresent(suffix -> {
this.suffixes.putIfAbsent(suffix.getPriority(), suffix.getSuffix());
this.suffixStack.accumulateToAll(n);
}
});
}
public void accumulateMeta(String key, String value) {
@@ -103,8 +103,8 @@ public class MetaAccumulator {
// (it's not going to accumulate more nodes)
// Therefore, it should be ok to set the weight meta key, if not already present.
public ListMultimap<String, String> getMeta() {
if (!this.meta.containsKey(NodeFactory.WEIGHT_KEY) && this.weight != 0) {
this.meta.put(NodeFactory.WEIGHT_KEY, String.valueOf(this.weight));
if (!this.meta.containsKey(NodeTypes.WEIGHT_KEY) && this.weight != 0) {
this.meta.put(NodeTypes.WEIGHT_KEY, String.valueOf(this.weight));
}
return this.meta;
common/src/main/java/me/lucko/luckperms/common/calculators/PermissionCalculatorMetadata.java
+1 -1
View File
@@ -26,7 +26,7 @@
package me.lucko.luckperms.common.calculators;
import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.model.HolderType;
/**
* Metadata about a given {@link PermissionCalculator}.
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaAddChatMeta.java
+1 -1
View File
@@ -42,7 +42,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaAddTempChatMeta.java
+1 -1
View File
@@ -45,7 +45,7 @@ import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.TemporaryModifier;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaClear.java
+7 -7
View File
@@ -39,8 +39,8 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.MetaType;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.model.NodeTypes;
import me.lucko.luckperms.common.node.utils.MetaType;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
@@ -68,13 +68,13 @@ public class MetaClear extends SharedSubCommand {
if (typeId.equals("chat") || typeId.equals("chatmeta")) {
type = MetaType.CHAT;
}
if (typeId.equals(NodeFactory.META_KEY)) {
if (typeId.equals(NodeTypes.META_KEY)) {
type = MetaType.META;
}
if (typeId.equals(NodeFactory.PREFIX_KEY) || typeId.equals("prefixes")) {
if (typeId.equals(NodeTypes.PREFIX_KEY) || typeId.equals("prefixes")) {
type = MetaType.PREFIX;
}
if (typeId.equals(NodeFactory.SUFFIX_KEY) || typeId.equals("suffixes")) {
if (typeId.equals(NodeTypes.SUFFIX_KEY) || typeId.equals("suffixes")) {
type = MetaType.SUFFIX;
}
@@ -87,7 +87,7 @@ public class MetaClear extends SharedSubCommand {
type = MetaType.ANY;
}
int before = holder.getEnduringNodes().size();
int before = holder.enduringData().immutable().size();
MutableContextSet context = ArgumentParser.parseContext(0, args, plugin);
@@ -102,7 +102,7 @@ public class MetaClear extends SharedSubCommand {
holder.clearMeta(type, context);
}
int changed = before - holder.getEnduringNodes().size();
int changed = before - holder.enduringData().immutable().size();
if (changed == 1) {
Message.META_CLEAR_SUCCESS_SINGULAR.send(sender, holder.getFriendlyName(), type.name().toLowerCase(), MessageUtils.contextSetToString(context), changed);
} else {
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaInfo.java
+2 -2
View File
@@ -40,8 +40,8 @@ import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.NodeWithContextComparator;
import me.lucko.luckperms.common.node.comparator.NodeWithContextComparator;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaRemoveChatMeta.java
+1 -1
View File
@@ -42,7 +42,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaRemoveTempChatMeta.java
+1 -1
View File
@@ -42,7 +42,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaSet.java
+4 -2
View File
@@ -26,6 +26,7 @@
package me.lucko.luckperms.common.commands.generic.meta;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.context.MutableContextSet;
import me.lucko.luckperms.common.actionlog.ExtendedLogEntry;
import me.lucko.luckperms.common.command.CommandResult;
@@ -39,8 +40,9 @@ import me.lucko.luckperms.common.command.utils.StorageAssistant;
import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
@@ -79,7 +81,7 @@ public class MetaSet extends SharedSubCommand {
Node n = NodeFactory.buildMetaNode(key, value).withExtraContext(context).build();
if (holder.hasPermission(n).asBoolean()) {
if (holder.hasPermission(NodeMapType.ENDURING, n, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE).asBoolean()) {
Message.ALREADY_HAS_META.send(sender, holder.getFriendlyName(), key, value, MessageUtils.contextSetToString(context));
return CommandResult.STATE_ERROR;
}
common/src/main/java/me/lucko/luckperms/common/commands/generic/meta/MetaSetTemp.java
+4 -2
View File
@@ -26,6 +26,7 @@
package me.lucko.luckperms.common.commands.generic.meta;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.context.MutableContextSet;
import me.lucko.luckperms.common.actionlog.ExtendedLogEntry;
import me.lucko.luckperms.common.command.CommandManager;
@@ -41,9 +42,10 @@ import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.TemporaryModifier;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
@@ -85,7 +87,7 @@ public class MetaSetTemp extends SharedSubCommand {
Node n = NodeFactory.buildMetaNode(key, value).withExtraContext(context).setExpiry(duration).build();
if (holder.hasPermission(n).asBoolean()) {
if (holder.hasPermission(NodeMapType.ENDURING, n, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE).asBoolean()) {
Message.ALREADY_HAS_TEMP_META.send(sender, holder.getFriendlyName(), key, value, MessageUtils.contextSetToString(context));
return CommandResult.STATE_ERROR;
}
common/src/main/java/me/lucko/luckperms/common/commands/generic/other/HolderClear.java
+2 -2
View File
@@ -57,7 +57,7 @@ public class HolderClear<T extends PermissionHolder> extends SubCommand<T> {
return CommandResult.NO_PERMISSION;
}
int before = holder.getEnduringNodes().size();
int before = holder.enduringData().immutable().size();
MutableContextSet context = ArgumentParser.parseContext(0, args, plugin);
@@ -72,7 +72,7 @@ public class HolderClear<T extends PermissionHolder> extends SubCommand<T> {
holder.clearNodes(context);
}
int changed = before - holder.getEnduringNodes().size();
int changed = before - holder.enduringData().immutable().size();
if (changed == 1) {
Message.CLEAR_SUCCESS_SINGULAR.send(sender, holder.getFriendlyName(), MessageUtils.contextSetToString(context), changed);
} else {
common/src/main/java/me/lucko/luckperms/common/commands/generic/other/HolderShowTracks.java
+2 -2
View File
@@ -73,9 +73,9 @@ public class HolderShowTracks<T extends PermissionHolder> extends SubCommand<T>
if (holder.getType().isUser()) {
// if the holder is a user, we want to query parent groups for tracks
Set<Node> nodes = holder.getEnduringNodes().values().stream()
Set<Node> nodes = holder.enduringData().immutable().values().stream()
.filter(Node::isGroupNode)
.filter(Node::getValuePrimitive)
.filter(Node::getValue)
.filter(Node::isPermanent)
.collect(Collectors.toSet());
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentAdd.java
+1 -1
View File
@@ -41,7 +41,7 @@ import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentAddTemp.java
+1 -1
View File
@@ -44,7 +44,7 @@ import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.TemporaryModifier;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentClear.java
+2 -2
View File
@@ -57,7 +57,7 @@ public class ParentClear extends SharedSubCommand {
return CommandResult.NO_PERMISSION;
}
int before = holder.getEnduringNodes().size();
int before = holder.enduringData().immutable().size();
MutableContextSet context = ArgumentParser.parseContext(0, args, plugin);
@@ -72,7 +72,7 @@ public class ParentClear extends SharedSubCommand {
holder.clearParents(context, true);
}
int changed = before - holder.getEnduringNodes().size();
int changed = before - holder.enduringData().immutable().size();
if (changed == 1) {
Message.PARENT_CLEAR_SUCCESS_SINGULAR.send(sender, holder.getFriendlyName(), MessageUtils.contextSetToString(context), changed);
} else {
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentClearTrack.java
+2 -2
View File
@@ -78,7 +78,7 @@ public class ParentClearTrack extends SharedSubCommand {
return CommandResult.STATE_ERROR;
}
int before = holder.getEnduringNodes().size();
int before = holder.enduringData().immutable().size();
MutableContextSet context = ArgumentParser.parseContext(1, args, plugin);
@@ -102,7 +102,7 @@ public class ParentClearTrack extends SharedSubCommand {
plugin.getUserManager().giveDefaultIfNeeded(((User) holder), false);
}
int changed = before - holder.getEnduringNodes().size();
int changed = before - holder.enduringData().immutable().size();
if (changed == 1) {
Message.PARENT_CLEAR_TRACK_SUCCESS_SINGULAR.send(sender, holder.getFriendlyName(), track.getName(), MessageUtils.contextSetToString(context), changed);
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentInfo.java
+4 -4
View File
@@ -40,8 +40,8 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.NodeWithContextComparator;
import me.lucko.luckperms.common.node.comparator.NodeWithContextComparator;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.CollationKeyCache;
@@ -77,10 +77,10 @@ public class ParentInfo extends SharedSubCommand {
SortMode sortMode = SortMode.determine(args);
// get the holders nodes
List<LocalizedNode> nodes = new ArrayList<>(holder.getEnduringData().asSortedSet());
List<LocalizedNode> nodes = new ArrayList<>(holder.enduringData().asSortedSet());
// remove irrelevant types (these are displayed in the other info commands)
nodes.removeIf(node -> !node.isGroupNode() || !node.getValuePrimitive());
nodes.removeIf(node -> !node.isGroupNode() || !node.getValue());
// handle empty
if (nodes.isEmpty()) {
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentRemove.java
+1 -1
View File
@@ -42,7 +42,7 @@ import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentRemoveTemp.java
+1 -1
View File
@@ -40,7 +40,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentSet.java
+1 -1
View File
@@ -41,7 +41,7 @@ import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/ParentSetTrack.java
+1 -1
View File
@@ -41,7 +41,7 @@ import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.Track;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.storage.DataConstraints;
common/src/main/java/me/lucko/luckperms/common/commands/generic/parent/UserSwitchPrimaryGroup.java
+1 -1
View File
@@ -38,7 +38,7 @@ import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionCheck.java
+3 -2
View File
@@ -38,8 +38,9 @@ import me.lucko.luckperms.common.command.utils.MessageUtils;
import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
@@ -63,7 +64,7 @@ public class PermissionCheck extends SharedSubCommand {
String node = ArgumentParser.parseString(0, args);
MutableContextSet context = ArgumentParser.parseContext(1, args, plugin);
Tristate result = holder.hasPermission(NodeFactory.builder(node).withExtraContext(context).build(), StandardNodeEquality.IGNORE_VALUE_OR_IF_TEMPORARY);
Tristate result = holder.hasPermission(NodeMapType.ENDURING, NodeFactory.builder(node).withExtraContext(context).build(), StandardNodeEquality.IGNORE_VALUE_OR_IF_TEMPORARY);
String s = MessageUtils.formatTristate(result);
Message.CHECK_PERMISSION.send(sender, holder.getFriendlyName(), node, s, MessageUtils.contextSetToString(context));
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionCheckInherits.java
+2 -2
View File
@@ -38,8 +38,8 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.InheritanceInfo;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.node.utils.InheritanceInfo;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionClear.java
+2 -2
View File
@@ -57,7 +57,7 @@ public class PermissionClear extends SharedSubCommand {
return CommandResult.NO_PERMISSION;
}
int before = holder.getEnduringNodes().size();
int before = holder.enduringData().immutable().size();
MutableContextSet context = ArgumentParser.parseContext(0, args, plugin);
@@ -72,7 +72,7 @@ public class PermissionClear extends SharedSubCommand {
holder.clearPermissions(context);
}
int changed = before - holder.getEnduringNodes().size();
int changed = before - holder.enduringData().immutable().size();
if (changed == 1) {
Message.PERMISSION_CLEAR_SUCCESS_SINGULAR.send(sender, holder.getFriendlyName(), MessageUtils.contextSetToString(context), changed);
} else {
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionInfo.java
+8 -10
View File
@@ -40,8 +40,8 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.NodeWithContextComparator;
import me.lucko.luckperms.common.node.comparator.NodeWithContextComparator;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.CollationKeyCache;
@@ -77,14 +77,12 @@ public class PermissionInfo extends SharedSubCommand {
SortMode sortMode = SortMode.determine(args);
// get the holders nodes
List<LocalizedNode> nodes = new ArrayList<>(holder.getEnduringData().asSortedSet());
List<LocalizedNode> nodes = new ArrayList<>(holder.enduringData().asSortedSet());
// remove irrelevant types (these are displayed in the other info commands)
nodes.removeIf(node ->
// remove if the node is a group node, and if the value isn't false and if the group actually exists
(node.isGroupNode() && node.getValuePrimitive() && plugin.getGroupManager().isLoaded(node.getGroupName())) ||
// remove if the node is a meta node
node.isPrefix() || node.isSuffix() || node.isMeta()
nodes.removeIf(node -> (node.isGroupNode() && node.getValue() && plugin.getGroupManager().isLoaded(node.getGroupName())) ||
// remove if the node is a meta node
node.isPrefix() || node.isSuffix() || node.isMeta()
);
// handle empty
@@ -118,7 +116,7 @@ public class PermissionInfo extends SharedSubCommand {
// send content
for (LocalizedNode node : content) {
String s = "&3> " + (node.getValuePrimitive() ? "&a" : "&c") + node.getPermission() + (sender.isConsole() ? " &7(" + node.getValuePrimitive() + "&7)" : "") + MessageUtils.getAppendableNodeContextString(node);
String s = "&3> " + (node.getValue() ? "&a" : "&c") + node.getPermission() + (sender.isConsole() ? " &7(" + node.getValue() + "&7)" : "") + MessageUtils.getAppendableNodeContextString(node);
if (node.isTemporary()) {
s += "\n&2- expires in " + DurationFormatter.LONG.formatDateDiff(node.getExpiryUnixTime());
}
@@ -142,7 +140,7 @@ public class PermissionInfo extends SharedSubCommand {
private static Consumer<BuildableComponent.Builder<?, ?>> makeFancy(PermissionHolder holder, String label, Node node) {
HoverEvent hoverEvent = new HoverEvent(HoverEvent.Action.SHOW_TEXT, TextUtils.fromLegacy(TextUtils.joinNewline(
"¥3> " + (node.getValuePrimitive() ? "¥a" : "¥c") + node.getPermission(),
"¥3> " + (node.getValue() ? "¥a" : "¥c") + node.getPermission(),
" ",
"¥7Click to remove this node from " + holder.getFriendlyName()
), '¥'));
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionSet.java
+1 -1
View File
@@ -40,7 +40,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionSetTemp.java
+1 -1
View File
@@ -43,7 +43,7 @@ import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.TemporaryModifier;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionUnset.java
+1 -1
View File
@@ -40,7 +40,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/generic/permission/PermissionUnsetTemp.java
+1 -1
View File
@@ -40,7 +40,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/group/DeleteGroup.java
+1 -1
View File
@@ -36,7 +36,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/group/GroupClone.java
+2 -1
View File
@@ -36,6 +36,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.storage.DataConstraints;
@@ -72,7 +73,7 @@ public class GroupClone extends SubCommand<Group> {
return CommandResult.NO_PERMISSION;
}
newGroup.replaceEnduringNodes(group.getEnduringNodes());
newGroup.replaceNodes(NodeMapType.ENDURING, group.enduringData().immutable());
Message.CLONE_SUCCESS.send(sender, group.getName(), newGroup.getName());
common/src/main/java/me/lucko/luckperms/common/commands/group/GroupInfo.java
+2 -2
View File
@@ -62,12 +62,12 @@ public class GroupInfo extends SubCommand<Group> {
group.getWeight().isPresent() ? group.getWeight().getAsInt() : "None"
);
Set<Node> parents = group.getEnduringData().asSet().stream()
Set<Node> parents = group.enduringData().asSet().stream()
.filter(Node::isGroupNode)
.filter(Node::isPermanent)
.collect(Collectors.toSet());
Set<Node> tempParents = group.getEnduringData().asSet().stream()
Set<Node> tempParents = group.enduringData().asSet().stream()
.filter(Node::isGroupNode)
.filter(Node::isTemporary)
.collect(Collectors.toSet());
common/src/main/java/me/lucko/luckperms/common/commands/group/GroupListMembers.java
+3 -3
View File
@@ -42,10 +42,10 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.node.HeldPermissionComparator;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.model.HolderType;
import me.lucko.luckperms.common.node.comparator.HeldPermissionComparator;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
import me.lucko.luckperms.common.utils.Iterators;
common/src/main/java/me/lucko/luckperms/common/commands/group/GroupRename.java
+2 -1
View File
@@ -36,6 +36,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.storage.DataConstraints;
@@ -78,7 +79,7 @@ public class GroupRename extends SubCommand<Group> {
return CommandResult.FAILURE;
}
newGroup.replaceEnduringNodes(group.getEnduringNodes());
newGroup.replaceNodes(NodeMapType.ENDURING, group.enduringData().immutable());
Message.RENAME_SUCCESS.send(sender, group.getName(), newGroup.getName());
common/src/main/java/me/lucko/luckperms/common/commands/group/GroupSetDisplayName.java
+1 -1
View File
@@ -36,7 +36,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
common/src/main/java/me/lucko/luckperms/common/commands/group/GroupSetWeight.java
+3 -2
View File
@@ -25,6 +25,7 @@
package me.lucko.luckperms.common.commands.group;
import me.lucko.luckperms.api.nodetype.types.WeightType;
import me.lucko.luckperms.common.actionlog.ExtendedLogEntry;
import me.lucko.luckperms.common.command.CommandResult;
import me.lucko.luckperms.common.command.abstraction.CommandException;
@@ -37,7 +38,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
@@ -58,7 +59,7 @@ public class GroupSetWeight extends SubCommand<Group> {
int weight = ArgumentParser.parsePriority(0, args);
group.removeIf(n -> NodeFactory.parseWeightNode(n.getPermission()) != null);
group.removeIf(n -> n.getTypeData(WeightType.KEY).isPresent());
group.setPermission(NodeFactory.buildWeightNode(weight).build());
Message.GROUP_SET_WEIGHT.send(sender, weight, group.getFriendlyName());
common/src/main/java/me/lucko/luckperms/common/commands/log/LogNotify.java
+2 -2
View File
@@ -34,7 +34,7 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.Predicates;
@@ -60,7 +60,7 @@ public class LogNotify extends SubCommand<Log> {
// if they don't have the perm, they're not ignoring
// if set to false, ignore it, return false
return ret.map(Node::getValuePrimitive).orElse(false);
return ret.map(Node::getValue).orElse(false);
}
private static void setIgnoring(LuckPermsPlugin plugin, UUID uuid, boolean state) {
common/src/main/java/me/lucko/luckperms/common/commands/migration/MigrationUtils.java
+3 -2
View File
@@ -26,8 +26,9 @@
package me.lucko.luckperms.common.commands.migration;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.nodetype.types.WeightType;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
public final class MigrationUtils {
@@ -52,7 +53,7 @@ public final class MigrationUtils {
}
public static void setGroupWeight(Group group, int weight) {
group.removeIf(n -> NodeFactory.parseWeightNode(n.getPermission()) != null);
group.removeIf(n -> n.getTypeData(WeightType.KEY).isPresent());
group.setPermission(NodeFactory.buildWeightNode(weight).build());
}
common/src/main/java/me/lucko/luckperms/common/commands/misc/ApplyEditsCommand.java
+9 -8
View File
@@ -41,8 +41,9 @@ import me.lucko.luckperms.common.command.utils.StorageAssistant;
import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.node.NodeModel;
import me.lucko.luckperms.common.node.model.NodeDataContainer;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
@@ -105,10 +106,10 @@ public class ApplyEditsCommand extends SingleCommand {
return false;
}
Set<NodeModel> nodes = WebEditor.deserializePermissions(data.getAsJsonArray("nodes"));
Set<NodeDataContainer> nodes = WebEditor.deserializePermissions(data.getAsJsonArray("nodes"));
Set<Node> before = new HashSet<>(holder.getEnduringNodes().values());
Set<Node> after = nodes.stream().map(NodeModel::toNode).collect(Collectors.toSet());
Set<Node> before = new HashSet<>(holder.enduringData().immutable().values());
Set<Node> after = nodes.stream().map(NodeDataContainer::toNode).collect(Collectors.toSet());
Map.Entry<Set<Node>, Set<Node>> diff = diff(before, after);
Set<Node> diffAdded = diff.getKey();
@@ -121,16 +122,16 @@ public class ApplyEditsCommand extends SingleCommand {
return false;
}
holder.setEnduringNodes(after);
holder.setNodes(NodeMapType.ENDURING, after);
for (Node n : diffAdded) {
ExtendedLogEntry.build().actor(sender).acted(holder)
.action("webeditor", "add", n.getPermission(), n.getValuePrimitive(), n.getFullContexts())
.action("webeditor", "add", n.getPermission(), n.getValue(), n.getFullContexts())
.build().submit(plugin, sender);
}
for (Node n : diffRemoved) {
ExtendedLogEntry.build().actor(sender).acted(holder)
.action("webeditor", "remove", n.getPermission(), n.getValuePrimitive(), n.getFullContexts())
.action("webeditor", "remove", n.getPermission(), n.getValue(), n.getFullContexts())
.build().submit(plugin, sender);
}
@@ -150,7 +151,7 @@ public class ApplyEditsCommand extends SingleCommand {
}
private static String formatNode(Node n) {
return n.getPermission() + " &7(" + (n.getValuePrimitive() ? "&a" : "&c") + n.getValuePrimitive() + "&7)" + MessageUtils.getAppendableNodeContextString(n) +
return n.getPermission() + " &7(" + (n.getValue() ? "&a" : "&c") + n.getValue() + "&7)" + MessageUtils.getAppendableNodeContextString(n) +
(n.isTemporary() ? " &7(" + DurationFormatter.CONCISE.formatDateDiff(n.getExpiryUnixTime()) + ")" : "");
}
common/src/main/java/me/lucko/luckperms/common/commands/misc/SearchCommand.java
+4 -5
View File
@@ -41,11 +41,10 @@ import me.lucko.luckperms.common.command.utils.TabCompletions;
import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.node.HeldPermissionComparator;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.NodeHeldPermission;
import me.lucko.luckperms.common.model.HolderType;
import me.lucko.luckperms.common.node.comparator.HeldPermissionComparator;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.utils.DurationFormatter;
import me.lucko.luckperms.common.utils.Iterators;
@@ -147,7 +146,7 @@ public class SearchCommand extends SingleCommand {
private static Consumer<BuildableComponent.Builder<?, ?>> makeFancy(String holderName, HolderType holderType, String label, HeldPermission<?> perm) {
HoverEvent hoverEvent = new HoverEvent(HoverEvent.Action.SHOW_TEXT, TextUtils.fromLegacy(TextUtils.joinNewline(
"&3> " + (perm.asNode().getValuePrimitive() ? "&a" : "&c") + perm.asNode().getPermission(),
"&3> " + (perm.asNode().getValue() ? "&a" : "&c") + perm.asNode().getPermission(),
" ",
"&7Click to remove this node from " + holderName
), CommandManager.AMPERSAND_CHAR));
common/src/main/java/me/lucko/luckperms/common/commands/user/UserClone.java
+2 -1
View File
@@ -35,6 +35,7 @@ import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.NodeMapType;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.sender.Sender;
@@ -99,7 +100,7 @@ public class UserClone extends SubCommand<User> {
return CommandResult.NO_PERMISSION;
}
otherUser.replaceEnduringNodes(user.getEnduringNodes());
otherUser.replaceNodes(NodeMapType.ENDURING, user.enduringData().immutable());
Message.CLONE_SUCCESS.send(sender, user.getFriendlyName(), otherUser.getFriendlyName());
common/src/main/java/me/lucko/luckperms/common/commands/user/UserInfo.java
+2 -2
View File
@@ -72,12 +72,12 @@ public class UserInfo extends SubCommand<User> {
user.getPrimaryGroup().getValue()
);
Set<Node> parents = user.getEnduringData().asSet().stream()
Set<Node> parents = user.enduringData().asSet().stream()
.filter(Node::isGroupNode)
.filter(Node::isPermanent)
.collect(Collectors.toSet());
Set<Node> tempParents = user.getEnduringData().asSet().stream()
Set<Node> tempParents = user.enduringData().asSet().stream()
.filter(Node::isGroupNode)
.filter(Node::isTemporary)
.collect(Collectors.toSet());
common/src/main/java/me/lucko/luckperms/common/commands/user/UserMainCommand.java
+1 -1
View File
@@ -42,8 +42,8 @@ import me.lucko.luckperms.common.locale.LocaleManager;
import me.lucko.luckperms.common.locale.command.CommandSpec;
import me.lucko.luckperms.common.locale.message.Message;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.model.UserIdentifier;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.UserIdentifier;
import me.lucko.luckperms.common.sender.Sender;
import me.lucko.luckperms.common.storage.DataConstraints;
import me.lucko.luckperms.common.utils.Uuids;
common/src/main/java/me/lucko/luckperms/common/event/EventFactory.java
+1 -1
View File
@@ -123,7 +123,7 @@ public final class EventFactory {
}
public void handleGroupDelete(Group group, DeletionCause cause) {
EventGroupDelete event = new EventGroupDelete(group.getName(), ImmutableSet.copyOf(group.getEnduringNodes().values()), cause);
EventGroupDelete event = new EventGroupDelete(group.getName(), ImmutableSet.copyOf(group.enduringData().immutable().values()), cause);
fireEventAsync(event);
}
common/src/main/java/me/lucko/luckperms/common/inheritance/InheritanceComparator.java
+1 -1
View File
@@ -28,7 +28,7 @@ package me.lucko.luckperms.common.inheritance;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.model.PermissionHolder;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import java.util.Comparator;
common/src/main/java/me/lucko/luckperms/common/managers/AbstractManager.java
+1 -1
View File
@@ -30,7 +30,7 @@ import com.github.benmanes.caffeine.cache.Caffeine;
import com.github.benmanes.caffeine.cache.LoadingCache;
import com.google.common.collect.ImmutableMap;
import me.lucko.luckperms.common.references.Identifiable;
import me.lucko.luckperms.common.model.Identifiable;
import java.util.Map;
common/src/main/java/me/lucko/luckperms/common/managers/Manager.java
+1 -1
View File
@@ -25,7 +25,7 @@
package me.lucko.luckperms.common.managers;
import me.lucko.luckperms.common.references.Identifiable;
import me.lucko.luckperms.common.model.Identifiable;
import java.util.Map;
import java.util.function.Function;
common/src/main/java/me/lucko/luckperms/common/managers/user/AbstractUserManager.java
+7 -7
View File
@@ -30,9 +30,9 @@ import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.managers.AbstractManager;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.model.UserIdentifier;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.UserIdentifier;
import java.util.Optional;
import java.util.UUID;
@@ -83,7 +83,7 @@ public abstract class AbstractUserManager<T extends User> extends AbstractManage
String pg = user.getPrimaryGroup().getValue();
boolean has = false;
for (Node node : user.getEnduringNodes().get(ImmutableContextSet.empty())) {
for (Node node : user.enduringData().immutable().get(ImmutableContextSet.empty())) {
if (node.isGroupNode() && node.getGroupName().equalsIgnoreCase(pg)) {
has = true;
break;
@@ -92,7 +92,7 @@ public abstract class AbstractUserManager<T extends User> extends AbstractManage
// need to find a new primary group for the user.
if (!has) {
String group = user.getEnduringNodes().get(ImmutableContextSet.empty()).stream()
String group = user.enduringData().immutable().get(ImmutableContextSet.empty()).stream()
.filter(Node::isGroupNode)
.findFirst()
.map(Node::getGroupName)
@@ -109,7 +109,7 @@ public abstract class AbstractUserManager<T extends User> extends AbstractManage
// check that all users are member of at least one group
boolean hasGroup = false;
if (user.getPrimaryGroup().getStoredValue().isPresent()) {
for (Node node : user.getEnduringNodes().values()) {
for (Node node : user.enduringData().immutable().values()) {
if (node.hasSpecificContext()) {
continue;
}
@@ -160,11 +160,11 @@ public abstract class AbstractUserManager<T extends User> extends AbstractManage
*/
@Override
public boolean shouldSave(User user) {
if (user.getEnduringNodes().size() != 1) {
if (user.enduringData().immutable().size() != 1) {
return true;
}
for (Node node : user.getEnduringNodes().values()) {
for (Node node : user.enduringData().immutable().values()) {
// There's only one.
if (!node.isGroupNode()) {
return true;
common/src/main/java/me/lucko/luckperms/common/managers/user/StandardUserManager.java
+1 -1
View File
@@ -26,8 +26,8 @@
package me.lucko.luckperms.common.managers.user;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.model.UserIdentifier;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.UserIdentifier;
import java.util.concurrent.TimeUnit;
common/src/main/java/me/lucko/luckperms/common/managers/user/UserHousekeeper.java
+1 -1
View File
@@ -25,8 +25,8 @@
package me.lucko.luckperms.common.managers.user;
import me.lucko.luckperms.common.model.UserIdentifier;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.UserIdentifier;
import me.lucko.luckperms.common.utils.ExpiringSet;
import java.util.UUID;
common/src/main/java/me/lucko/luckperms/common/managers/user/UserManager.java
+1 -1
View File
@@ -27,7 +27,7 @@ package me.lucko.luckperms.common.managers.user;
import me.lucko.luckperms.common.managers.Manager;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.references.UserIdentifier;
import me.lucko.luckperms.common.model.UserIdentifier;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
common/src/main/java/me/lucko/luckperms/common/model/Group.java
+20 -7
View File
@@ -29,30 +29,37 @@ import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.api.delegates.model.ApiGroup;
import me.lucko.luckperms.common.buffers.BufferedRequest;
import me.lucko.luckperms.common.buffers.Cache;
import me.lucko.luckperms.common.caching.GroupCachedData;
import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.GroupReference;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.references.Identifiable;
import java.util.Optional;
import java.util.OptionalInt;
import java.util.concurrent.CompletableFuture;
public class Group extends PermissionHolder implements Identifiable<String> {
private final ApiGroup apiDelegate = new ApiGroup(this);
/**
* The name of the group
*/
private final String name;
private final ApiGroup apiDelegate = new ApiGroup(this);
/**
* Caches the holders weight
* @see #getWeight()
*/
private final Cache<OptionalInt> weightCache = new WeightCache(this);
/**
* The groups data cache instance
*/
private final GroupCachedData cachedData;
/**
* The group's cached data refresh buffer
*/
private final GroupRefreshBuffer refreshBuffer;
public Group(String name, LuckPermsPlugin plugin) {
@@ -67,6 +74,12 @@ public class Group extends PermissionHolder implements Identifiable<String> {
getStateListeners().add(this.refreshBuffer::request);
}
@Override
protected void invalidateCache() {
this.weightCache.invalidate();
super.invalidateCache();
}
public String getName() {
return this.name;
}
@@ -92,7 +105,7 @@ public class Group extends PermissionHolder implements Identifiable<String> {
public Optional<String> getDisplayName() {
String name = null;
for (Node n : getEnduringNodes().get(ImmutableContextSet.empty())) {
for (Node n : enduringData().immutable().get(ImmutableContextSet.empty())) {
if (!n.getPermission().startsWith("displayname.")) {
continue;
}
@@ -116,8 +129,8 @@ public class Group extends PermissionHolder implements Identifiable<String> {
}
@Override
public GroupReference toReference() {
return GroupReference.of(getId());
public OptionalInt getWeight() {
return this.weightCache.get();
}
@Override
common/src/main/java/me/lucko/luckperms/common/references/HolderType.java → common/src/main/java/me/lucko/luckperms/common/model/HolderType.java
+1 -3
View File
@@ -23,9 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.references;
import me.lucko.luckperms.common.model.PermissionHolder;
package me.lucko.luckperms.common.model;
public enum HolderType {
common/src/main/java/me/lucko/luckperms/common/references/Identifiable.java → common/src/main/java/me/lucko/luckperms/common/model/Identifiable.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.references;
package me.lucko.luckperms.common.model;
/**
* Interface to represent an identifiable object
common/src/main/java/me/lucko/luckperms/common/model/NodeMap.java
+7 -7
View File
@@ -37,9 +37,9 @@ import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.buffers.Cache;
import me.lucko.luckperms.common.contexts.ContextSetComparator;
import me.lucko.luckperms.common.node.ImmutableLocalizedNode;
import me.lucko.luckperms.common.node.NodeComparator;
import me.lucko.luckperms.common.node.NodeWithContextComparator;
import me.lucko.luckperms.common.node.comparator.NodeComparator;
import me.lucko.luckperms.common.node.comparator.NodeWithContextComparator;
import me.lucko.luckperms.common.node.model.ImmutableLocalizedNode;
import java.util.ArrayList;
import java.util.Collection;
@@ -207,7 +207,7 @@ public final class NodeMap {
try {
ImmutableContextSet context = node.getFullContexts().makeImmutable();
this.map.put(context, node);
if (node.isGroupNode() && node.getValuePrimitive()) {
if (node.isGroupNode() && node.getValue()) {
this.inheritanceMap.put(context, node);
}
} finally {
@@ -233,7 +233,7 @@ public final class NodeMap {
try {
ImmutableContextSet context = node.getFullContexts().makeImmutable();
this.map.remove(context, node);
if (node.isGroupNode() && node.getValuePrimitive()) {
if (node.isGroupNode() && node.getValue()) {
this.inheritanceMap.remove(context, node);
}
} finally {
@@ -293,7 +293,7 @@ public final class NodeMap {
this.map.putAll(multimap);
for (Map.Entry<ImmutableContextSet, Node> entry : this.map.entries()) {
if (entry.getValue().isGroupNode() && entry.getValue().getValuePrimitive()) {
if (entry.getValue().isGroupNode() && entry.getValue().getValue()) {
this.inheritanceMap.put(entry.getKey(), entry.getValue());
}
}
@@ -342,7 +342,7 @@ public final class NodeMap {
if (removed != null) {
removed.add(entry);
}
if (entry.isGroupNode() && entry.getValuePrimitive()) {
if (entry.isGroupNode() && entry.getValue()) {
this.inheritanceMap.remove(entry.getFullContexts().makeImmutable(), entry);
}
work = true;
common/src/main/java/me/lucko/luckperms/common/model/PermissionHolder.java
+54 -175
View File
@@ -27,7 +27,6 @@ package me.lucko.luckperms.common.model;
import com.google.common.collect.ImmutableCollection;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSetMultimap;
import com.google.common.collect.Maps;
import com.google.common.collect.Multimap;
@@ -42,23 +41,19 @@ import me.lucko.luckperms.api.Tristate;
import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.buffers.BufferedRequest;
import me.lucko.luckperms.common.buffers.Cache;
import me.lucko.luckperms.common.caching.HolderCachedData;
import me.lucko.luckperms.common.caching.handlers.StateListener;
import me.lucko.luckperms.common.caching.type.MetaAccumulator;
import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.inheritance.InheritanceComparator;
import me.lucko.luckperms.common.inheritance.InheritanceGraph;
import me.lucko.luckperms.common.node.ImmutableLocalizedNode;
import me.lucko.luckperms.common.node.InheritanceInfo;
import me.lucko.luckperms.common.node.MetaType;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.NodeTools;
import me.lucko.luckperms.common.node.NodeWithContextComparator;
import me.lucko.luckperms.common.node.comparator.NodeWithContextComparator;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.node.model.ImmutableLocalizedNode;
import me.lucko.luckperms.common.node.utils.InheritanceInfo;
import me.lucko.luckperms.common.node.utils.MetaType;
import me.lucko.luckperms.common.node.utils.NodeTools;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.GroupReference;
import me.lucko.luckperms.common.references.HolderReference;
import me.lucko.luckperms.common.references.HolderType;
import java.util.ArrayList;
import java.util.Comparator;
@@ -76,7 +71,6 @@ import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
import java.util.function.Predicate;
import java.util.stream.Collectors;
/**
* Represents an object that can hold permissions, (a user or group)
@@ -124,7 +118,7 @@ public abstract class PermissionHolder {
*
* <p>These (unlike transient nodes) are saved to the storage backing.</p>
*
* @see #getEnduringData()
* @see #enduringData()
*/
private final NodeMap enduringNodes = new NodeMap(this);
@@ -136,16 +130,10 @@ public abstract class PermissionHolder {
* when the server stops, and for a user, it's when they log out, or get
* unloaded.)</p>
*
* @see #getTransientData()
* @see #transientData()
*/
private final NodeMap transientNodes = new NodeMap(this);
/**
* Caches the holders weight
* @see #getWeight()
*/
private final Cache<OptionalInt> weightCache = WeightCache.getFor(this);
/**
* Lock used by Storage implementations to prevent concurrent read/writes
* @see #getIoLock()
@@ -183,10 +171,9 @@ public abstract class PermissionHolder {
return this.stateListeners;
}
private void invalidateCache() {
protected void invalidateCache() {
this.enduringNodes.invalidate();
this.transientNodes.invalidate();
this.weightCache.invalidate();
// Invalidate listeners
for (StateListener listener : this.stateListeners) {
@@ -196,17 +183,6 @@ public abstract class PermissionHolder {
e.printStackTrace();
}
}
// Declare new state to the state manager
declareState();
}
private void declareState() {
/* only declare state of groups. the state manager isn't really being used now the caches in this class
are gone, but it's useful for command output. */
if (this.getType().isGroup()) {
this.plugin.getCachedStateManager().putAll(toReference(), getGroupReferences());
}
}
/**
@@ -223,14 +199,12 @@ public abstract class PermissionHolder {
*/
public abstract HolderCachedData<?> getCachedData();
public abstract BufferedRequest<Void> getRefreshBuffer();
/**
* Forms a HolderReference for this PermissionHolder.
* Gets the holders refresh buffer
*
* @return this holders reference
* @return the holders refresh buffer
*/
public abstract HolderReference<?, ?> toReference();
public abstract BufferedRequest<Void> getRefreshBuffer();
/**
* Returns the type of this PermissionHolder.
@@ -254,43 +228,21 @@ public abstract class PermissionHolder {
}
}
public NodeMap getEnduringData() {
public NodeMap enduringData() {
return this.enduringNodes;
}
public NodeMap getTransientData() {
public NodeMap transientData() {
return this.transientNodes;
}
public ImmutableSetMultimap<ImmutableContextSet, Node> getNodes(NodeMapType type) {
return getData(type).immutable();
}
public ImmutableSetMultimap<ImmutableContextSet, Node> getEnduringNodes() {
return this.enduringNodes.immutable();
}
public ImmutableSetMultimap<ImmutableContextSet, Node> getTransientNodes() {
return this.transientNodes.immutable();
}
/**
* Sets this objects nodes to the values in the set
*
* @param set the set of nodes to apply to the object
*/
public void setEnduringNodes(Set<Node> set) {
this.enduringNodes.setContent(set);
public void setNodes(NodeMapType type, Set<Node> set) {
getData(type).setContent(set);
invalidateCache();
}
/**
* Replaces the multimap backing this object with another
*
* @param multimap the replacement multimap
*/
public void replaceEnduringNodes(Multimap<ImmutableContextSet, Node> multimap) {
this.enduringNodes.setContent(multimap);
public void replaceNodes(NodeMapType type, Multimap<ImmutableContextSet, Node> multimap) {
getData(type).setContent(multimap);
invalidateCache();
}
@@ -334,7 +286,7 @@ public abstract class PermissionHolder {
}
public boolean removeIf(Predicate<Node> predicate, Runnable taskIfSuccess) {
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
if (!this.enduringNodes.removeIf(predicate)) {
return false;
}
@@ -342,7 +294,7 @@ public abstract class PermissionHolder {
taskIfSuccess.run();
}
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
this.plugin.getEventFactory().handleNodeClear(this, before, after);
return true;
@@ -353,7 +305,7 @@ public abstract class PermissionHolder {
}
public boolean removeIf(ContextSet contextSet, Predicate<Node> predicate, Runnable taskIfSuccess) {
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
if (!this.enduringNodes.removeIf(contextSet, predicate)) {
return false;
}
@@ -361,7 +313,7 @@ public abstract class PermissionHolder {
taskIfSuccess.run();
}
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
this.plugin.getEventFactory().handleNodeClear(this, before, after);
return true;
@@ -375,7 +327,7 @@ public abstract class PermissionHolder {
return result;
}
private void accumulateInheritancesTo(List<LocalizedNode> accumulator, Contexts context) {
public void accumulateInheritancesTo(List<LocalizedNode> accumulator, Contexts context) {
InheritanceGraph graph = this.plugin.getInheritanceHandler().getGraph(context);
Iterable<PermissionHolder> traversal = graph.traverse(this.plugin.getConfiguration().get(ConfigKeys.INHERITANCE_TRAVERSAL_ALGORITHM), this);
for (PermissionHolder holder : traversal) {
@@ -393,27 +345,7 @@ public abstract class PermissionHolder {
return accumulator;
}
public SortedSet<LocalizedNode> resolveInheritancesAlmostEqual(Contexts contexts) {
List<LocalizedNode> nodes = new LinkedList<>();
accumulateInheritancesTo(nodes, contexts);
NodeTools.removeEqual(nodes.iterator(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(nodes);
return ret;
}
public SortedSet<LocalizedNode> resolveInheritancesMergeTemp(Contexts contexts) {
List<LocalizedNode> nodes = new LinkedList<>();
accumulateInheritancesTo(nodes, contexts);
NodeTools.removeEqual(nodes.iterator(), StandardNodeEquality.IGNORE_VALUE_OR_IF_TEMPORARY);
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(nodes);
return ret;
}
private void accumulateInheritancesTo(List<LocalizedNode> accumulator) {
public void accumulateInheritancesTo(List<LocalizedNode> accumulator) {
InheritanceGraph graph = this.plugin.getInheritanceHandler().getGraph();
Iterable<PermissionHolder> traversal = graph.traverse(this.plugin.getConfiguration().get(ConfigKeys.INHERITANCE_TRAVERSAL_ALGORITHM), this);
for (PermissionHolder holder : traversal) {
@@ -431,27 +363,7 @@ public abstract class PermissionHolder {
return accumulator;
}
public SortedSet<LocalizedNode> resolveInheritancesAlmostEqual() {
List<LocalizedNode> nodes = new LinkedList<>();
accumulateInheritancesTo(nodes);
NodeTools.removeEqual(nodes.iterator(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(nodes);
return ret;
}
public SortedSet<LocalizedNode> resolveInheritancesMergeTemp() {
List<LocalizedNode> nodes = new LinkedList<>();
accumulateInheritancesTo(nodes);
NodeTools.removeEqual(nodes.iterator(), StandardNodeEquality.IGNORE_VALUE_OR_IF_TEMPORARY);
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(nodes);
return ret;
}
private List<LocalizedNode> getAllEntries(Contexts context) {
public List<LocalizedNode> getAllEntries(Contexts context) {
List<LocalizedNode> entries = new LinkedList<>();
if (context.hasSetting(LookupSetting.RESOLVE_INHERITANCE)) {
accumulateInheritancesTo(entries, context);
@@ -472,15 +384,6 @@ public abstract class PermissionHolder {
return entries;
}
public SortedSet<LocalizedNode> getAllNodes(Contexts context) {
List<LocalizedNode> entries = getAllEntries(context);
NodeTools.removeSamePermission(entries.iterator());
SortedSet<LocalizedNode> ret = new TreeSet<>(NodeWithContextComparator.reverse());
ret.addAll(entries);
return ret;
}
public Map<String, Boolean> exportNodesAndShorthand(Contexts context, boolean lowerCase) {
List<LocalizedNode> entries = getAllEntries(context);
@@ -489,12 +392,12 @@ public abstract class PermissionHolder {
for (Node node : entries) {
String perm = lowerCase ? node.getPermission().toLowerCase() : node.getPermission();
if (perms.putIfAbsent(perm, node.getValuePrimitive()) == null) {
if (perms.putIfAbsent(perm, node.getValue()) == null) {
if (applyShorthand) {
List<String> shorthand = node.resolveShorthand();
if (!shorthand.isEmpty()) {
for (String s : shorthand) {
perms.putIfAbsent(lowerCase ? s.toLowerCase() : s, node.getValuePrimitive());
perms.putIfAbsent(lowerCase ? s.toLowerCase() : s, node.getValue());
}
}
}
@@ -512,11 +415,11 @@ public abstract class PermissionHolder {
for (Node node : entries) {
String perm = lowerCase ? node.getPermission().toLowerCase().intern() : node.getPermission();
if (perms.putIfAbsent(perm, node.getValuePrimitive()) == null && applyShorthand) {
if (perms.putIfAbsent(perm, node.getValue()) == null && applyShorthand) {
List<String> shorthand = node.resolveShorthand();
if (!shorthand.isEmpty()) {
for (String s : shorthand) {
perms.putIfAbsent((lowerCase ? s.toLowerCase() : s).intern(), node.getValuePrimitive());
perms.putIfAbsent((lowerCase ? s.toLowerCase() : s).intern(), node.getValue());
}
}
}
@@ -535,7 +438,7 @@ public abstract class PermissionHolder {
for (PermissionHolder holder : traversal) {
List<Node> nodes = holder.getOwnNodes(context.getContexts());
for (Node node : nodes) {
if (!node.getValuePrimitive()) continue;
if (!node.getValue()) continue;
if (!node.isMeta() && !node.isPrefix() && !node.isSuffix()) continue;
if (!((context.hasSetting(LookupSetting.INCLUDE_NODES_SET_WITHOUT_SERVER) || node.isServerSpecific()) && (context.hasSetting(LookupSetting.INCLUDE_NODES_SET_WITHOUT_WORLD) || node.isWorldSpecific()))) {
@@ -564,7 +467,7 @@ public abstract class PermissionHolder {
for (PermissionHolder holder : traversal) {
List<Node> nodes = holder.getOwnNodes();
for (Node node : nodes) {
if (!node.getValuePrimitive()) continue;
if (!node.getValue()) continue;
if (!node.isMeta() && !node.isPrefix() && !node.isSuffix()) continue;
accumulator.accumulateNode(ImmutableLocalizedNode.of(node, holder.getObjectName()));
@@ -589,7 +492,7 @@ public abstract class PermissionHolder {
// we don't call events for transient nodes
boolean transientWork = this.transientNodes.auditTemporaryNodes(null);
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
Set<Node> removed = new HashSet<>();
boolean enduringWork = this.enduringNodes.auditTemporaryNodes(removed);
@@ -598,7 +501,7 @@ public abstract class PermissionHolder {
invalidateCache();
// call event
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
for (Node r : removed) {
this.plugin.getEventFactory().handleNodeRemove(r, this, before, after);
}
@@ -636,18 +539,6 @@ public abstract class PermissionHolder {
return searchForMatch(type, node, equalityPredicate).map(Node::getTristate).orElse(Tristate.UNDEFINED);
}
public Tristate hasPermission(NodeMapType type, Node node) {
return hasPermission(type, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
}
public Tristate hasPermission(Node node, NodeEqualityPredicate equalityPredicate) {
return hasPermission(NodeMapType.ENDURING, node, equalityPredicate);
}
public Tristate hasPermission(Node node) {
return hasPermission(NodeMapType.ENDURING, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
}
/**
* Check if the holder inherits a node
*
@@ -676,24 +567,20 @@ public abstract class PermissionHolder {
return searchForInheritedMatch(node, equalityPredicate).getResult();
}
public Tristate inheritsPermission(Node node) {
return inheritsPermission(node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE);
}
/**
* Sets a permission node
*
* @param node the node to set
*/
public DataMutateResult setPermission(Node node) {
if (hasPermission(NodeMapType.ENDURING, node) != Tristate.UNDEFINED) {
if (hasPermission(NodeMapType.ENDURING, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE) != Tristate.UNDEFINED) {
return DataMutateResult.ALREADY_HAS;
}
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
this.enduringNodes.add(node);
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
this.plugin.getEventFactory().handleNodeAdd(node, this, before, after);
return DataMutateResult.SUCCESS;
@@ -720,10 +607,10 @@ public abstract class PermissionHolder {
Node newNode = node.toBuilder().setExpiry(previous.getExpiryUnixTime() + node.getSecondsTilExpiry()).build();
// Remove the old node & add the new one.
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
this.enduringNodes.replace(newNode, previous);
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
this.plugin.getEventFactory().handleNodeAdd(newNode, this, before, after);
return Maps.immutableEntry(DataMutateResult.SUCCESS, newNode);
@@ -740,10 +627,10 @@ public abstract class PermissionHolder {
// Only replace if the new expiry time is greater than the old one.
if (node.getExpiryUnixTime() > previous.getExpiryUnixTime()) {
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
this.enduringNodes.replace(node, previous);
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
this.plugin.getEventFactory().handleNodeAdd(node, this, before, after);
return Maps.immutableEntry(DataMutateResult.SUCCESS, node);
@@ -764,7 +651,7 @@ public abstract class PermissionHolder {
* @param node the node to set
*/
public DataMutateResult setTransientPermission(Node node) {
if (hasPermission(NodeMapType.TRANSIENT, node) != Tristate.UNDEFINED) {
if (hasPermission(NodeMapType.TRANSIENT, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE) != Tristate.UNDEFINED) {
return DataMutateResult.ALREADY_HAS;
}
@@ -779,14 +666,14 @@ public abstract class PermissionHolder {
* @param node the node to unset
*/
public DataMutateResult unsetPermission(Node node) {
if (hasPermission(NodeMapType.ENDURING, node) == Tristate.UNDEFINED) {
if (hasPermission(NodeMapType.ENDURING, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE) == Tristate.UNDEFINED) {
return DataMutateResult.LACKS;
}
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
this.enduringNodes.remove(node);
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
this.plugin.getEventFactory().handleNodeRemove(node, this, before, after);
return DataMutateResult.SUCCESS;
@@ -798,7 +685,7 @@ public abstract class PermissionHolder {
* @param node the node to unset
*/
public DataMutateResult unsetTransientPermission(Node node) {
if (hasPermission(NodeMapType.TRANSIENT, node) == Tristate.UNDEFINED) {
if (hasPermission(NodeMapType.TRANSIENT, node, StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE) == Tristate.UNDEFINED) {
return DataMutateResult.LACKS;
}
@@ -808,21 +695,21 @@ public abstract class PermissionHolder {
}
public boolean inheritsGroup(Group group) {
return group.getName().equalsIgnoreCase(this.getObjectName()) || hasPermission(NodeFactory.buildGroupNode(group.getName()).build()).asBoolean();
return group.getName().equalsIgnoreCase(this.getObjectName()) || hasPermission(NodeMapType.ENDURING, NodeFactory.buildGroupNode(group.getName()).build(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE).asBoolean();
}
public boolean inheritsGroup(Group group, ContextSet contextSet) {
return group.getName().equalsIgnoreCase(this.getObjectName()) || hasPermission(NodeFactory.buildGroupNode(group.getName()).withExtraContext(contextSet).build()).asBoolean();
return group.getName().equalsIgnoreCase(this.getObjectName()) || hasPermission(NodeMapType.ENDURING, NodeFactory.buildGroupNode(group.getName()).withExtraContext(contextSet).build(), StandardNodeEquality.IGNORE_EXPIRY_TIME_AND_VALUE).asBoolean();
}
/**
* Clear all of the holders permission nodes
*/
public boolean clearNodes() {
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
this.enduringNodes.clear();
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
if (before.size() == after.size()) {
return false;
@@ -833,10 +720,10 @@ public abstract class PermissionHolder {
}
public boolean clearNodes(ContextSet contextSet) {
ImmutableCollection<Node> before = getEnduringNodes().values();
ImmutableCollection<Node> before = enduringData().immutable().values();
this.enduringNodes.clear(contextSet);
invalidateCache();
ImmutableCollection<Node> after = getEnduringNodes().values();
ImmutableCollection<Node> after = enduringData().immutable().values();
if (before.size() == after.size()) {
return false;
@@ -847,11 +734,11 @@ public abstract class PermissionHolder {
}
public boolean clearPermissions() {
return removeIf(Node::isRegularPermissionNode);
return removeIf(node -> !node.hasTypeData());
}
public boolean clearPermissions(ContextSet contextSet) {
return removeIf(contextSet, Node::isRegularPermissionNode);
return removeIf(contextSet, node -> !node.hasTypeData());
}
public boolean clearParents(boolean giveDefault) {
@@ -893,14 +780,6 @@ public abstract class PermissionHolder {
}
public OptionalInt getWeight() {
return this.weightCache.get();
}
public Set<HolderReference> getGroupReferences() {
return getOwnGroupNodes().stream()
.map(Node::getGroupName)
.map(String::toLowerCase)
.map(GroupReference::of)
.collect(Collectors.toSet());
return OptionalInt.empty();
}
}
common/src/main/java/me/lucko/luckperms/common/model/Track.java
+5 -6
View File
@@ -35,9 +35,8 @@ import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.common.api.DemotionResults;
import me.lucko.luckperms.common.api.PromotionResults;
import me.lucko.luckperms.common.api.delegates.model.ApiTrack;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.references.Identifiable;
import me.lucko.luckperms.common.sender.Sender;
import java.util.ArrayList;
@@ -277,9 +276,9 @@ public final class Track implements Identifiable<String> {
}
// find all groups that are inherited by the user in the exact contexts given and applicable to this track
List<Node> nodes = user.getEnduringNodes().get(context.makeImmutable()).stream()
List<Node> nodes = user.enduringData().immutable().get(context.makeImmutable()).stream()
.filter(Node::isGroupNode)
.filter(Node::getValuePrimitive)
.filter(Node::getValue)
.filter(node -> containsGroup(node.getGroupName()))
.distinct()
.collect(Collectors.toList());
@@ -339,9 +338,9 @@ public final class Track implements Identifiable<String> {
}
// find all groups that are inherited by the user in the exact contexts given and applicable to this track
List<Node> nodes = user.getEnduringNodes().get(context.makeImmutable()).stream()
List<Node> nodes = user.enduringData().immutable().get(context.makeImmutable()).stream()
.filter(Node::isGroupNode)
.filter(Node::getValuePrimitive)
.filter(node -> node.getValue())
.filter(node -> containsGroup(node.getGroupName()))
.distinct()
.collect(Collectors.toList());
common/src/main/java/me/lucko/luckperms/common/model/User.java
-9
View File
@@ -31,10 +31,6 @@ import me.lucko.luckperms.common.caching.UserCachedData;
import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.plugin.LuckPermsPlugin;
import me.lucko.luckperms.common.primarygroup.PrimaryGroupHolder;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.references.Identifiable;
import me.lucko.luckperms.common.references.UserIdentifier;
import me.lucko.luckperms.common.references.UserReference;
import java.util.Optional;
import java.util.UUID;
@@ -161,11 +157,6 @@ public class User extends PermissionHolder implements Identifiable<UserIdentifie
return this.name != null ? this.name : this.uuid.toString();
}
@Override
public UserReference toReference() {
return UserReference.of(getId());
}
@Override
public HolderType getType() {
return HolderType.USER;
common/src/main/java/me/lucko/luckperms/common/references/UserIdentifier.java → common/src/main/java/me/lucko/luckperms/common/model/UserIdentifier.java
+1 -3
View File
@@ -23,9 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.references;
import me.lucko.luckperms.common.model.User;
package me.lucko.luckperms.common.model;
import java.util.Objects;
import java.util.Optional;
common/src/main/java/me/lucko/luckperms/common/model/WeightCache.java
+9 -21
View File
@@ -27,35 +27,21 @@ package me.lucko.luckperms.common.model;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.api.nodetype.types.WeightType;
import me.lucko.luckperms.common.buffers.Cache;
import me.lucko.luckperms.common.config.ConfigKeys;
import me.lucko.luckperms.common.node.NodeFactory;
import java.util.Map;
import java.util.Optional;
import java.util.OptionalInt;
/**
* Cache instance to supply the weight of a {@link PermissionHolder}.
*/
public class WeightCache extends Cache<OptionalInt> {
private static final Cache<OptionalInt> NULL = new Cache<OptionalInt>() {
@Override
protected OptionalInt supply() {
return OptionalInt.empty();
}
};
public static Cache<OptionalInt> getFor(PermissionHolder holder) {
if (holder.getType().isUser()) {
return NULL;
}
return new WeightCache(((Group) holder));
}
private final Group group;
private WeightCache(Group group) {
public WeightCache(Group group) {
this.group = group;
}
@@ -64,14 +50,16 @@ public class WeightCache extends Cache<OptionalInt> {
boolean seen = false;
int best = 0;
for (Node n : this.group.getOwnNodes(ImmutableContextSet.empty())) {
Integer weight = NodeFactory.parseWeightNode(n.getPermission());
if (weight == null) {
Optional<WeightType> weight = n.getTypeData(WeightType.KEY);
if (!weight.isPresent()) {
continue;
}
if (!seen || weight > best) {
int value = weight.get().getWeight();
if (!seen || value > best) {
seen = true;
best = weight;
best = value;
}
}
OptionalInt weight = seen ? OptionalInt.of(best) : OptionalInt.empty();
common/src/main/java/me/lucko/luckperms/common/node/HeldPermissionComparator.java → common/src/main/java/me/lucko/luckperms/common/node/comparator/HeldPermissionComparator.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.comparator;
import me.lucko.luckperms.api.HeldPermission;
common/src/main/java/me/lucko/luckperms/common/node/NodeComparator.java → common/src/main/java/me/lucko/luckperms/common/node/comparator/NodeComparator.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.comparator;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.common.utils.CollationKeyCache;
common/src/main/java/me/lucko/luckperms/common/node/NodeWithContextComparator.java → common/src/main/java/me/lucko/luckperms/common/node/comparator/NodeWithContextComparator.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.comparator;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.common.utils.CollationKeyCache;
common/src/main/java/me/lucko/luckperms/common/node/LegacyNodeFactory.java → common/src/main/java/me/lucko/luckperms/common/node/factory/LegacyNodeFactory.java
+6 -6
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.factory;
import com.google.common.base.Splitter;
@@ -40,17 +40,17 @@ public final class LegacyNodeFactory {
/**
* The characters which are delimited when serializing a permission string
*/
static final String[] PERMISSION_DELIMITERS = new String[]{"/", "-", "$", "(", ")", "=", ","};
public static final String[] PERMISSION_DELIMITERS = new String[]{"/", "-", "$", "(", ")", "=", ","};
/**
* The characters which are delimited when serializing a server or world string
*/
static final String[] SERVER_WORLD_DELIMITERS = new String[]{"/", "-"};
public static final String[] SERVER_WORLD_DELIMITERS = new String[]{"/", "-"};
/**
* The characters which are delimited when serializing a context set
*/
static final String[] CONTEXT_DELIMITERS = new String[]{"=", "(", ")", ","};
private static final String[] CONTEXT_DELIMITERS = new String[]{"=", "(", ")", ","};
/**
* The characters which are delimited when serializing meta/prefix/suffix strings
@@ -146,7 +146,7 @@ public final class LegacyNodeFactory {
return escapeDelimiters(s, GENERIC_DELIMITERS);
}
static String unescapeCharacters(String s) {
public static String unescapeCharacters(String s) {
if (s == null) {
throw new NullPointerException();
}
@@ -172,7 +172,7 @@ public final class LegacyNodeFactory {
return s;
}
static String unescapeDelimiters(String s, String... delimiters) {
public static String unescapeDelimiters(String s, String... delimiters) {
if (s == null) {
return null;
}
common/src/main/java/me/lucko/luckperms/common/node/NodeBuilder.java → common/src/main/java/me/lucko/luckperms/common/node/factory/NodeBuilder.java
+6 -5
View File
@@ -23,12 +23,13 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.factory;
import me.lucko.luckperms.api.Contexts;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.node.model.ImmutableNode;
import java.util.Map;
import java.util.Objects;
@@ -39,7 +40,7 @@ import javax.annotation.Nonnull;
/**
* Builds node instances
*/
class NodeBuilder implements Node.Builder {
public class NodeBuilder implements Node.Builder {
protected String permission;
private ImmutableContextSet.Builder extraContexts = ImmutableContextSet.builder();
private Boolean value = true;
@@ -48,7 +49,7 @@ class NodeBuilder implements Node.Builder {
private String world = null;
private long expireAt = 0L;
protected NodeBuilder() {
NodeBuilder() {
}
@@ -56,7 +57,7 @@ class NodeBuilder implements Node.Builder {
this.permission = permission;
}
NodeBuilder(Node other) {
public NodeBuilder(Node other) {
this.permission = other.getPermission();
copyFrom(other);
}
@@ -64,7 +65,7 @@ class NodeBuilder implements Node.Builder {
@Override
public Node.Builder copyFrom(@Nonnull Node node) {
Objects.requireNonNull(node, "node");
this.value = node.getValuePrimitive();
this.value = node.getValue();
this.override = node.isOverride();
this.server = node.getServer().orElse(null);
this.world = node.getWorld().orElse(null);
common/src/main/java/me/lucko/luckperms/common/node/NodeFactory.java → common/src/main/java/me/lucko/luckperms/common/node/factory/NodeFactory.java
+11 -96
View File
@@ -23,19 +23,15 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
import com.google.common.base.Splitter;
import com.google.common.collect.Maps;
package me.lucko.luckperms.common.node.factory;
import me.lucko.luckperms.api.ChatMetaType;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.common.model.Group;
import me.lucko.luckperms.common.references.HolderType;
import me.lucko.luckperms.common.utils.PatternCache;
import me.lucko.luckperms.common.model.HolderType;
import me.lucko.luckperms.common.node.model.NodeTypes;
import java.util.Iterator;
import java.util.Map;
/**
@@ -44,20 +40,6 @@ import java.util.Map;
public final class NodeFactory {
public static final String DEFAULT_GROUP_NAME = "default";
public static final String PREFIX_KEY = "prefix";
public static final String SUFFIX_KEY = "suffix";
public static final String META_KEY = "meta";
public static final String WEIGHT_KEY = "weight";
private static final String GROUP_NODE_MARKER = "group.";
private static final String PREFIX_NODE_MARKER = PREFIX_KEY + ".";
private static final String SUFFIX_NODE_MARKER = SUFFIX_KEY + ".";
private static final String META_NODE_MARKER = META_KEY + ".";
private static final String WEIGHT_NODE_MARKER = WEIGHT_KEY + ".";
// used to split prefix/suffix/meta nodes
private static final Splitter META_SPLITTER = Splitter.on(PatternCache.compileDelimiterPattern(".", "\\")).limit(2);
public static Node.Builder builder(String s) {
return new NodeBuilder(s);
}
@@ -91,7 +73,7 @@ public final class NodeFactory {
}
public static String groupNode(String groupName) {
return GROUP_NODE_MARKER + groupName;
return NodeTypes.GROUP_NODE_MARKER + groupName;
}
public static String chatMetaNode(ChatMetaType type, int priority, String value) {
@@ -99,19 +81,19 @@ public final class NodeFactory {
}
public static String prefixNode(int priority, String prefix) {
return PREFIX_NODE_MARKER + priority + "." + LegacyNodeFactory.escapeCharacters(prefix);
return NodeTypes.PREFIX_NODE_MARKER + priority + "." + LegacyNodeFactory.escapeCharacters(prefix);
}
public static String suffixNode(int priority, String suffix) {
return SUFFIX_NODE_MARKER + priority + "." + LegacyNodeFactory.escapeCharacters(suffix);
return NodeTypes.SUFFIX_NODE_MARKER + priority + "." + LegacyNodeFactory.escapeCharacters(suffix);
}
public static String metaNode(String key, String value) {
return META_NODE_MARKER + LegacyNodeFactory.escapeCharacters(key) + "." + LegacyNodeFactory.escapeCharacters(value);
return NodeTypes.META_NODE_MARKER + LegacyNodeFactory.escapeCharacters(key) + "." + LegacyNodeFactory.escapeCharacters(value);
}
public static String weightNode(int weight) {
return WEIGHT_NODE_MARKER + weight;
return NodeTypes.WEIGHT_NODE_MARKER + weight;
}
public static Node make(String node) {
@@ -232,7 +214,7 @@ public final class NodeFactory {
return appendContextToCommand(sb, node).toString();
}
if (node.getValuePrimitive() && (node.isPrefix() || node.isSuffix())) {
if (node.getValue() && (node.isPrefix() || node.isSuffix())) {
ChatMetaType chatMetaType = node.isPrefix() ? ChatMetaType.PREFIX : ChatMetaType.SUFFIX;
sb.append("meta ");
@@ -267,7 +249,7 @@ public final class NodeFactory {
return appendContextToCommand(sb, node).toString();
}
if (node.getValuePrimitive() && node.isMeta()) {
if (node.getValue() && node.isMeta()) {
sb.append("meta ");
if (set) {
@@ -329,7 +311,7 @@ public final class NodeFactory {
sb.append(perm);
}
if (set) {
sb.append(" ").append(node.getValuePrimitive());
sb.append(" ").append(node.getValue());
if (node.isTemporary()) {
sb.append(" ").append(node.getExpiryUnixTime());
@@ -355,73 +337,6 @@ public final class NodeFactory {
return sb;
}
public static String parseGroupNode(String s) {
String lower = s.toLowerCase();
if (!lower.startsWith(GROUP_NODE_MARKER)) {
return null;
}
return lower.substring(GROUP_NODE_MARKER.length()).intern();
}
public static Map.Entry<String, String> parseMetaNode(String s) {
if (!s.toLowerCase().startsWith(META_NODE_MARKER)) {
return null;
}
Iterator<String> metaParts = META_SPLITTER.split(s.substring(META_NODE_MARKER.length())).iterator();
if (!metaParts.hasNext()) return null;
String key = metaParts.next();
if (!metaParts.hasNext()) return null;
String value = metaParts.next();
return Maps.immutableEntry(LegacyNodeFactory.unescapeCharacters(key).intern(), LegacyNodeFactory.unescapeCharacters(value).intern());
}
private static Map.Entry<Integer, String> parseChatMetaNode(String marker, String s) {
if (!s.toLowerCase().startsWith(marker)) {
return null;
}
Iterator<String> metaParts = META_SPLITTER.split(s.substring(marker.length())).iterator();
if (!metaParts.hasNext()) return null;
String priority = metaParts.next();
if (!metaParts.hasNext()) return null;
String value = metaParts.next();
try {
int p = Integer.parseInt(priority);
String v = LegacyNodeFactory.unescapeCharacters(value).intern();
return Maps.immutableEntry(p, v);
} catch (NumberFormatException e) {
return null;
}
}
public static Map.Entry<Integer, String> parsePrefixNode(String s) {
return parseChatMetaNode(PREFIX_NODE_MARKER, s);
}
public static Map.Entry<Integer, String> parseSuffixNode(String s) {
return parseChatMetaNode(SUFFIX_NODE_MARKER, s);
}
public static Integer parseWeightNode(String s) {
String lower = s.toLowerCase();
if (!lower.startsWith(WEIGHT_NODE_MARKER)) {
return null;
}
String i = lower.substring(WEIGHT_NODE_MARKER.length());
try {
return Integer.parseInt(i);
} catch (NumberFormatException e) {
return null;
}
}
private NodeFactory() {}
}
common/src/main/java/me/lucko/luckperms/common/node/ForwardingNode.java → common/src/main/java/me/lucko/luckperms/common/node/model/ForwardingNode.java
+19 -13
View File
@@ -23,13 +23,15 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.model;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.NodeEqualityPredicate;
import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.Tristate;
import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.api.nodetype.NodeType;
import me.lucko.luckperms.api.nodetype.NodeTypeKey;
import java.util.Date;
import java.util.List;
@@ -58,17 +60,11 @@ public abstract class ForwardingNode implements Node {
return delegate().getPermission();
}
@Nonnull
@Override
public Boolean getValue() {
public boolean getValue() {
return delegate().getValue();
}
@Override
public boolean getValuePrimitive() {
return delegate().getValuePrimitive();
}
@Nonnull
@Override
public Tristate getTristate() {
@@ -171,11 +167,6 @@ public abstract class ForwardingNode implements Node {
return delegate().getFullContexts();
}
@Override
public boolean isRegularPermissionNode() {
return delegate().isRegularPermissionNode();
}
@Override
public boolean isGroupNode() {
return delegate().isGroupNode();
@@ -197,6 +188,21 @@ public abstract class ForwardingNode implements Node {
return delegate().getWildcardLevel();
}
@Override
public boolean hasTypeData() {
return delegate().hasTypeData();
}
@Override
public <T extends NodeType> Optional<T> getTypeData(NodeTypeKey<T> key) {
return delegate().getTypeData(key);
}
@Override
public <T extends NodeType> T typeData(NodeTypeKey<T> key) throws IllegalStateException {
return delegate().typeData(key);
}
@Override
public boolean isMeta() {
return delegate().isMeta();
common/src/main/java/me/lucko/luckperms/common/node/ImmutableLocalizedNode.java → common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableLocalizedNode.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.model;
import me.lucko.luckperms.api.LocalizedNode;
import me.lucko.luckperms.api.Node;
common/src/main/java/me/lucko/luckperms/common/node/ImmutableNode.java → common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableNode.java
+39 -90
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.model;
import com.google.common.collect.ImmutableList;
@@ -33,75 +33,67 @@ import me.lucko.luckperms.api.StandardNodeEquality;
import me.lucko.luckperms.api.context.ContextSet;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.api.context.MutableContextSet;
import me.lucko.luckperms.api.nodetype.NodeType;
import me.lucko.luckperms.api.nodetype.NodeTypeKey;
import me.lucko.luckperms.common.node.factory.LegacyNodeFactory;
import me.lucko.luckperms.common.node.factory.NodeBuilder;
import me.lucko.luckperms.common.node.utils.ShorthandParser;
import me.lucko.luckperms.common.processors.WildcardProcessor;
import java.util.Date;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import javax.annotation.Nonnull;
import javax.annotation.Nullable;
import static com.google.common.base.Preconditions.checkState;
/**
* An immutable implementation of {@link Node}.
*/
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
public final class ImmutableNode implements Node {
/**
* The character which separates each part of a permission node
*/
public static final char NODE_SEPARATOR = '.';
public static final int NODE_SEPARATOR_CODE = Character.getNumericValue('.');
/**
* The numeric value of {@link #NODE_SEPARATOR}
*/
public static final int NODE_SEPARATOR_CODE = Character.getNumericValue(NODE_SEPARATOR);
// node attributes
private final String permission;
private final boolean value;
private boolean override;
// nullable
@Nullable
private final String server;
// nullable
@Nullable
private final String world;
// 0L for no expiry
private final long expireAt;
private final long expireAt; // 0L for no expiry
private final ImmutableContextSet contexts;
private final ImmutableContextSet fullContexts;
/*
* CACHED STATE
*
* These values are based upon the node state above, and are stored here
* to make node comparison and manipulation faster.
*
* This increases the memory footprint of this class by a bit, but it is
* worth it for the gain in speed.
*
* The methods on this class are called v. frequently.
*/
// storing optionals as a field type is usually a bad idea, however, the
// #getServer and #getWorld methods are called frequently when comparing nodes.
// without caching these values, it creates quite a bit of object churn
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
// cached state
private final Optional<String> optServer;
@SuppressWarnings("OptionalUsedAsFieldOrParameterType")
private final Optional<String> optWorld;
// this class is immutable, so we can cache the hashcode calculation
private final int hashCode;
// all nullable
private String groupName;
private final int wildcardLevel;
private Map.Entry<String, String> meta;
private Map.Entry<Integer, String> prefix;
private Map.Entry<Integer, String> suffix;
private final Map<NodeTypeKey<?>, NodeType> resolvedTypes;
private final List<String> resolvedShorthand;
/**
@@ -114,8 +106,7 @@ public final class ImmutableNode implements Node {
* @param world the world this node applies on
* @param contexts any additional contexts applying to this node
*/
@SuppressWarnings("deprecation")
ImmutableNode(String permission, boolean value, boolean override, long expireAt, String server, String world, ContextSet contexts) {
public ImmutableNode(String permission, boolean value, boolean override, long expireAt, String server, String world, ContextSet contexts) {
if (permission == null || permission.isEmpty()) {
throw new IllegalArgumentException("Empty permission");
}
@@ -134,11 +125,8 @@ public final class ImmutableNode implements Node {
this.contexts = contexts == null ? ContextSet.empty() : contexts.makeImmutable();
// define cached state
this.groupName = NodeFactory.parseGroupNode(this.permission);
this.wildcardLevel = this.permission.endsWith(WildcardProcessor.WILDCARD_SUFFIX) ? this.permission.chars().filter(num -> num == NODE_SEPARATOR_CODE).sum() : -1;
this.meta = NodeFactory.parseMetaNode(this.permission);
this.prefix = NodeFactory.parsePrefixNode(this.permission);
this.suffix = NodeFactory.parseSuffixNode(this.permission);
this.resolvedTypes = NodeTypes.parseTypes(this.permission);
this.resolvedShorthand = ImmutableList.copyOf(ShorthandParser.parseShorthand(getPermission()));
this.optServer = Optional.ofNullable(this.server);
this.optWorld = Optional.ofNullable(this.world);
@@ -173,7 +161,7 @@ public final class ImmutableNode implements Node {
}
@Override
public boolean getValuePrimitive() {
public boolean getValue() {
return this.value;
}
@@ -226,6 +214,11 @@ public final class ImmutableNode implements Node {
return this.server != null || this.world != null || !this.contexts.isEmpty();
}
@Override
public boolean shouldApplyWithContext(@Nonnull ContextSet contextSet) {
return getFullContexts().isSatisfiedBy(contextSet);
}
@Override
public boolean isTemporary() {
return this.expireAt != 0L;
@@ -255,23 +248,6 @@ public final class ImmutableNode implements Node {
return isTemporary() && this.expireAt < System.currentTimeMillis() / 1000L;
}
@Override
public boolean isRegularPermissionNode() {
return !isGroupNode() && !isPrefix() && !isSuffix() && !isMeta();
}
@Override
public boolean isGroupNode() {
return this.groupName != null;
}
@Nonnull
@Override
public String getGroupName() {
checkState(isGroupNode(), "Node is not a group node");
return this.groupName;
}
@Override
public boolean isWildcard() {
return this.wildcardLevel != -1;
@@ -284,44 +260,17 @@ public final class ImmutableNode implements Node {
}
@Override
public boolean isMeta() {
return this.meta != null;
}
@Nonnull
@Override
public Map.Entry<String, String> getMeta() {
checkState(isMeta(), "Node is not a meta node");
return this.meta;
public boolean hasTypeData() {
return !this.resolvedTypes.isEmpty();
}
@Override
public boolean isPrefix() {
return this.prefix != null;
}
public <T extends NodeType> Optional<T> getTypeData(NodeTypeKey<T> key) {
Objects.requireNonNull(key, "key");
@Nonnull
@Override
public Map.Entry<Integer, String> getPrefix() {
checkState(isPrefix(), "Node is not a prefix node");
return this.prefix;
}
@Override
public boolean isSuffix() {
return this.suffix != null;
}
@Nonnull
@Override
public Map.Entry<Integer, String> getSuffix() {
checkState(isSuffix(), "Node is not a suffix node");
return this.suffix;
}
@Override
public boolean shouldApplyWithContext(@Nonnull ContextSet contextSet) {
return getFullContexts().isSatisfiedBy(contextSet);
//noinspection unchecked
T result = (T) this.resolvedTypes.get(key);
return Optional.ofNullable(result);
}
@Nonnull
common/src/main/java/me/lucko/luckperms/common/node/ImmutableTransientNode.java → common/src/main/java/me/lucko/luckperms/common/node/model/ImmutableTransientNode.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.model;
import me.lucko.luckperms.api.Node;
common/src/main/java/me/lucko/luckperms/common/node/NodeModel.java → common/src/main/java/me/lucko/luckperms/common/node/model/NodeDataContainer.java
+18 -17
View File
@@ -23,10 +23,11 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.model;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.node.factory.NodeFactory;
import java.util.Objects;
@@ -36,12 +37,12 @@ import java.util.Objects;
*
* All values are non-null.
*/
public final class NodeModel {
public final class NodeDataContainer {
public static NodeModel fromNode(Node node) {
NodeModel model = of(
public static NodeDataContainer fromNode(Node node) {
NodeDataContainer model = of(
node.getPermission(),
node.getValuePrimitive(),
node.getValue(),
node.getServer().orElse("global"),
node.getWorld().orElse("global"),
node.isTemporary() ? node.getExpiryUnixTime() : 0L,
@@ -51,11 +52,11 @@ public final class NodeModel {
return model;
}
public static NodeModel of(String permission, boolean value, String server, String world, long expiry, ImmutableContextSet contexts) {
return new NodeModel(permission, value, server, world, expiry, contexts);
public static NodeDataContainer of(String permission, boolean value, String server, String world, long expiry, ImmutableContextSet contexts) {
return new NodeDataContainer(permission, value, server, world, expiry, contexts);
}
public static NodeModel of(String permission) {
public static NodeDataContainer of(String permission) {
return of(permission, true, "global", "global", 0L, ImmutableContextSet.empty());
}
@@ -67,7 +68,7 @@ public final class NodeModel {
private final ImmutableContextSet contexts;
private Node node = null;
private NodeModel(String permission, boolean value, String server, String world, long expiry, ImmutableContextSet contexts) {
private NodeDataContainer(String permission, boolean value, String server, String world, long expiry, ImmutableContextSet contexts) {
this.permission = Objects.requireNonNull(permission, "permission");
this.value = value;
this.server = Objects.requireNonNull(server, "server");
@@ -114,35 +115,35 @@ public final class NodeModel {
return this.contexts;
}
public NodeModel setPermission(String permission) {
public NodeDataContainer setPermission(String permission) {
return of(permission, this.value, this.server, this.world, this.expiry, this.contexts);
}
public NodeModel setValue(boolean value) {
public NodeDataContainer setValue(boolean value) {
return of(this.permission, value, this.server, this.world, this.expiry, this.contexts);
}
public NodeModel setServer(String server) {
public NodeDataContainer setServer(String server) {
return of(this.permission, this.value, server, this.world, this.expiry, this.contexts);
}
public NodeModel setWorld(String world) {
public NodeDataContainer setWorld(String world) {
return of(this.permission, this.value, this.server, world, this.expiry, this.contexts);
}
public NodeModel setExpiry(long expiry) {
public NodeDataContainer setExpiry(long expiry) {
return of(this.permission, this.value, this.server, this.world, expiry, this.contexts);
}
public NodeModel setContexts(ImmutableContextSet contexts) {
public NodeDataContainer setContexts(ImmutableContextSet contexts) {
return of(this.permission, this.value, this.server, this.world, this.expiry, contexts);
}
@Override
public boolean equals(Object o) {
if (o == this) return true;
if (!(o instanceof NodeModel)) return false;
final NodeModel other = (NodeModel) o;
if (!(o instanceof NodeDataContainer)) return false;
final NodeDataContainer other = (NodeDataContainer) o;
return this.getPermission().equals(other.getPermission()) &&
this.getValue() == other.getValue() &&
common/src/main/java/me/lucko/luckperms/common/node/NodeHeldPermission.java → common/src/main/java/me/lucko/luckperms/common/node/model/NodeHeldPermission.java
+4 -5
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.model;
import me.lucko.luckperms.api.HeldPermission;
import me.lucko.luckperms.api.Node;
@@ -31,13 +31,12 @@ import me.lucko.luckperms.api.context.ContextSet;
import java.util.Optional;
import java.util.OptionalLong;
import java.util.UUID;
import javax.annotation.Nonnull;
public final class NodeHeldPermission<T extends Comparable<T>> implements HeldPermission<T> {
public static <T extends Comparable<T>> NodeHeldPermission<T> of(T holder, NodeModel nodeModel) {
return of(holder, nodeModel.toNode());
public static <T extends Comparable<T>> NodeHeldPermission<T> of(T holder, NodeDataContainer node) {
return of(holder, node.toNode());
}
public static <T extends Comparable<T>> NodeHeldPermission<T> of(T holder, Node node) {
@@ -60,7 +59,7 @@ public final class NodeHeldPermission<T extends Comparable<T>> implements HeldPe
@Override
public boolean getValue() {
return this.node.getValuePrimitive();
return this.node.getValue();
}
@Nonnull
common/src/main/java/me/lucko/luckperms/common/node/model/NodeTypes.java
+319
View File
@@ -0,0 +1,319 @@
/*
* This file is part of LuckPerms, licensed under the MIT License.
*
* Copyright (c) lucko (Luck) <luck@lucko.me>
* Copyright (c) contributors
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
package me.lucko.luckperms.common.node.model;
import com.google.common.base.Splitter;
import com.google.common.collect.ImmutableMap;
import me.lucko.luckperms.api.nodetype.NodeType;
import me.lucko.luckperms.api.nodetype.NodeTypeKey;
import me.lucko.luckperms.api.nodetype.types.InheritanceType;
import me.lucko.luckperms.api.nodetype.types.MetaType;
import me.lucko.luckperms.api.nodetype.types.PrefixType;
import me.lucko.luckperms.api.nodetype.types.SuffixType;
import me.lucko.luckperms.api.nodetype.types.WeightType;
import me.lucko.luckperms.common.node.factory.LegacyNodeFactory;
import me.lucko.luckperms.common.utils.PatternCache;
import java.util.IdentityHashMap;
import java.util.Iterator;
import java.util.Map;
import javax.annotation.Nonnull;
public final class NodeTypes {
public static final String PREFIX_KEY = "prefix";
public static final String SUFFIX_KEY = "suffix";
public static final String META_KEY = "meta";
public static final String WEIGHT_KEY = "weight";
public static final String GROUP_NODE_MARKER = "group.";
public static final String PREFIX_NODE_MARKER = PREFIX_KEY + ".";
public static final String SUFFIX_NODE_MARKER = SUFFIX_KEY + ".";
public static final String META_NODE_MARKER = META_KEY + ".";
public static final String WEIGHT_NODE_MARKER = WEIGHT_KEY + ".";
// used to split prefix/suffix/meta nodes
private static final Splitter META_SPLITTER = Splitter.on(PatternCache.compileDelimiterPattern(".", "\\")).limit(2);
public static Map<NodeTypeKey<?>, NodeType> parseTypes(String s) {
Map<NodeTypeKey<?>, NodeType> results = new IdentityHashMap<>();
NodeType type = parseInheritanceType(s);
if (type != null) {
results.put(InheritanceType.KEY, type);
}
type = parseMetaType(s);
if (type != null) {
results.put(MetaType.KEY, type);
}
type = parsePrefixType(s);
if (type != null) {
results.put(PrefixType.KEY, type);
}
type = parseSuffixType(s);
if (type != null) {
results.put(SuffixType.KEY, type);
}
type = parseWeightType(s);
if (type != null) {
results.put(WeightType.KEY, type);
}
if (results.isEmpty()) {
return ImmutableMap.of();
}
return results;
}
private static InheritanceType parseInheritanceType(String s) {
s = s.toLowerCase();
if (!s.startsWith(GROUP_NODE_MARKER)) {
return null;
}
String groupName = s.substring(GROUP_NODE_MARKER.length()).intern();
return new Inheritance(groupName);
}
private static MetaType parseMetaType(String s) {
if (!s.toLowerCase().startsWith(META_NODE_MARKER)) {
return null;
}
Iterator<String> metaParts = META_SPLITTER.split(s.substring(META_NODE_MARKER.length())).iterator();
if (!metaParts.hasNext()) return null;
String key = metaParts.next();
if (!metaParts.hasNext()) return null;
String value = metaParts.next();
return new Meta(
LegacyNodeFactory.unescapeCharacters(key).intern(),
LegacyNodeFactory.unescapeCharacters(value).intern()
);
}
private static PrefixType parsePrefixType(String s) {
if (!s.toLowerCase().startsWith(PREFIX_NODE_MARKER)) {
return null;
}
Iterator<String> metaParts = META_SPLITTER.split(s.substring(PREFIX_NODE_MARKER.length())).iterator();
if (!metaParts.hasNext()) return null;
String priority = metaParts.next();
if (!metaParts.hasNext()) return null;
String value = metaParts.next();
try {
int p = Integer.parseInt(priority);
String v = LegacyNodeFactory.unescapeCharacters(value).intern();
return new Prefix(p, v);
} catch (NumberFormatException e) {
return null;
}
}
private static SuffixType parseSuffixType(String s) {
if (!s.toLowerCase().startsWith(SUFFIX_NODE_MARKER)) {
return null;
}
Iterator<String> metaParts = META_SPLITTER.split(s.substring(SUFFIX_NODE_MARKER.length())).iterator();
if (!metaParts.hasNext()) return null;
String priority = metaParts.next();
if (!metaParts.hasNext()) return null;
String value = metaParts.next();
try {
int p = Integer.parseInt(priority);
String v = LegacyNodeFactory.unescapeCharacters(value).intern();
return new Suffix(p, v);
} catch (NumberFormatException e) {
return null;
}
}
private static WeightType parseWeightType(String s) {
String lower = s.toLowerCase();
if (!lower.startsWith(WEIGHT_NODE_MARKER)) {
return null;
}
String i = lower.substring(WEIGHT_NODE_MARKER.length());
try {
return new Weight(Integer.parseInt(i));
} catch (NumberFormatException e) {
return null;
}
}
private static final class Inheritance implements InheritanceType {
private final String groupName;
private Inheritance(String groupName) {
this.groupName = groupName;
}
@Nonnull
@Override
public String getGroupName() {
return this.groupName;
}
}
private static final class Meta implements MetaType {
private final String key;
private final String value;
private Meta(String key, String value) {
this.key = key;
this.value = value;
}
@Nonnull
@Override
public String getKey() {
return this.key;
}
@Nonnull
@Override
public String getValue() {
return this.value;
}
}
private static final class Prefix implements PrefixType, Map.Entry<Integer, String> {
private final int priority;
private final String prefix;
private Prefix(int priority, String prefix) {
this.priority = priority;
this.prefix = prefix;
}
@Override
public int getPriority() {
return this.priority;
}
@Nonnull
@Override
public String getPrefix() {
return this.prefix;
}
@Nonnull
@Override
public Map.Entry<Integer, String> getAsEntry() {
return this;
}
@Override
public Integer getKey() {
return getPriority();
}
@Override
public String getValue() {
return getPrefix();
}
@Override
public String setValue(String value) {
throw new UnsupportedOperationException();
}
}
private static final class Suffix implements SuffixType, Map.Entry<Integer, String> {
private final int priority;
private final String suffix;
private Suffix(int priority, String suffix) {
this.priority = priority;
this.suffix = suffix;
}
@Override
public int getPriority() {
return this.priority;
}
@Nonnull
@Override
public String getSuffix() {
return this.suffix;
}
@Nonnull
@Override
public Map.Entry<Integer, String> getAsEntry() {
return this;
}
@Override
public Integer getKey() {
return getPriority();
}
@Override
public String getValue() {
return getSuffix();
}
@Override
public String setValue(String value) {
throw new UnsupportedOperationException();
}
}
private static final class Weight implements WeightType {
private final int weight;
private Weight(int weight) {
this.weight = weight;
}
@Override
public int getWeight() {
return this.weight;
}
}
private NodeTypes() {}
}
common/src/main/java/me/lucko/luckperms/common/node/InheritanceInfo.java → common/src/main/java/me/lucko/luckperms/common/node/utils/InheritanceInfo.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.utils;
import me.lucko.luckperms.api.LocalizedNode;
import me.lucko.luckperms.api.Tristate;
common/src/main/java/me/lucko/luckperms/common/node/MetaType.java → common/src/main/java/me/lucko/luckperms/common/node/utils/MetaType.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.utils;
import me.lucko.luckperms.api.Node;
common/src/main/java/me/lucko/luckperms/common/node/NodeTools.java → common/src/main/java/me/lucko/luckperms/common/node/utils/NodeTools.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.utils;
import me.lucko.luckperms.api.Node;
import me.lucko.luckperms.api.NodeEqualityPredicate;
common/src/main/java/me/lucko/luckperms/common/node/ShorthandParser.java → common/src/main/java/me/lucko/luckperms/common/node/utils/ShorthandParser.java
+1 -1
View File
@@ -23,7 +23,7 @@
* SOFTWARE.
*/
package me.lucko.luckperms.common.node;
package me.lucko.luckperms.common.node.utils;
import com.google.common.base.Splitter;
import com.google.common.collect.ImmutableList;
common/src/main/java/me/lucko/luckperms/common/plugin/AbstractLuckPermsPlugin.java
-8
View File
@@ -31,7 +31,6 @@ import me.lucko.luckperms.common.api.ApiRegistrationUtil;
import me.lucko.luckperms.common.api.LuckPermsApiProvider;
import me.lucko.luckperms.common.buffers.BufferedRequest;
import me.lucko.luckperms.common.buffers.UpdateTaskBuffer;
import me.lucko.luckperms.common.caching.handlers.CachedStateManager;
import me.lucko.luckperms.common.calculators.PlatformCalculatorFactory;
import me.lucko.luckperms.common.command.utils.MessageUtils;
import me.lucko.luckperms.common.config.AbstractConfiguration;
@@ -80,7 +79,6 @@ public abstract class AbstractLuckPermsPlugin implements LuckPermsPlugin {
private InternalMessagingService messagingService = null;
private BufferedRequest<Void> updateTaskBuffer;
private InheritanceHandler inheritanceHandler;
private CachedStateManager cachedStateManager;
private PlatformCalculatorFactory calculatorFactory;
private LuckPermsApiProvider apiProvider;
private EventFactory eventFactory;
@@ -147,7 +145,6 @@ public abstract class AbstractLuckPermsPlugin implements LuckPermsPlugin {
// load internal managers
getLogger().info("Loading internal permission managers...");
this.inheritanceHandler = new InheritanceHandler(this);
this.cachedStateManager = new CachedStateManager();
// setup user/group/track manager
setupManagers();
@@ -314,11 +311,6 @@ public abstract class AbstractLuckPermsPlugin implements LuckPermsPlugin {
return this.inheritanceHandler;
}
@Override
public CachedStateManager getCachedStateManager() {
return this.cachedStateManager;
}
@Override
public PlatformCalculatorFactory getCalculatorFactory() {
return this.calculatorFactory;
common/src/main/java/me/lucko/luckperms/common/plugin/LuckPermsPlugin.java
-8
View File
@@ -29,7 +29,6 @@ import me.lucko.luckperms.api.Contexts;
import me.lucko.luckperms.common.actionlog.LogDispatcher;
import me.lucko.luckperms.common.api.LuckPermsApiProvider;
import me.lucko.luckperms.common.buffers.BufferedRequest;
import me.lucko.luckperms.common.caching.handlers.CachedStateManager;
import me.lucko.luckperms.common.calculators.CalculatorFactory;
import me.lucko.luckperms.common.command.CommandManager;
import me.lucko.luckperms.common.command.abstraction.Command;
@@ -186,13 +185,6 @@ public interface LuckPermsPlugin {
*/
InheritanceHandler getInheritanceHandler();
/**
* Gets the cached state manager for the platform.
*
* @return the cached state manager
*/
CachedStateManager getCachedStateManager();
/**
* Gets the class responsible for constructing PermissionCalculators on this platform.
*
common/src/main/java/me/lucko/luckperms/common/primarygroup/CachedPrimaryGroupHolder.java
+1 -1
View File
@@ -28,7 +28,7 @@ package me.lucko.luckperms.common.primarygroup;
import me.lucko.luckperms.common.buffers.Cache;
import me.lucko.luckperms.common.caching.handlers.StateListener;
import me.lucko.luckperms.common.model.User;
import me.lucko.luckperms.common.node.NodeFactory;
import me.lucko.luckperms.common.node.factory.NodeFactory;
/**
* Abstract implementation of {@link StateListener} which caches all lookups.
common/src/main/java/me/lucko/luckperms/common/primarygroup/ParentsByWeightHolder.java
+1 -1
View File
@@ -47,7 +47,7 @@ public class ParentsByWeightHolder extends CachedPrimaryGroupHolder {
Set<Group> groups = new LinkedHashSet<>();
for (Node node : this.user.getOwnNodes(contexts.getContexts())) {
if (!node.getValuePrimitive() || !node.isGroupNode()) {
if (!node.getValue() || !node.isGroupNode()) {
continue;
}

Some files were not shown because too many files have changed in this diff Show More