Fix no permissions applying when include-global is false, and better support per-server/per-world groups

sponge/src/main/java/me/lucko/luckperms/api/sponge/LuckPermsSubject.java

@@ -35,6 +35,7 @@ import me.lucko.luckperms.exceptions.ObjectAlreadyHasException;
 import me.lucko.luckperms.exceptions.ObjectLacksException;
 import me.lucko.luckperms.groups.Group;
 import me.lucko.luckperms.users.User;
+import me.lucko.luckperms.utils.Contexts;
 import org.spongepowered.api.command.CommandSource;
 import org.spongepowered.api.service.context.Context;
 import org.spongepowered.api.service.permission.Subject;
@@ -203,7 +204,7 @@ public class LuckPermsSubject implements Subject {
         int priority = Integer.MIN_VALUE;
         String meta = null;
 
-        for (Node n : holder.getAllNodes(null)) {
+        for (Node n : holder.getAllNodes(null, Contexts.allowAll())) {
             if (!n.getValue()) {
                 continue;
             }
@@ -343,7 +344,7 @@ public class LuckPermsSubject implements Subject {
         public Map<Set<Context>, List<Subject>> getAllParents() {
             Map<Set<Context>, List<Subject>> parents = new HashMap<>();
 
-            for (Node n : holder.getAllNodes(null)) {
+            for (Node n : holder.getAllNodes(null, Contexts.allowAll())) {
                 if (!n.isGroupNode()) {
                     continue;
                 }
@@ -470,7 +471,7 @@ public class LuckPermsSubject implements Subject {
         public Map<Set<Context>, Map<String, String>> getAllOptions() {
             Map<Set<Context>, Map<String, String>> options = new HashMap<>();
 
-            for (Node n : holder.getAllNodes(null)) {
+            for (Node n : holder.getAllNodes(null, Contexts.allowAll())) {
                 if (!n.isMeta()) {
                     continue;
                 }

sponge/src/main/java/me/lucko/luckperms/users/SpongeUser.java

@@ -27,6 +27,7 @@ import me.lucko.luckperms.api.event.events.UserPermissionRefreshEvent;
 import me.lucko.luckperms.api.implementation.internal.UserLink;
 import me.lucko.luckperms.api.sponge.LuckPermsUserSubject;
 import me.lucko.luckperms.api.sponge.collections.UserCollection;
+import me.lucko.luckperms.utils.Contexts;
 
 import java.util.Collections;
 import java.util.Map;
@@ -46,7 +47,7 @@ class SpongeUser extends User {
     }
 
     @Override
-    public void refreshPermissions() {
+    public synchronized void refreshPermissions() {
         UserCollection uc = plugin.getService().getUserSubjects();
         if (!uc.getUsers().containsKey(getUuid())) {
             return;
@@ -54,11 +55,16 @@ class SpongeUser extends User {
 
         // Calculate the permissions that should be applied. This is done async, who cares about how long it takes or how often it's done.
         Map<String, Boolean> toApply = exportNodes(
-                getPlugin().getConfiguration().getServer(),
-                null, // TODO per world perms
-                null,
-                plugin.getConfiguration().getIncludeGlobalPerms(),
-                true,
+                new Contexts(
+                        plugin.getConfiguration().getServer(),
+                        null, // TODO per world perms
+                        null,
+                        plugin.getConfiguration().getIncludeGlobalPerms(),
+                        plugin.getConfiguration().getIncludeGlobalWorldPerms(),
+                        true,
+                        plugin.getConfiguration().getApplyGlobalGroups(),
+                        plugin.getConfiguration().getApplyGlobalWorldGroups()
+                ),
                 Collections.emptyList()
         );
 

sponge/src/main/resources/luckperms.conf

@@ -8,9 +8,20 @@
 # The name of the server, used for server specific permissions. Set to 'global' to disable.
 server="global"
 
-# If users on this server should have their global permissions/groups applied.
+# If users on this server should have their global permissions applied.
+# If set to false, only server specific permissions will apply for users on this server
 include-global=true
 
+# If users on this server should have their global world permissions applied.
+# If set to false, only world specific permissions will apply for users on this server
+include-global-world=true
+
+# If users on this server should have global (non-server specific) groups applied
+apply-global-groups=true
+
+# If users on this server should have global (non-world specific) groups applied
+apply-global-world-groups=true
+
 # If this server is in offline or online mode.
 # This setting allows a player to have the same UUID across a network of offline mode/mixed servers.