worldofcraft/LuckPerms-DBA
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor the way contexts are cached on all platforms (#1071)

Browse Source 
Should fix memory leak issues on BungeeCord
This commit is contained in:
Luck
2018-06-27 00:17:53 +01:00
Unverified
parent ee13540d78
commit 08454d58d0
15 changed files with 285 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
sponge/sponge-service-api6/src/main/java/me/lucko/luckperms/sponge/service/proxy/api6/SubjectProxy.java
+6 -6
View File
@@ -27,7 +27,7 @@ package me.lucko.luckperms.sponge.service.proxy.api6;
import me.lucko.luckperms.api.context.ImmutableContextSet;
import me.lucko.luckperms.common.contexts.ContextManager;
import me.lucko.luckperms.common.contexts.ContextsCache;
import me.lucko.luckperms.common.contexts.ContextsSupplier;
import me.lucko.luckperms.common.utils.ImmutableCollectors;
import me.lucko.luckperms.sponge.service.CompatibilityUtil;
import me.lucko.luckperms.sponge.service.model.LPPermissionService;
@@ -54,7 +54,7 @@ public final class SubjectProxy implements Subject, ProxiedSubject {
private final LPPermissionService service;
private final LPSubjectReference ref;
private ContextsCache<Subject> contextsCache = null;
private ContextsSupplier contextsSupplier = null;
public SubjectProxy(LPPermissionService service, LPSubjectReference ref) {
this.service = service;
@@ -66,12 +66,12 @@ public final class SubjectProxy implements Subject, ProxiedSubject {
}
// lazy init
private ContextsCache<Subject> getContextsCache() {
if (this.contextsCache == null) {
private ContextsSupplier getContextsCache() {
if (this.contextsSupplier == null) {
ContextManager<Subject> contextManager = (ContextManager<Subject>) this.service.getPlugin().getContextManager();
this.contextsCache = contextManager.getCacheFor(this);
this.contextsSupplier = contextManager.getCacheFor(this);
}
return this.contextsCache;
return this.contextsSupplier;
}
@Nonnull