1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-25 03:09:54 +08:00
Files
osu-lazer/osu.Game/Screens/Edit/Compose/Components
T
Bartłomiej Dach 4dd225fdc8 Fix compose blueprint container not unsubscribing from event
Closes https://github.com/ppy/osu/issues/28938.

This is related to reloading the composer on timing point changes in
scrolling rulesets. The lack of unsubscription from this would cause
blueprints to be created for disposed composers via the
`hitObjectAdded()` flow.

The following line looks as if a sync load should be forced on a newly
created placement blueprint:

    https://github.com/ppy/osu/blob/da4d37c4aded5e10d0a65ff44a08a886e3897e19/osu.Game/Screens/Edit/Compose/Components/ComposeBlueprintContainer.cs#L364

however, it is not the case if the parent
(`placementBlueprintContainer`) is disposed, which it would be in this
case. Therefore, the blueprint stays `NotLoaded` rather than `Ready`,
therefore it never receives its DI dependencies, therefore it dies on
an `EditorBeatmap` nullref.
4dd225fdc8 · 2024-07-19 08:32:36 +02:00
History
..
2023-06-16 16:24:07 +02:00
2024-02-02 21:00:28 +09:00
2024-05-24 18:11:28 +02:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2024-07-03 00:19:04 +09:00
2022-11-27 00:00:27 +09:00