1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-13 08:32:57 +08:00
osu-lazer/osu.Game.Rulesets.Mania/Skinning
Bartłomiej Dach bf0040447c
Fix legacy mania note body animation not resetting sometimes
Hopefully closes https://github.com/ppy/osu/issues/28284.

As far as I can tell this is a somewhat difficult one to reproduce
because it relies on a specific set of circumstances (at least the
reproduction case that I found does). The reset to frame 0 would
previously be called explicitly when `isHitting` changed:

    182ca145c7/osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs (L144)

However, it can be the case that `bodyAnimation` is not loaded at the
point of this call. This is significant because
`SkinnableTextureAnimation` contains this logic:

    182ca145c7/osu.Game/Skinning/LegacySkinExtensions.cs (L192-L211)

which cannot be moved any earlier (because any earlier the `Clock` may
no longer be correct), and also causes the animation to be seeked
forward while it is stopped.

I can't figure out a decent way to layer this otherwise (by scheduling
or whatever), so this commit is just applying the nuclear option of just
seeking back to frame 0 on every update frame in which the body piece is
not being hit.
2024-05-28 15:29:15 +02:00
..
Argon Rename JudgementPiece to TextJudgementPiece 2024-01-25 19:31:57 +09:00
Default Add minor edge smoothing to fix flickering of barlines 2023-09-26 17:06:52 +09:00
Legacy Fix legacy mania note body animation not resetting sometimes 2024-05-28 15:29:15 +02:00
ManiaSkinConfigExtensions.cs Apply nullability to osu!mania skinning classes 2022-11-09 13:58:58 +09:00
ManiaSkinConfigurationLookup.cs Add debug output for skin configuration lookups 2023-09-06 18:03:40 +09:00