mirror of
https://github.com/ppy/osu.git
synced 2026-06-09 20:14:17 +08:00
Bartłomiej Dach
9f5a280bc2
Intends to fix test failures as seen in https://github.com/ppy/osu/actions/runs/6692350567/job/18181352642#step:5:129 This is what happens if you carelessly fire and forget. The working theory (that I'm not sure I have the tools to conclusively confirm) is that the async write from the key binding changing could fire _after_ the section is reset. I briefly considered having the test wait for the change, but given that the entirety of the surrounding flow is using sync operations, this just looks like a bug to me. And there's no real sane way to inject async into that flow due to dependence on `OsuButton.Action`.
9f5a280bc2
·
2023-10-31 12:25:09 +01:00
History