mirror of
https://github.com/ppy/osu.git
synced 2024-12-15 09:42:54 +08:00
3c0b8af8f1
This is more of a safety item. To avoid potential duplicate key in dictionary errors (and also avoid being slightly memory-leaky), allow `SoloStatisticsWatcher` consumers to dispose of the subscriptions they take out.
83 lines
2.8 KiB
C#
83 lines
2.8 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Bindables;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Online.API;
|
|
using osu.Game.Online.API.Requests;
|
|
using osu.Game.Online.Solo;
|
|
using osu.Game.Rulesets;
|
|
using osu.Game.Scoring;
|
|
using osu.Game.Screens.Ranking.Statistics;
|
|
|
|
namespace osu.Game.Screens.Ranking
|
|
{
|
|
public partial class SoloResultsScreen : ResultsScreen
|
|
{
|
|
/// <summary>
|
|
/// Whether the user's personal statistics should be shown on the extended statistics panel
|
|
/// after clicking the score panel associated with the <see cref="ResultsScreen.Score"/> being presented.
|
|
/// </summary>
|
|
public bool ShowUserStatistics { get; init; }
|
|
|
|
private GetScoresRequest? getScoreRequest;
|
|
|
|
[Resolved]
|
|
private RulesetStore rulesets { get; set; } = null!;
|
|
|
|
[Resolved]
|
|
private SoloStatisticsWatcher soloStatisticsWatcher { get; set; } = null!;
|
|
|
|
private IDisposable? statisticsSubscription;
|
|
private readonly Bindable<SoloStatisticsUpdate?> statisticsUpdate = new Bindable<SoloStatisticsUpdate?>();
|
|
|
|
public SoloResultsScreen(ScoreInfo score, bool allowRetry)
|
|
: base(score, allowRetry)
|
|
{
|
|
}
|
|
|
|
protected override void LoadComplete()
|
|
{
|
|
base.LoadComplete();
|
|
|
|
if (ShowUserStatistics)
|
|
statisticsSubscription = soloStatisticsWatcher.RegisterForStatisticsUpdateAfter(Score, update => statisticsUpdate.Value = update);
|
|
}
|
|
|
|
protected override StatisticsPanel CreateStatisticsPanel()
|
|
{
|
|
if (ShowUserStatistics)
|
|
{
|
|
return new SoloStatisticsPanel(Score)
|
|
{
|
|
StatisticsUpdate = { BindTarget = statisticsUpdate }
|
|
};
|
|
}
|
|
|
|
return base.CreateStatisticsPanel();
|
|
}
|
|
|
|
protected override APIRequest? FetchScores(Action<IEnumerable<ScoreInfo>>? scoresCallback)
|
|
{
|
|
if (Score.BeatmapInfo.OnlineID <= 0 || Score.BeatmapInfo.Status <= BeatmapOnlineStatus.Pending)
|
|
return null;
|
|
|
|
getScoreRequest = new GetScoresRequest(Score.BeatmapInfo, Score.Ruleset);
|
|
getScoreRequest.Success += r => scoresCallback?.Invoke(r.Scores.Where(s => s.OnlineID != Score.OnlineID).Select(s => s.ToScoreInfo(rulesets, Beatmap.Value.BeatmapInfo)));
|
|
return getScoreRequest;
|
|
}
|
|
|
|
protected override void Dispose(bool isDisposing)
|
|
{
|
|
base.Dispose(isDisposing);
|
|
|
|
getScoreRequest?.Cancel();
|
|
statisticsSubscription?.Dispose();
|
|
}
|
|
}
|
|
}
|