1
0
mirror of https://github.com/ppy/osu.git synced 2026-06-13 11:14:02 +08:00
Files
osu-lazer/osu.Game/Overlays/BeatmapSet/Info.cs
T
Denis Titovets 7cb786184b Hide user tags section on beatmap overlay if beatmap doesn't have user tags (#37476)
this empty section constantly caught my eye, now it matches web

| master | `osu-web` | PR |
|-|-|-|
| <img width="256" height="322" alt="image"
src="https://github.com/user-attachments/assets/f856498d-6ba1-4390-997d-c5c2bcd6483b"
/> | <img width="196" height="293" alt="image"
src="https://github.com/user-attachments/assets/a517b5c5-8ef1-490d-91ca-e5d76b36e7f1"
/> | <img width="262" height="322" alt="image"
src="https://github.com/user-attachments/assets/f452f601-6223-4f69-8035-4d2ce3dd0839"
/> |
| <img width="272" height="314" alt="image"
src="https://github.com/user-attachments/assets/7486f706-5d18-4841-b8a6-f91ebf631636"
/> | <img width="194" height="238" alt="image"
src="https://github.com/user-attachments/assets/30124fc1-9668-4321-b2d2-0e6ae1699e0f"
/> | <img width="258" height="259" alt="image"
src="https://github.com/user-attachments/assets/3a317f70-bb4a-42ce-9d56-e25c2302800c"
/> |

also slightly reordered some local variables for convenience, can be
reverted if you want to keep previous order
2026-06-09 13:39:19 +02:00

138 lines
6.0 KiB
C#

// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
using System;
using System.Linq;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Shapes;
using osu.Game.Beatmaps;
using osu.Game.Graphics.Containers;
using osu.Game.Online.API.Requests.Responses;
using osu.Game.Overlays.BeatmapListing;
namespace osu.Game.Overlays.BeatmapSet
{
public partial class Info : Container
{
private const float metadata_width = 185;
private const float spacing = 20;
private const float base_height = 300;
private readonly Box successRateBackground;
private readonly Box background;
public readonly Bindable<APIBeatmapSet> BeatmapSet = new Bindable<APIBeatmapSet>();
public readonly Bindable<APIBeatmap> Beatmap = new Bindable<APIBeatmap>();
public Info()
{
MetadataSectionNominators nominators;
MetadataSectionSource source;
MetadataSectionGenre genre;
MetadataSectionLanguage language;
MetadataSectionUserTags userTags;
MetadataSectionMapperTags mapperTags;
SuccessRate successRate;
RelativeSizeAxes = Axes.X;
Height = base_height;
Children = new Drawable[]
{
background = new Box
{
RelativeSizeAxes = Axes.Both
},
new Container
{
RelativeSizeAxes = Axes.Both,
Padding = new MarginPadding { Top = 15, Horizontal = WaveOverlayContainer.HORIZONTAL_PADDING },
Children = new Drawable[]
{
new Container
{
RelativeSizeAxes = Axes.Both,
Padding = new MarginPadding { Right = metadata_width + BeatmapSetOverlay.RIGHT_WIDTH + spacing * 2 },
Child = new Container
{
RelativeSizeAxes = Axes.Both,
Child = new MetadataSectionDescription(),
},
},
new OsuScrollContainer
{
Anchor = Anchor.TopRight,
Origin = Anchor.TopRight,
RelativeSizeAxes = Axes.Y,
Width = metadata_width,
Padding = new MarginPadding { Left = 10 },
Margin = new MarginPadding { Right = BeatmapSetOverlay.RIGHT_WIDTH + spacing },
Masking = true,
ScrollbarOverlapsContent = false,
Child = new FillFlowContainer
{
RelativeSizeAxes = Axes.X,
AutoSizeAxes = Axes.Y,
Direction = FillDirection.Full,
Padding = new MarginPadding { Right = 5 },
Children = new Drawable[]
{
nominators = new MetadataSectionNominators(),
source = new MetadataSectionSource(),
genre = new MetadataSectionGenre { Width = 0.5f },
language = new MetadataSectionLanguage { Width = 0.5f },
userTags = new MetadataSectionUserTags(),
mapperTags = new MetadataSectionMapperTags(),
},
},
},
new Container
{
Anchor = Anchor.TopRight,
Origin = Anchor.TopRight,
RelativeSizeAxes = Axes.Y,
Width = BeatmapSetOverlay.RIGHT_WIDTH,
Children = new Drawable[]
{
successRateBackground = new Box
{
RelativeSizeAxes = Axes.Both,
},
successRate = new SuccessRate
{
RelativeSizeAxes = Axes.Both,
Padding = new MarginPadding { Top = 20, Horizontal = 15 },
},
},
},
},
},
};
BeatmapSet.BindValueChanged(b =>
{
nominators.Metadata = (b.NewValue?.CurrentNominations ?? Array.Empty<BeatmapSetOnlineNomination>(), b.NewValue?.RelatedUsers ?? Array.Empty<APIUser>());
source.Metadata = b.NewValue?.Source ?? string.Empty;
genre.Metadata = b.NewValue?.Genre ?? new BeatmapSetOnlineGenre { Id = (int)SearchGenre.Unspecified };
language.Metadata = b.NewValue?.Language ?? new BeatmapSetOnlineLanguage { Id = (int)SearchLanguage.Unspecified };
mapperTags.Metadata = b.NewValue?.Tags ?? string.Empty;
});
Beatmap.BindValueChanged(b =>
{
userTags.Metadata = b.NewValue?.GetTopUserTags().Select(t => t.Tag.Name).ToArray() ?? Array.Empty<string>();
successRate.Beatmap = b.NewValue;
});
}
[BackgroundDependencyLoader]
private void load(OverlayColourProvider colourProvider)
{
successRateBackground.Colour = colourProvider.Background4;
background.Colour = colourProvider.Background5;
}
}
}