1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 02:03:51 +08:00
osu-lazer/osu.Game/Screens/OnlinePlay/Multiplayer/Participants
Dean Herbert dea7f2308c Fix participant panels potentially keeping a reference to an old user
If a user leave and then rejoins a multiplayer match while another user
is not at the lobby screen, there is a potential the `ParticipantPanel`
tracking the user will not correctly be recreated to reference the new
instance of the `MultiplayerUser`.

This happens because the `OnRoomUpdated` call is scheduled, which means
it is not running in the background, coupled with the local logic that
relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to
a UserID comparison).

Changing this to a reference comparison is the easiest way to resolve
this. Whether we change the `IEquatable` implementation is up for
discussion.

Closes https://github.com/ppy/osu/issues/15970.
2021-12-07 17:24:04 +09:00
..
ParticipantPanel.cs Add null check to resolve inspection 2021-12-04 14:55:35 +01:00
ParticipantsList.cs Fix participant panels potentially keeping a reference to an old user 2021-12-07 17:24:04 +09:00
ParticipantsListHeader.cs Rename multiplayer client classes 2021-05-20 15:39:45 +09:00
StateDisplay.cs Change state icon to binoculars so the eye isn't staring at me 2021-04-08 15:54:58 +09:00
TeamDisplay.cs Fix being able to switch own team by clicking other players' team indicators 2021-11-11 09:01:50 +01:00