mirror of
https://github.com/ppy/osu.git
synced 2024-11-17 10:46:06 +08:00
ffc7eaa3f2
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
51 lines
1.3 KiB
C#
51 lines
1.3 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using osu.Game.Rulesets.Judgements;
|
|
using osu.Game.Rulesets.Objects.Types;
|
|
|
|
namespace osu.Game.Rulesets.Catch.Objects
|
|
{
|
|
public class BananaShower : CatchHitObject, IHasEndTime
|
|
{
|
|
public override FruitVisualRepresentation VisualRepresentation => FruitVisualRepresentation.Banana;
|
|
|
|
public override bool LastInCombo => true;
|
|
|
|
public override Judgement CreateJudgement() => new IgnoreJudgement();
|
|
|
|
protected override void CreateNestedHitObjects()
|
|
{
|
|
base.CreateNestedHitObjects();
|
|
createBananas();
|
|
}
|
|
|
|
private void createBananas()
|
|
{
|
|
double spacing = Duration;
|
|
while (spacing > 100)
|
|
spacing /= 2;
|
|
|
|
if (spacing <= 0)
|
|
return;
|
|
|
|
for (double i = StartTime; i <= EndTime; i += spacing)
|
|
{
|
|
AddNested(new Banana
|
|
{
|
|
Samples = Samples,
|
|
StartTime = i
|
|
});
|
|
}
|
|
}
|
|
|
|
public double EndTime
|
|
{
|
|
get => StartTime + Duration;
|
|
set => Duration = value - StartTime;
|
|
}
|
|
|
|
public double Duration { get; set; }
|
|
}
|
|
}
|