mirror of
https://github.com/ppy/osu.git
synced 2024-12-20 23:02:55 +08:00
5a7d339cc8
Not only does this combine the check into one location, but it also adds a check on the global `WorkingBeatmap` being updated, which is the only way I can see the following failure happening: ```csharp 05:19:07 osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack 05:19:07 Failed TestAddAudioTrack [161 ms] 05:19:07 Error Message: 05:19:07 TearDown : System.NullReferenceException : Object reference not set to an instance of an object. 05:19:07 Stack Trace: 05:19:07 --TearDown 05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36 05:19:07 at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49 05:19:07 at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14 05:19:07 at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46 05:19:07 at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36 05:19:07 at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115 05:19:07 at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101 05:19:07 at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert() 05:19:07 at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered) 05:19:07 at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition) ```
96 lines
4.1 KiB
C#
96 lines
4.1 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
#nullable disable
|
|
|
|
using System.Diagnostics;
|
|
using System.Linq;
|
|
using NUnit.Framework;
|
|
using osu.Framework.Input;
|
|
using osu.Framework.Testing;
|
|
using osu.Framework.Utils;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Rulesets.Osu.Objects;
|
|
using osu.Game.Rulesets.UI;
|
|
using osu.Game.Screens.Edit;
|
|
using osu.Game.Screens.Edit.Compose.Components.Timeline;
|
|
using osu.Game.Screens.Edit.Timing;
|
|
using osu.Game.Tests.Beatmaps;
|
|
using osu.Game.Tests.Visual;
|
|
using osuTK;
|
|
using osuTK.Input;
|
|
|
|
namespace osu.Game.Rulesets.Osu.Tests.Editor
|
|
{
|
|
public class TestSceneSliderVelocityAdjust : OsuGameTestScene
|
|
{
|
|
private Screens.Edit.Editor editor => Game.ScreenStack.CurrentScreen as Screens.Edit.Editor;
|
|
|
|
private EditorBeatmap editorBeatmap => editor.ChildrenOfType<EditorBeatmap>().FirstOrDefault();
|
|
|
|
private EditorClock editorClock => editor.ChildrenOfType<EditorClock>().FirstOrDefault();
|
|
|
|
private Slider slider => editorBeatmap.HitObjects.OfType<Slider>().FirstOrDefault();
|
|
|
|
private TimelineHitObjectBlueprint blueprint => editor.ChildrenOfType<TimelineHitObjectBlueprint>().FirstOrDefault();
|
|
|
|
private DifficultyPointPiece difficultyPointPiece => blueprint.ChildrenOfType<DifficultyPointPiece>().First();
|
|
|
|
private IndeterminateSliderWithTextBoxInput<double> velocityTextBox => Game.ChildrenOfType<DifficultyPointPiece.DifficultyEditPopover>().First().ChildrenOfType<IndeterminateSliderWithTextBoxInput<double>>().First();
|
|
|
|
protected override IBeatmap CreateBeatmap(RulesetInfo ruleset) => new TestBeatmap(ruleset, false);
|
|
|
|
[TestCase(true)]
|
|
[TestCase(false)]
|
|
public void TestVelocityChangeSavesCorrectly(bool adjustVelocity)
|
|
{
|
|
double? velocity = null;
|
|
|
|
AddStep("enter editor", () => Game.ScreenStack.Push(new EditorLoader()));
|
|
AddUntilStep("wait for editor load", () => editor?.ReadyForUse == true);
|
|
|
|
AddStep("seek to first control point", () => editorClock.Seek(editorBeatmap.ControlPointInfo.TimingPoints.First().Time));
|
|
AddStep("enter slider placement mode", () => InputManager.Key(Key.Number3));
|
|
|
|
AddStep("move mouse to centre", () => InputManager.MoveMouseTo(editor.ChildrenOfType<Playfield>().First().ScreenSpaceDrawQuad.Centre));
|
|
AddStep("start placement", () => InputManager.Click(MouseButton.Left));
|
|
|
|
AddStep("move mouse to bottom right", () => InputManager.MoveMouseTo(editor.ChildrenOfType<Playfield>().First().ScreenSpaceDrawQuad.BottomRight - new Vector2(10)));
|
|
AddStep("end placement", () => InputManager.Click(MouseButton.Right));
|
|
|
|
AddStep("exit placement mode", () => InputManager.Key(Key.Number1));
|
|
|
|
AddAssert("slider placed", () => slider != null);
|
|
|
|
AddStep("select slider", () => editorBeatmap.SelectedHitObjects.Add(slider));
|
|
|
|
AddAssert("ensure one slider placed", () => slider != null);
|
|
|
|
AddStep("store velocity", () => velocity = slider.Velocity);
|
|
|
|
if (adjustVelocity)
|
|
{
|
|
AddStep("open velocity adjust panel", () => difficultyPointPiece.TriggerClick());
|
|
AddStep("change velocity", () => velocityTextBox.Current.Value = 2);
|
|
|
|
AddAssert("velocity adjusted", () =>
|
|
{
|
|
Debug.Assert(velocity != null);
|
|
return Precision.AlmostEquals(velocity.Value * 2, slider.Velocity);
|
|
});
|
|
|
|
AddStep("store velocity", () => velocity = slider.Velocity);
|
|
}
|
|
|
|
AddStep("save", () => InputManager.Keys(PlatformAction.Save));
|
|
AddStep("exit", () => InputManager.Key(Key.Escape));
|
|
|
|
AddStep("enter editor (again)", () => Game.ScreenStack.Push(new EditorLoader()));
|
|
AddUntilStep("wait for editor load", () => editor?.ReadyForUse == true);
|
|
|
|
AddStep("seek to slider", () => editorClock.Seek(slider.StartTime));
|
|
AddAssert("slider has correct velocity", () => slider.Velocity == velocity);
|
|
}
|
|
}
|
|
}
|