1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 08:37:24 +08:00
osu-lazer/osu.Game/Online/Chat
Bartłomiej Dach 996ae0ecc1
Fix incorrect handling of StartChatRequest in websocket chat client
Fixes this happening on staging:

	[network] 2024-01-29 17:48:24 [verbose]: WebSocketNotificationsClientConnector connected!
	[network] 2024-01-29 17:48:24 [verbose]: WebSocketNotificationsClientConnector connect attempt failed: Can't use WaitSafely from inside an async operation.

I'm not sure how I ever allowed that `.WaitSafely()` to be there. It
did feel rather dangerous but then I must have forgotten and never
noticed it failing. Which is weird because you'd think that would be
caught by testing that chat isn't working but I'm pretty sure that I
tested that chat *was* indeed working.

Anyway now that entire flow is replaced by something that should
hopefully be somewhat more sane? It has a whole retry flow with logging
now which should be more robust than what was there previously (failing
to start to listen to chat events killing the entire websocket
connection for very little good reason).
2024-01-29 19:22:40 +01:00
..
Channel.cs Fix search being broken in channel listing "channel" 2023-07-09 21:51:08 +02:00
ChannelManager.cs xmldoc everything 2024-01-25 14:47:29 +01:00
ChannelType.cs Remove redundant nullable suppression directives 2023-06-07 08:20:41 +03:00
DrawableLinkCompiler.cs Automated pass 2023-06-24 01:00:03 +09:00
ErrorMessage.cs Automated pass 2023-06-24 01:00:03 +09:00
ExternalLinkOpener.cs Resolve Clipboard via DI 2023-07-11 11:42:31 +02:00
IChannelPostTarget.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IChatClient.cs xmldoc everything 2024-01-25 14:47:29 +01:00
InfoMessage.cs Ensure all LocalMessages get a timestamp 2022-11-30 15:46:36 +09:00
LocalEchoMessage.cs Ensure all LocalMessages get a timestamp 2022-11-30 15:46:36 +09:00
LocalMessage.cs Ensure all LocalMessages get a timestamp 2022-11-30 15:46:36 +09:00
Message.cs Add fallback stable sort to avoid any change of misordered local messages 2022-11-30 16:55:39 +09:00
MessageFormatter.cs Rename to more readable names 2023-12-01 18:35:57 +01:00
MessageNotifier.cs Make highlight messages important in order to trigger window flash 2023-08-22 09:01:32 +02:00
NowPlayingCommand.cs Simplify UserActivity for serialisability over the wire 2023-12-06 18:52:26 +01:00
StandAloneChatDisplay.cs Add ability to easily mention users in chat by right clicking username 2023-01-17 10:01:07 -08:00
WebSocketChatClient.cs Fix incorrect handling of StartChatRequest in websocket chat client 2024-01-29 19:22:40 +01:00