osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-06-02 11:31:02 +08:00

Files

T

Bartłomiej Dach e3eeb761aa Fix client not sending data relevant to replay to spectator server (#37919 )

- Related to https://github.com/ppy/osu/issues/37818, but of no material
help to it at this point (too late for that)

As noted in
https://github.com/ppy/osu/pull/37845#discussion_r3297203361.

Upon comparison of replays recorded by the client and by the server the
affected fields are: total score without mods, and the list of user
pauses. Additionally, the date of setting the score may differ -
server-side it seems to be written with UTC+0 while client-side it's
written using the local timezone offset. Not really interested in fixing
that last issue at this time.

Also included is an intentionally loud disclaimer in
`LegacyScoreEncoder` to tread with caution when treating the class. Not
sure it'll help, and it's a bit late for it as pretty much every single
versioning primitive has been ravaged to the brink of unusability, but
maybe it'll help someone in the future.

This also cleans up an unnecessary nullable on `FrameHeader.Mods` (added
in https://github.com/ppy/osu/pull/30137). This change can be only done
if users on releases earlier than 2024.1023.0 can no longer connect to
spectator server. I leave it to reviewers to determine this as I have no
visibility over current spectator server configuration. Inspecting the
`osu_builds` table may help confirm this. If it provokes unease, I can
back this change out.

e3eeb761aa · 2026-05-26 20:57:58 +09:00

History

Legacy

Fix client not sending data relevant to replay to spectator server (#37919 )

2026-05-26 20:57:58 +09:00

HitResultDisplayStatistic.cs

Automated pass

2023-06-24 01:00:03 +09:00

IScoreInfo.cs

Delete ScoreInfo.HasReplay as no longer needed

2023-10-27 12:39:54 +02:00

LegacyDatabasedScore.cs