mirror of
https://github.com/ppy/osu.git
synced 2024-11-16 10:17:36 +08:00
824e68dab3
This implementation was matching the [framework side implementation of
scale](16d1c2d335/osu.Framework/Graphics/Drawable.cs (L973-L976)
)
but I don't think it's required here.
I'm still not sure if the framework implementation is correct, but
removing it locally does seem to fix broken storyboard cases.
Closes https://github.com/ppy/osu/issues/20155.
116 lines
3.2 KiB
C#
116 lines
3.2 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
#nullable disable
|
|
|
|
using System;
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Graphics;
|
|
using osu.Framework.Graphics.Sprites;
|
|
using osu.Framework.Graphics.Textures;
|
|
using osu.Framework.Utils;
|
|
using osu.Game.Skinning;
|
|
using osuTK;
|
|
|
|
namespace osu.Game.Storyboards.Drawables
|
|
{
|
|
public class DrawableStoryboardSprite : Sprite, IFlippable, IVectorScalable
|
|
{
|
|
public StoryboardSprite Sprite { get; }
|
|
|
|
private bool flipH;
|
|
|
|
public bool FlipH
|
|
{
|
|
get => flipH;
|
|
set
|
|
{
|
|
if (flipH == value)
|
|
return;
|
|
|
|
flipH = value;
|
|
Invalidate(Invalidation.MiscGeometry);
|
|
}
|
|
}
|
|
|
|
private bool flipV;
|
|
|
|
public bool FlipV
|
|
{
|
|
get => flipV;
|
|
set
|
|
{
|
|
if (flipV == value)
|
|
return;
|
|
|
|
flipV = value;
|
|
Invalidate(Invalidation.MiscGeometry);
|
|
}
|
|
}
|
|
|
|
private Vector2 vectorScale = Vector2.One;
|
|
|
|
public Vector2 VectorScale
|
|
{
|
|
get => vectorScale;
|
|
set
|
|
{
|
|
if (vectorScale == value)
|
|
return;
|
|
|
|
if (!Validation.IsFinite(value)) throw new ArgumentException($@"{nameof(VectorScale)} must be finite, but is {value}.");
|
|
|
|
vectorScale = value;
|
|
Invalidate(Invalidation.MiscGeometry);
|
|
}
|
|
}
|
|
|
|
public override bool RemoveWhenNotAlive => false;
|
|
|
|
protected override Vector2 DrawScale
|
|
=> new Vector2(FlipH ? -base.DrawScale.X : base.DrawScale.X, FlipV ? -base.DrawScale.Y : base.DrawScale.Y) * VectorScale;
|
|
|
|
public override Anchor Origin => StoryboardExtensions.AdjustOrigin(base.Origin, VectorScale, FlipH, FlipV);
|
|
|
|
public override bool IsPresent
|
|
=> !float.IsNaN(DrawPosition.X) && !float.IsNaN(DrawPosition.Y) && base.IsPresent;
|
|
|
|
public DrawableStoryboardSprite(StoryboardSprite sprite)
|
|
{
|
|
Sprite = sprite;
|
|
Origin = sprite.Origin;
|
|
Position = sprite.InitialPosition;
|
|
|
|
LifetimeStart = sprite.StartTime;
|
|
LifetimeEnd = sprite.EndTime;
|
|
}
|
|
|
|
[Resolved]
|
|
private ISkinSource skin { get; set; }
|
|
|
|
[BackgroundDependencyLoader]
|
|
private void load(TextureStore textureStore, Storyboard storyboard)
|
|
{
|
|
Texture = storyboard.GetTextureFromPath(Sprite.Path, textureStore);
|
|
|
|
if (Texture == null && storyboard.UseSkinSprites)
|
|
{
|
|
skin.SourceChanged += skinSourceChanged;
|
|
skinSourceChanged();
|
|
}
|
|
|
|
Sprite.ApplyTransforms(this);
|
|
}
|
|
|
|
private void skinSourceChanged() => Texture = skin.GetTexture(Sprite.Path);
|
|
|
|
protected override void Dispose(bool isDisposing)
|
|
{
|
|
base.Dispose(isDisposing);
|
|
|
|
if (skin != null)
|
|
skin.SourceChanged -= skinSourceChanged;
|
|
}
|
|
}
|
|
}
|