mirror of
https://github.com/ppy/osu.git
synced 2025-02-01 07:12:57 +08:00
5a2024777d
No issue thread for this, was pointed out internally: https://discord.com/channels/90072389919997952/1259818301517725707/1316604605777444905 Due to the custom setup that editor has with its nested "screens-that-aren't-screens", the logic that selects the closest timing point to the current time would only fire on the first open of the screen. Seems like a good idea to have it fire every time instead.
85 lines
2.7 KiB
C#
85 lines
2.7 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Bindables;
|
|
using osu.Framework.Graphics;
|
|
using osu.Framework.Graphics.Containers;
|
|
using osu.Game.Beatmaps.ControlPoints;
|
|
using osu.Game.Screens.Edit.Compose.Components.Timeline;
|
|
|
|
namespace osu.Game.Screens.Edit.Timing
|
|
{
|
|
public partial class TimingScreen : EditorScreenWithTimeline
|
|
{
|
|
[Cached]
|
|
public readonly Bindable<ControlPointGroup> SelectedGroup = new Bindable<ControlPointGroup>();
|
|
|
|
private readonly Bindable<EditorScreenMode> currentEditorMode = new Bindable<EditorScreenMode>();
|
|
|
|
[Resolved]
|
|
private EditorClock? editorClock { get; set; }
|
|
|
|
public TimingScreen()
|
|
: base(EditorScreenMode.Timing)
|
|
{
|
|
}
|
|
|
|
protected override Drawable CreateMainContent() => new GridContainer
|
|
{
|
|
RelativeSizeAxes = Axes.Both,
|
|
ColumnDimensions = new[]
|
|
{
|
|
new Dimension(),
|
|
new Dimension(GridSizeMode.Absolute, 350),
|
|
},
|
|
Content = new[]
|
|
{
|
|
new Drawable[]
|
|
{
|
|
new ControlPointList(),
|
|
new ControlPointSettings(),
|
|
},
|
|
}
|
|
};
|
|
|
|
[BackgroundDependencyLoader]
|
|
private void load(Editor? editor)
|
|
{
|
|
if (editor != null)
|
|
currentEditorMode.BindTo(editor.Mode);
|
|
}
|
|
|
|
protected override void LoadComplete()
|
|
{
|
|
base.LoadComplete();
|
|
|
|
// When entering the timing screen, let's choose the closest valid timing point.
|
|
// This will emulate the osu-stable behaviour where a metronome and timing information
|
|
// are presented on entering the screen.
|
|
currentEditorMode.BindValueChanged(mode =>
|
|
{
|
|
if (mode.NewValue == EditorScreenMode.Timing)
|
|
selectClosestTimingPoint();
|
|
});
|
|
selectClosestTimingPoint();
|
|
}
|
|
|
|
private void selectClosestTimingPoint()
|
|
{
|
|
if (editorClock == null)
|
|
return;
|
|
|
|
var nearestTimingPoint = EditorBeatmap.ControlPointInfo.TimingPointAt(editorClock.CurrentTime);
|
|
SelectedGroup.Value = EditorBeatmap.ControlPointInfo.GroupAt(nearestTimingPoint.Time);
|
|
}
|
|
|
|
protected override void ConfigureTimeline(TimelineArea timelineArea)
|
|
{
|
|
base.ConfigureTimeline(timelineArea);
|
|
|
|
timelineArea.Timeline.AlwaysShowControlPoints = true;
|
|
}
|
|
}
|
|
}
|