mirror of
https://github.com/ppy/osu.git
synced 2024-12-18 04:33:22 +08:00
fae6dcfffa
This is the secondary cause of https://github.com/ppy/osu/issues/28577, because you could do the following: - Have a break autogenerate itself - Adjust either end of it to make it mark itself as manually-adjusted - Remove all objects before or after said break to end up in a state wherein there are no objects before or after a break. The direct fix is still correct because it is still technically possible to end up in a state wherein a break is before or after all objects (obvious one is manual `.osu` editing), but this behaviour is also undesirable for the autogeneration logic.
75 lines
2.6 KiB
C#
75 lines
2.6 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Linq;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Beatmaps.Timing;
|
|
using osu.Game.Rulesets;
|
|
using osu.Game.Rulesets.Objects;
|
|
|
|
namespace osu.Game.Screens.Edit
|
|
{
|
|
public class EditorBeatmapProcessor : IBeatmapProcessor
|
|
{
|
|
public IBeatmap Beatmap { get; }
|
|
|
|
private readonly IBeatmapProcessor? rulesetBeatmapProcessor;
|
|
|
|
public EditorBeatmapProcessor(IBeatmap beatmap, Ruleset ruleset)
|
|
{
|
|
Beatmap = beatmap;
|
|
rulesetBeatmapProcessor = ruleset.CreateBeatmapProcessor(beatmap);
|
|
}
|
|
|
|
public void PreProcess()
|
|
{
|
|
rulesetBeatmapProcessor?.PreProcess();
|
|
}
|
|
|
|
public void PostProcess()
|
|
{
|
|
rulesetBeatmapProcessor?.PostProcess();
|
|
|
|
autoGenerateBreaks();
|
|
}
|
|
|
|
private void autoGenerateBreaks()
|
|
{
|
|
Beatmap.Breaks.RemoveAll(b => b is not ManualBreakPeriod);
|
|
|
|
foreach (var manualBreak in Beatmap.Breaks.ToList())
|
|
{
|
|
if (manualBreak.EndTime <= Beatmap.HitObjects.FirstOrDefault()?.StartTime
|
|
|| manualBreak.StartTime >= Beatmap.HitObjects.LastOrDefault()?.GetEndTime()
|
|
|| Beatmap.HitObjects.Any(ho => ho.StartTime <= manualBreak.EndTime && ho.GetEndTime() >= manualBreak.StartTime))
|
|
{
|
|
Beatmap.Breaks.Remove(manualBreak);
|
|
}
|
|
}
|
|
|
|
for (int i = 1; i < Beatmap.HitObjects.Count; ++i)
|
|
{
|
|
double previousObjectEndTime = Beatmap.HitObjects[i - 1].GetEndTime();
|
|
double nextObjectStartTime = Beatmap.HitObjects[i].StartTime;
|
|
|
|
if (nextObjectStartTime - previousObjectEndTime < BreakPeriod.MIN_GAP_DURATION)
|
|
continue;
|
|
|
|
double breakStartTime = previousObjectEndTime + BreakPeriod.GAP_BEFORE_BREAK;
|
|
double breakEndTime = nextObjectStartTime - Math.Max(BreakPeriod.GAP_AFTER_BREAK, Beatmap.ControlPointInfo.TimingPointAt(nextObjectStartTime).BeatLength * 2);
|
|
|
|
if (breakEndTime - breakStartTime < BreakPeriod.MIN_BREAK_DURATION)
|
|
continue;
|
|
|
|
var breakPeriod = new BreakPeriod(breakStartTime, breakEndTime);
|
|
|
|
if (Beatmap.Breaks.Any(b => b.Intersects(breakPeriod)))
|
|
continue;
|
|
|
|
Beatmap.Breaks.Add(breakPeriod);
|
|
}
|
|
}
|
|
}
|
|
}
|