mirror of
https://github.com/ppy/osu.git
synced 2024-12-16 08:22:56 +08:00
8c3955d341
Finishing an operation started via `OngoingOperationTracker.BeginOperation()` was risky in cases where the operation ended at a callback on another thread (which, in the case of multiplayer, is *most* cases). In particular, if any consumer registered a callback that mutates transforms when the operation ends, it would result in crashes after the framework-side safety checks. Rework `OngoingOperationTracker` into an always-present component residing in the drawable hierarchy, and ensure that the `operationInProgress` bindable is always updated on the update thread. This way consumers don't have to add local schedules in multiple places.
51 lines
1.6 KiB
C#
51 lines
1.6 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using NUnit.Framework;
|
|
using osu.Framework.Graphics;
|
|
using osu.Game.Screens.OnlinePlay.Multiplayer;
|
|
|
|
namespace osu.Game.Tests.Visual.Multiplayer
|
|
{
|
|
public class TestSceneCreateMultiplayerMatchButton : MultiplayerTestScene
|
|
{
|
|
private CreateMultiplayerMatchButton button;
|
|
|
|
public override void SetUpSteps()
|
|
{
|
|
base.SetUpSteps();
|
|
AddStep("create button", () => Child = button = new CreateMultiplayerMatchButton
|
|
{
|
|
Width = 200,
|
|
Height = 100,
|
|
Anchor = Anchor.Centre,
|
|
Origin = Anchor.Centre
|
|
});
|
|
}
|
|
|
|
[Test]
|
|
public void TestButtonEnableStateChanges()
|
|
{
|
|
IDisposable joiningRoomOperation = null;
|
|
|
|
assertButtonEnableState(true);
|
|
|
|
AddStep("begin joining room", () => joiningRoomOperation = OngoingOperationTracker.BeginOperation());
|
|
assertButtonEnableState(false);
|
|
|
|
AddStep("end joining room", () => joiningRoomOperation.Dispose());
|
|
assertButtonEnableState(true);
|
|
|
|
AddStep("disconnect client", () => Client.Disconnect());
|
|
assertButtonEnableState(false);
|
|
|
|
AddStep("re-connect client", () => Client.Connect());
|
|
assertButtonEnableState(true);
|
|
}
|
|
|
|
private void assertButtonEnableState(bool enabled)
|
|
=> AddAssert($"button {(enabled ? "enabled" : "disabled")}", () => button.Enabled.Value == enabled);
|
|
}
|
|
}
|