osu-lazer

mirror of https://github.com/ppy/osu.git synced 2026-06-07 06:23:39 +08:00

Files

T

Bartłomiej Dach a29a5ab7e6 Allow NumberFormattingExtensions.ToStandardFormattedString() to accept culture

I had previously made it invariant in
https://github.com/ppy/osu/pull/32837, and in another instance of past
me being an asshole, I can't actually find the reasoning for this at
this time.

That said, you'd be excused for thinking "why does this matter"? Well,
this will fix https://github.com/ppy/osu/issues/35381, because that
failure only occurs when the user's culture is set to one that doesn't
use a decimal point (.) but rather a decimal comma (,). This messes with
framework, which uses the *current* culture to check for decimal
separator rather than invariant:

https://github.com/ppy/osu-framework/blob/d3226a7842487de43a0d989e1bb59a9ebbc479af/osu.Framework/Graphics/UserInterface/TextBox.cs#L106-L111

An alternative would be to change framework instead to always accept the
invariant decimal separator.

God I hate this culture crap.

a29a5ab7e6 · 2025-10-22 10:31:12 +02:00

History

CollectionExtensions.cs

Remove the nullable disable annotation.

2022-06-30 23:20:40 +08:00

DrawableExtensions.cs

Bypass Parent nullability checks for now

2023-10-17 17:48:45 +09:00

LanguageExtensions.cs

Handle culture code differences of Traditional Chinese

2023-06-08 03:27:05 +03:00

ModelExtensions.cs