1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 11:07:52 +08:00
osu-lazer/osu.Game.Rulesets.Mania
Dean Herbert 57723107dd Fix osu!mania hold notes occasionally getting in a visually incorrect hit state
To correctly end a mania hold note, `endHold()` needs to be called. This
was not happening in a very specific scenario:

- The hold note's head is not hit
- The user pressed the column's key within the hold note's tail's window,
  but does so to hit the next object (a note in proximity to the hold note's tail).
- The hit policy forces a miss on the hold note, but `endHold()` is not called
- `CheckForResult` is not called after this point due to `Judged` being `true`.

Closes #21311.
2022-11-22 16:15:34 +09:00
..
Beatmaps Add method to get stage from column index 2022-10-07 15:24:37 +09:00
Configuration Fix nullability oversight in ManiaRulesetConfigManager 2022-09-12 16:58:20 +09:00
Difficulty Remove whitespace 2022-10-11 13:53:18 +09:00
Edit Avoid casting by accepting all Playfields but throwing on a bad choice 2022-10-11 16:54:41 +09:00
Judgements Automated #nullable processing 2022-06-17 16:37:17 +09:00
MathUtils Automated #nullable processing 2022-06-17 16:37:17 +09:00
Mods Adjust target and hold off mod multipliers 2022-11-01 17:57:20 +09:00
Objects Fix osu!mania hold notes occasionally getting in a visually incorrect hit state 2022-11-22 16:15:34 +09:00
Properties Automated #nullable processing 2022-06-17 16:37:17 +09:00
Replays Use AsNonNull() instead. 2022-07-02 19:48:32 +08:00
Resources/Testing/Beatmaps Add test ensuring converter doesn't modify original beatmap 2021-09-10 00:00:12 +09:00
Scoring Automated #nullable processing 2022-06-17 16:37:17 +09:00
Skinning Realign white line on argon hold note ends to match hit target 2022-11-21 18:26:53 +09:00
UI Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
DualStageVariantGenerator.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
ManiaFilterCriteria.cs Remove the nullable disable annotation in the mania ruleset. 2022-07-03 21:04:39 +08:00
ManiaInputManager.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
ManiaRuleset.cs Add method to get stage from column index 2022-10-07 15:24:37 +09:00
ManiaSettingsSubsection.cs new display format 2022-09-08 19:12:54 +08:00
ManiaSkinComponentLookup.cs Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
osu.Game.Rulesets.Mania.csproj Adjust package titles 2021-01-18 11:08:03 +09:00
SingleStageVariantGenerator.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
VariantMappingGenerator.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00