1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 06:03:08 +08:00
osu-lazer/osu.Game/Rulesets/Objects
Bartłomiej Dach 7a25fe79b7
Fix sample control point time being calculated before defaults applied
In editor contexts, the `StartTimeBindable` subscription in `HitObject`
was firing before defaults were applied, which in the case of sliders
manifested in an infinite end time. `ApplyDefaults()` also did not
always set the time of the control point to the correct value, which
matters when the beatmap is encoded.

Ensure that the control points receive the correct time values during
default application, and only register the `StartTimeBindable` change
callback after defaults have been successfully applied.
2022-01-11 21:38:59 +01:00
..
Drawables Code refactor and name changes 2021-12-17 13:16:06 +01:00
Legacy Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
Pooling Add xmldoc remark 2021-06-18 19:27:10 +09:00
Types Change IHasRepeats.NodeSamples to IList from List 2021-10-23 01:59:07 -07:00
BarLineGenerator.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
HitObject.cs Fix sample control point time being calculated before defaults applied 2022-01-11 21:38:59 +01:00
HitObjectLifetimeEntry.cs Make method internal 2021-06-02 11:11:41 +09:00
HitObjectParser.cs Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
IBarLine.cs Decouple bar line hitobjects from generator 2019-09-25 00:36:27 +02:00
PathControlPoint.cs Remove bindable usage in PathControlPoint 2021-08-26 12:33:53 +09:00
SliderEventGenerator.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
SliderPath.cs Fix most open compound words in identifiers being closed 2021-12-27 20:26:28 -08:00
SliderPathExtensions.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
SyntheticHitObjectEntry.cs Revert "Fix wrong InitialLifetimeOffset is used for a non-pooled DHO." 2021-04-21 10:02:50 +09:00