mirror of
https://github.com/ppy/osu.git
synced 2024-12-15 05:42:56 +08:00
ffc7eaa3f2
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
30 lines
1.0 KiB
C#
30 lines
1.0 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using osu.Framework.Bindables;
|
|
using osu.Game.Rulesets.Judgements;
|
|
using osu.Game.Rulesets.Objects;
|
|
using osu.Game.Rulesets.Scoring;
|
|
|
|
namespace osu.Game.Rulesets.Osu.Objects
|
|
{
|
|
/// <summary>
|
|
/// Note that this should not be used for timing correctness.
|
|
/// See <see cref="SliderEventType.LegacyLastTick"/> usage in <see cref="Slider"/> for more information.
|
|
/// </summary>
|
|
public class SliderTailCircle : SliderCircle
|
|
{
|
|
private readonly IBindable<int> pathVersion = new Bindable<int>();
|
|
|
|
public SliderTailCircle(Slider slider)
|
|
{
|
|
pathVersion.BindTo(slider.Path.Version);
|
|
pathVersion.BindValueChanged(_ => Position = slider.EndPosition);
|
|
}
|
|
|
|
public override Judgement CreateJudgement() => new IgnoreJudgement();
|
|
|
|
protected override HitWindows CreateHitWindows() => HitWindows.Empty;
|
|
}
|
|
}
|