1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-15 14:43:02 +08:00
osu-lazer/osu.Game.Rulesets.Mania/Objects/Drawables
Bartłomiej Dach 9a330c4c56 Fix mania hold note heads hiding when frozen
This was an insidious regression from a3dc1d5. Prior to that commit,
`DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set
the hold note head's lifetime. When that method was split into
`UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the
lifetime set was moved to the former.

Unfortunately, that override served two purposes: both to set the
lifetime, and to suppress hit animations which would normally be added
by the base `DrawableManiaHitObject`. That fact being missed led to
`UpdateHitStateTransforms()` hiding the hold note head immediately on
hit and with a slight delay on miss.

To resolve, explicitly override `UpdateHitStateTransforms()` and
suppress the base call, with an explanatory comment.
2021-03-21 18:46:41 +01:00
..
DrawableBarLine.cs Update existing implementations 2020-11-04 17:14:23 +09:00
DrawableHoldNote.cs Adjust namespace 2020-12-07 12:32:52 +09:00
DrawableHoldNoteHead.cs Fix mania hold note heads hiding when frozen 2021-03-21 18:46:41 +01:00
DrawableHoldNoteTail.cs Add MaximumJudgementOffset to DrawableHitObject, use in more places 2020-11-26 01:12:42 +09:00
DrawableHoldNoteTick.cs Fix hold note judgements displaying incorrectly 2020-11-17 13:37:58 +09:00
DrawableManiaHitObject.cs Update existing implementations 2020-11-04 17:14:23 +09:00
DrawableNote.cs Adjust namespace 2020-12-07 12:32:52 +09:00