mirror of
https://github.com/ppy/osu.git
synced 2024-11-13 20:47:26 +08:00
3006bae0d8
This is the first half of a change that *may* fix https://github.com/ppy/osu/issues/26338 (it definitely fixes *one case* where the issue happens, but I'm not sure if it will cover all of them). As described in the issue thread, using the `jti` claim from the JWT used for authorisation seemed like a decent idea. However, upon closer inspection the scheme falls over badly in a specific scenario where: 1. A client instance connects to spectator server using JWT A. 2. At some point, JWT A expires, and is silently rotated by the game in exchange for JWT B. The spectator server knows nothing of this, and continues to only track JWT A, including the old `jti` claim in said JWT. 3. At some later point, the client's connection to one of the spectator server hubs drops out. A reconnection is automatically attempted, *but* it is attempted using JWT B. The spectator server was not aware of JWT B until now, and said JWT has a different `jti` claim than the old one, so to the spectator server, it looks like a completely different client connecting, which boots the user out of their account. This PR adds a per-session GUID which is sent in a HTTP header on every connection attempt to spectator server. This GUID will be used instead of the `jti` claim in JWTs as a persistent identifier of a single user's single lazer session, which bypasses the failure scenario described above. I don't think any stronger primitive than this is required. As far as I can tell this is as strong a protection as the JWT was (which is to say, not *very* strong), and doing this removes a lot of weird complexity that would be otherwise incurred by attempting to have client ferry all of its newly issued JWTs to the server so that it can be aware of them.
234 lines
7.8 KiB
C#
234 lines
7.8 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using osu.Framework.Bindables;
|
|
using osu.Framework.Graphics;
|
|
using osu.Game.Localisation;
|
|
using osu.Game.Online.API.Requests;
|
|
using osu.Game.Online.API.Requests.Responses;
|
|
using osu.Game.Online.Chat;
|
|
using osu.Game.Online.Notifications.WebSocket;
|
|
using osu.Game.Tests;
|
|
using osu.Game.Users;
|
|
|
|
namespace osu.Game.Online.API
|
|
{
|
|
public partial class DummyAPIAccess : Component, IAPIProvider
|
|
{
|
|
public const int DUMMY_USER_ID = 1001;
|
|
|
|
public Bindable<APIUser> LocalUser { get; } = new Bindable<APIUser>(new APIUser
|
|
{
|
|
Username = @"Local user",
|
|
Id = DUMMY_USER_ID,
|
|
});
|
|
|
|
public BindableList<APIUser> Friends { get; } = new BindableList<APIUser>();
|
|
|
|
public Bindable<UserActivity> Activity { get; } = new Bindable<UserActivity>();
|
|
|
|
public Bindable<UserStatistics?> Statistics { get; } = new Bindable<UserStatistics?>();
|
|
|
|
public DummyNotificationsClient NotificationsClient { get; } = new DummyNotificationsClient();
|
|
INotificationsClient IAPIProvider.NotificationsClient => NotificationsClient;
|
|
|
|
public Language Language => Language.en;
|
|
|
|
public string AccessToken => "token";
|
|
|
|
public Guid SessionIdentifier { get; } = Guid.NewGuid();
|
|
|
|
/// <seealso cref="APIAccess.IsLoggedIn"/>
|
|
public bool IsLoggedIn => State.Value > APIState.Offline;
|
|
|
|
public string ProvidedUsername => LocalUser.Value.Username;
|
|
|
|
public string APIEndpointUrl => "http://localhost";
|
|
|
|
public string WebsiteRootUrl => "http://localhost";
|
|
|
|
public int APIVersion => int.Parse(DateTime.Now.ToString("yyyyMMdd"));
|
|
|
|
public Exception? LastLoginError { get; private set; }
|
|
|
|
/// <summary>
|
|
/// Provide handling logic for an arbitrary API request.
|
|
/// Should return true is a request was handled. If null or false return, the request will be failed with a <see cref="NotSupportedException"/>.
|
|
/// </summary>
|
|
public Func<APIRequest, bool>? HandleRequest;
|
|
|
|
private readonly Bindable<APIState> state = new Bindable<APIState>(APIState.Online);
|
|
|
|
private bool shouldFailNextLogin;
|
|
private bool stayConnectingNextLogin;
|
|
private bool requiredSecondFactorAuth = true;
|
|
|
|
/// <summary>
|
|
/// The current connectivity state of the API.
|
|
/// </summary>
|
|
public IBindable<APIState> State => state;
|
|
|
|
public DummyAPIAccess()
|
|
{
|
|
LocalUser.BindValueChanged(u =>
|
|
{
|
|
u.OldValue?.Activity.UnbindFrom(Activity);
|
|
u.NewValue.Activity.BindTo(Activity);
|
|
}, true);
|
|
}
|
|
|
|
public virtual void Queue(APIRequest request)
|
|
{
|
|
Schedule(() =>
|
|
{
|
|
if (HandleRequest?.Invoke(request) != true)
|
|
{
|
|
// Noisy so let's silently allow these to succeed.
|
|
if (request is ChatAckRequest ack)
|
|
{
|
|
ack.TriggerSuccess(new ChatAckResponse());
|
|
return;
|
|
}
|
|
|
|
request.Fail(new InvalidOperationException($@"{nameof(DummyAPIAccess)} cannot process this request."));
|
|
}
|
|
});
|
|
}
|
|
|
|
public void Perform(APIRequest request) => HandleRequest?.Invoke(request);
|
|
|
|
public Task PerformAsync(APIRequest request)
|
|
{
|
|
HandleRequest?.Invoke(request);
|
|
return Task.CompletedTask;
|
|
}
|
|
|
|
public void Login(string username, string password)
|
|
{
|
|
state.Value = APIState.Connecting;
|
|
|
|
if (stayConnectingNextLogin)
|
|
{
|
|
stayConnectingNextLogin = false;
|
|
return;
|
|
}
|
|
|
|
if (shouldFailNextLogin)
|
|
{
|
|
LastLoginError = new APIException("Not powerful enough to login.", new ArgumentException(nameof(shouldFailNextLogin)));
|
|
|
|
state.Value = APIState.Offline;
|
|
shouldFailNextLogin = false;
|
|
return;
|
|
}
|
|
|
|
LastLoginError = null;
|
|
LocalUser.Value = new APIUser
|
|
{
|
|
Username = username,
|
|
Id = DUMMY_USER_ID,
|
|
};
|
|
|
|
if (requiredSecondFactorAuth)
|
|
{
|
|
state.Value = APIState.RequiresSecondFactorAuth;
|
|
}
|
|
else
|
|
{
|
|
onSuccessfulLogin();
|
|
requiredSecondFactorAuth = true;
|
|
}
|
|
}
|
|
|
|
public void AuthenticateSecondFactor(string code)
|
|
{
|
|
var request = new VerifySessionRequest(code);
|
|
request.Failure += e =>
|
|
{
|
|
state.Value = APIState.RequiresSecondFactorAuth;
|
|
LastLoginError = e;
|
|
};
|
|
|
|
state.Value = APIState.Connecting;
|
|
LastLoginError = null;
|
|
|
|
// if no handler installed / handler can't handle verification, just assume that the server would verify for simplicity.
|
|
if (HandleRequest?.Invoke(request) != true)
|
|
onSuccessfulLogin();
|
|
|
|
// if a handler did handle this, make sure the verification actually passed.
|
|
if (request.CompletionState == APIRequestCompletionState.Completed)
|
|
onSuccessfulLogin();
|
|
}
|
|
|
|
private void onSuccessfulLogin()
|
|
{
|
|
state.Value = APIState.Online;
|
|
Statistics.Value = new UserStatistics
|
|
{
|
|
GlobalRank = 1,
|
|
CountryRank = 1
|
|
};
|
|
}
|
|
|
|
public void Logout()
|
|
{
|
|
state.Value = APIState.Offline;
|
|
// must happen after `state.Value` is changed such that subscribers to that bindable's value changes see the correct user.
|
|
// compare: `APIAccess.Logout()`.
|
|
LocalUser.Value = new GuestUser();
|
|
}
|
|
|
|
public void UpdateStatistics(UserStatistics newStatistics)
|
|
{
|
|
Statistics.Value = newStatistics;
|
|
|
|
if (IsLoggedIn)
|
|
LocalUser.Value.Statistics = newStatistics;
|
|
}
|
|
|
|
public IHubClientConnector? GetHubConnector(string clientName, string endpoint, bool preferMessagePack) => null;
|
|
|
|
public IChatClient GetChatClient() => new TestChatClientConnector(this);
|
|
|
|
public RegistrationRequest.RegistrationRequestErrors? CreateAccount(string email, string username, string password)
|
|
{
|
|
Thread.Sleep(200);
|
|
return null;
|
|
}
|
|
|
|
public void SetState(APIState newState) => state.Value = newState;
|
|
|
|
IBindable<APIUser> IAPIProvider.LocalUser => LocalUser;
|
|
IBindableList<APIUser> IAPIProvider.Friends => Friends;
|
|
IBindable<UserActivity> IAPIProvider.Activity => Activity;
|
|
IBindable<UserStatistics?> IAPIProvider.Statistics => Statistics;
|
|
|
|
/// <summary>
|
|
/// Skip 2FA requirement for next login.
|
|
/// </summary>
|
|
public void SkipSecondFactor() => requiredSecondFactorAuth = false;
|
|
|
|
/// <summary>
|
|
/// During the next simulated login, the process will fail immediately.
|
|
/// </summary>
|
|
public void FailNextLogin() => shouldFailNextLogin = true;
|
|
|
|
/// <summary>
|
|
/// During the next simulated login, the process will pause indefinitely at "connecting".
|
|
/// </summary>
|
|
public void PauseOnConnectingNextLogin() => stayConnectingNextLogin = true;
|
|
|
|
protected override void Dispose(bool isDisposing)
|
|
{
|
|
base.Dispose(isDisposing);
|
|
|
|
// Ensure (as much as we can) that any pending tasks are run.
|
|
Scheduler.Update();
|
|
}
|
|
}
|
|
}
|