mirror of
https://github.com/ppy/osu.git
synced 2024-12-25 03:22:57 +08:00
c32d99250f
This removes the corrupt file check from CheckTooShortAudioFiles and makes the audio formats checks deal with it instead to avoid redundant messages.
64 lines
2.4 KiB
C#
64 lines
2.4 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System.Collections.Generic;
|
|
using System.IO;
|
|
using ManagedBass;
|
|
using osu.Framework.Audio.Callbacks;
|
|
using osu.Game.Extensions;
|
|
using osu.Game.Rulesets.Edit.Checks.Components;
|
|
|
|
namespace osu.Game.Rulesets.Edit.Checks
|
|
{
|
|
public class CheckTooShortAudioFiles : ICheck
|
|
{
|
|
private const int ms_threshold = 25;
|
|
|
|
public CheckMetadata Metadata => new CheckMetadata(CheckCategory.Audio, "Too short audio files");
|
|
|
|
public IEnumerable<IssueTemplate> PossibleTemplates => new IssueTemplate[]
|
|
{
|
|
new IssueTemplateTooShort(this),
|
|
};
|
|
|
|
public IEnumerable<Issue> Run(BeatmapVerifierContext context)
|
|
{
|
|
var beatmapSet = context.Beatmap.BeatmapInfo.BeatmapSet;
|
|
|
|
if (beatmapSet != null)
|
|
{
|
|
foreach (var file in beatmapSet.Files)
|
|
{
|
|
using (Stream data = context.WorkingBeatmap.GetStream(file.File.GetStoragePath()))
|
|
{
|
|
if (data == null)
|
|
continue;
|
|
|
|
var fileCallbacks = new FileCallbacks(new DataStreamFileProcedures(data));
|
|
int decodeStream = Bass.CreateStream(StreamSystem.NoBuffer, BassFlags.Decode | BassFlags.Prescan, fileCallbacks.Callbacks, fileCallbacks.Handle);
|
|
|
|
if (decodeStream == 0) continue;
|
|
|
|
long length = Bass.ChannelGetLength(decodeStream);
|
|
double ms = Bass.ChannelBytes2Seconds(decodeStream, length) * 1000;
|
|
|
|
// Extremely short audio files do not play on some soundcards, resulting in nothing being heard in-game for some users.
|
|
if (ms > 0 && ms < ms_threshold)
|
|
yield return new IssueTemplateTooShort(this).Create(file.Filename, ms);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public class IssueTemplateTooShort : IssueTemplate
|
|
{
|
|
public IssueTemplateTooShort(ICheck check)
|
|
: base(check, IssueType.Problem, "\"{0}\" is too short ({1:0} ms), should be at least {2:0} ms.")
|
|
{
|
|
}
|
|
|
|
public Issue Create(string filename, double ms) => new Issue(this, filename, ms, ms_threshold);
|
|
}
|
|
}
|
|
}
|