1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 23:12:56 +08:00
osu-lazer/osu.Game/Online/Notifications/WebSocket
Bartłomiej Dach 4126dcbe28
Fix 2FA verification via link not working correctly
Closes https://github.com/ppy/osu/issues/26835.

I must have not re-tested this correctly after all the refactors...

Basically the issue is that the websocket connection would only come
online when the API state changed to full `Online`. In particular
the connector would not attempt to connect when the API state was
`RequiresSecondFactorAuth`, giving the link-based flow no chance to
actually work.

The change in `WebSocketNotificationsClientConnector` is relevant in
that queueing requests does nothing before the API state changes to full
`Online`. It also cleans up things a bit code-wise so... win?

And yes, this means that the _other_ `PersistentEndpointClientConnector`
implementations (i.e. SignalR connectors) will also come online earlier
after this. Based on previous discussions
(https://github.com/ppy/osu/pull/25480#discussion_r1395566545) I think
this is fine, but if it is _not_ fine, then it can be fixed by exposing
a virtual that lets a connector to decide when to come alive, I guess.
2024-01-30 21:49:06 +01:00
..
DummyNotificationsClient.cs Decouple notifications websocket handling from chat operations 2024-01-25 14:47:29 +01:00
EndChatRequest.cs Generalise + add polling-style for usage in tests 2022-10-28 17:53:28 +09:00
INotificationsClient.cs xmldoc everything 2024-01-25 14:47:29 +01:00
NewChatMessageData.cs Generalise + add polling-style for usage in tests 2022-10-28 17:53:28 +09:00
SocketMessage.cs Generalise + add polling-style for usage in tests 2022-10-28 17:53:28 +09:00
StartChatRequest.cs Generalise + add polling-style for usage in tests 2022-10-28 17:53:28 +09:00
WebSocketNotificationsClient.cs Decouple notifications websocket handling from chat operations 2024-01-25 14:47:29 +01:00
WebSocketNotificationsClientConnector.cs Fix 2FA verification via link not working correctly 2024-01-30 21:49:06 +01:00