1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 20:07:25 +08:00
osu-lazer/osu.Game.Rulesets.Mania/Objects
Bartłomiej Dach 9a330c4c56 Fix mania hold note heads hiding when frozen
This was an insidious regression from a3dc1d5. Prior to that commit,
`DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set
the hold note head's lifetime. When that method was split into
`UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the
lifetime set was moved to the former.

Unfortunately, that override served two purposes: both to set the
lifetime, and to suppress hit animations which would normally be added
by the base `DrawableManiaHitObject`. That fact being missed led to
`UpdateHitStateTransforms()` hiding the hold note head immediately on
hit and with a slight delay on miss.

To resolve, explicitly override `UpdateHitStateTransforms()` and
suppress the base call, with an explanatory comment.
2021-03-21 18:46:41 +01:00
..
Drawables Fix mania hold note heads hiding when frozen 2021-03-21 18:46:41 +01:00
Types Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
BarLine.cs Fix hitobjects with unknown lifetimes by enforcing non-null judgement 2020-02-23 13:49:06 +09:00
HoldNote.cs Implement mania invert mod 2020-08-18 01:40:55 +09:00
HoldNoteTick.cs Use empty hitwindows instead of null 2019-10-09 19:08:31 +09:00
ManiaHitObject.cs Implement IHasXPosition on ManiaHitObject 2020-04-22 09:06:04 +09:00
Note.cs Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
TailNote.cs Update licence header (and remove year) 2019-01-24 17:43:03 +09:00