mirror of
https://github.com/ppy/osu.git
synced 2026-06-08 06:23:39 +08:00
18d4ba5874
Most of this is as everywhere else, but there's also interesting code inspection fixes from the InspectCode bump, so I'll talk about that a little. ## [Fix suspicious equality in `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d) Inspection: https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html Pretty annoying to fix, nullable array types are a pain. Does look legit though. ## [Fix `StarDifficulty` using inefficient struct equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545) Inspection: https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html This is a dodgy one because there's no real sane way to define equality on `StarDifficulty` now that it has difficulty and performance attributes jammed into it. So I just basically shut the inspection up with a `record` modifier and move on. Unclear where the equality is used precisely. It's from a global inspection. F12 is very unhelpful when trying to track down usages of `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and those do use equality. Maybe more than that. ## [Use `nameof` expressions to reference enum member names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91) Inspection: https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html Pretty quaint. ## [Prefer using concrete values over `default` or `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d) Inspection: https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html I could see this one going both ways, but I'm kinda sold on this inspection. Explicit is always better. Saves some allocations in the `CancellationToken` cases as well. ## [Explicitly call `.AsEnumerable()` in some realm usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401) Inspection: https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html Not fully sold on this one but it's quick and simple so might as well. ## [Simplify dictionary removal with single `.Remove()` call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427) Inspection: https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html Not much to say.
124 lines
4.3 KiB
C#
124 lines
4.3 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using osu.Framework.Allocation;
|
|
using osu.Framework.Bindables;
|
|
using osu.Framework.Graphics;
|
|
using osu.Framework.Graphics.Cursor;
|
|
using osu.Framework.Localisation;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Graphics.UserInterface;
|
|
using osu.Game.Resources.Localisation.Web;
|
|
using osu.Game.Scoring;
|
|
using osu.Game.Localisation;
|
|
using osu.Game.Rulesets.Mods;
|
|
|
|
namespace osu.Game.Screens.Ranking.Expanded.Statistics
|
|
{
|
|
public partial class PerformanceStatistic : StatisticDisplay, IHasTooltip
|
|
{
|
|
public LocalisableString TooltipText { get; private set; }
|
|
|
|
private readonly ScoreInfo score;
|
|
|
|
private readonly Bindable<int> performance = new Bindable<int>();
|
|
|
|
private readonly CancellationTokenSource cancellationTokenSource = new CancellationTokenSource();
|
|
|
|
private RollingCounter<int> counter = null!;
|
|
|
|
public PerformanceStatistic(ScoreInfo score)
|
|
: base(BeatmapsetsStrings.ShowScoreboardHeaderspp)
|
|
{
|
|
this.score = score;
|
|
}
|
|
|
|
[BackgroundDependencyLoader]
|
|
private void load(BeatmapDifficultyCache difficultyCache, CancellationToken? cancellationToken)
|
|
{
|
|
if (score.PP.HasValue)
|
|
{
|
|
setPerformanceValue(score, score.PP.Value);
|
|
}
|
|
else
|
|
{
|
|
Task.Run(async () =>
|
|
{
|
|
var attributes = await difficultyCache.GetDifficultyAsync(score.BeatmapInfo!, score.Ruleset, score.Mods, cancellationToken ?? CancellationToken.None).ConfigureAwait(false);
|
|
var performanceCalculator = score.Ruleset.CreateInstance().CreatePerformanceCalculator();
|
|
|
|
// Performance calculation requires the beatmap and ruleset to be locally available. If not, return a default value.
|
|
if (attributes?.DifficultyAttributes == null || performanceCalculator == null)
|
|
return;
|
|
|
|
var result = await performanceCalculator.CalculateAsync(score, attributes.Value.DifficultyAttributes, cancellationToken ?? CancellationToken.None).ConfigureAwait(false);
|
|
|
|
Schedule(() => setPerformanceValue(score, result.Total));
|
|
}, cancellationToken ?? CancellationToken.None);
|
|
}
|
|
}
|
|
|
|
private void setPerformanceValue(ScoreInfo scoreInfo, double? pp)
|
|
{
|
|
if (pp.HasValue)
|
|
{
|
|
performance.Value = (int)Math.Round(pp.Value, MidpointRounding.AwayFromZero);
|
|
|
|
if (!scoreInfo.BeatmapInfo!.Status.GrantsPerformancePoints())
|
|
{
|
|
Alpha = 0.5f;
|
|
TooltipText = ResultsScreenStrings.NoPPForUnrankedBeatmaps;
|
|
}
|
|
else if (hasUnrankedMods(scoreInfo))
|
|
{
|
|
Alpha = 0.5f;
|
|
TooltipText = ResultsScreenStrings.NoPPForUnrankedMods;
|
|
}
|
|
else if (scoreInfo.Rank == ScoreRank.F)
|
|
{
|
|
Alpha = 0.5f;
|
|
TooltipText = ResultsScreenStrings.NoPPForFailedScores;
|
|
}
|
|
else
|
|
{
|
|
Alpha = 1f;
|
|
TooltipText = default;
|
|
}
|
|
}
|
|
}
|
|
|
|
private static bool hasUnrankedMods(ScoreInfo scoreInfo)
|
|
{
|
|
IEnumerable<Mod> modsToCheck = scoreInfo.Mods;
|
|
|
|
if (scoreInfo.IsLegacyScore)
|
|
modsToCheck = modsToCheck.Where(m => m is not ModClassic);
|
|
|
|
return modsToCheck.Any(m => !m.Ranked);
|
|
}
|
|
|
|
public override void Appear()
|
|
{
|
|
base.Appear();
|
|
counter.Current.BindTo(performance);
|
|
}
|
|
|
|
protected override void Dispose(bool isDisposing)
|
|
{
|
|
cancellationTokenSource.Cancel();
|
|
base.Dispose(isDisposing);
|
|
}
|
|
|
|
protected override Drawable CreateContent() => counter = new StatisticCounter
|
|
{
|
|
Anchor = Anchor.TopCentre,
|
|
Origin = Anchor.TopCentre
|
|
};
|
|
}
|
|
}
|