mirror of
https://github.com/ppy/osu.git
synced 2026-05-30 03:59:55 +08:00
Dan Balasescu
c72b6412ea
Rebase of https://github.com/smoogipoo/osu/pull/193 Going forward, the client will have to know the type of pool being invited to so that it can enter the appropriate screen when clicking the notification. Unfortunately, SignalR does not support overloading methods, or even adding parameters to them, so this PR deprecates the `MatchmakingRoomInvited` event and adds its replacement `MatchmakingRoomInvitedWithParams` with a complex `invitation` parameter that we _can_ extend in the future if required (such as potentially adding the name of the pool). This also prepares the notification by extracting some code to a `Complete` method receiving said `invitation` parameter. This part of code will be further modified to enter the correct screen: https://github.com/smoogipoo/osu/blob/0a4018045b9d908f66c63dee65d0059d05b26e43/osu.Game/Screens/OnlinePlay/Matchmaking/Queue/QueueController.cs#L200 In particular, I have tested that new clients continue to work with the old server (dev.ppy.sh) in quick play | | Old Server | New Server | | ------------- |:-------------:| :-----:| | Old Client | 🟢 | 🟢 | | New Client | 🟢 | 🟢 |
17 lines
401 B
C#
17 lines
401 B
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System;
|
|
using MessagePack;
|
|
|
|
namespace osu.Game.Online.Matchmaking
|
|
{
|
|
[MessagePackObject]
|
|
[Serializable]
|
|
public class MatchmakingRoomInvitationParams
|
|
{
|
|
[Key(0)]
|
|
public MatchmakingPoolType Type { get; set; }
|
|
}
|
|
}
|