mirror of
https://github.com/ppy/osu.git
synced 2026-05-22 10:30:00 +08:00
18d4ba5874
Most of this is as everywhere else, but there's also interesting code inspection fixes from the InspectCode bump, so I'll talk about that a little. ## [Fix suspicious equality in `Hotkey`](https://github.com/ppy/osu/commit/948136e49e88a721827d54e51c5759fe9aca811d) Inspection: https://www.jetbrains.com/help/resharper/TypeWithSuspiciousEqualityIsUsedInRecord.Global.html Pretty annoying to fix, nullable array types are a pain. Does look legit though. ## [Fix `StarDifficulty` using inefficient struct equality](https://github.com/ppy/osu/commit/2db775ebb0bb9f18de67677ef84b993465d26545) Inspection: https://www.jetbrains.com/help/resharper/DefaultStructEqualityIsUsed.Global.html This is a dodgy one because there's no real sane way to define equality on `StarDifficulty` now that it has difficulty and performance attributes jammed into it. So I just basically shut the inspection up with a `record` modifier and move on. Unclear where the equality is used precisely. It's from a global inspection. F12 is very unhelpful when trying to track down usages of `Equals()`. We definitely have `Bindable<StarDifficulty>` instances and those do use equality. Maybe more than that. ## [Use `nameof` expressions to reference enum member names](https://github.com/ppy/osu/commit/aa08175c803bc725f3b15a92174dfe6d1b812d91) Inspection: https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html Pretty quaint. ## [Prefer using concrete values over `default` or `new()`](https://github.com/ppy/osu/commit/b21ee08d7748be10d42268d5c2eb77369026545d) Inspection: https://www.jetbrains.com/help/resharper/PreferConcreteValueOverDefault.html I could see this one going both ways, but I'm kinda sold on this inspection. Explicit is always better. Saves some allocations in the `CancellationToken` cases as well. ## [Explicitly call `.AsEnumerable()` in some realm usages](https://github.com/ppy/osu/commit/c8ce1ecd42b9d8abb8b9e2ab93d471f463e80401) Inspection: https://www.jetbrains.com/help/resharper/PossibleUnintendedQueryableAsEnumerable.html Not fully sold on this one but it's quick and simple so might as well. ## [Simplify dictionary removal with single `.Remove()` call](https://github.com/ppy/osu/commit/5964ceccea900302df726b7a8ecbf6b74eb2e427) Inspection: https://www.jetbrains.com/help/resharper/CanSimplifyDictionaryRemovingWithSingleCall.html Not much to say.
104 lines
4.1 KiB
C#
104 lines
4.1 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System.Linq;
|
|
using System.Threading;
|
|
using System.Threading.Tasks;
|
|
using osu.Framework.Extensions.ObjectExtensions;
|
|
using osu.Framework.Logging;
|
|
using osu.Framework.Platform;
|
|
using osu.Framework.Threading;
|
|
using osu.Game.Database;
|
|
using osu.Game.Online.API;
|
|
using osu.Game.Rulesets.Objects.Types;
|
|
|
|
namespace osu.Game.Beatmaps
|
|
{
|
|
public class BeatmapUpdater : IBeatmapUpdater
|
|
{
|
|
private readonly IWorkingBeatmapCache workingBeatmapCache;
|
|
|
|
private readonly BeatmapDifficultyCache difficultyCache;
|
|
|
|
private readonly BeatmapUpdaterMetadataLookup metadataLookup;
|
|
|
|
private const int update_queue_request_concurrency = 4;
|
|
|
|
private readonly ThreadedTaskScheduler updateScheduler = new ThreadedTaskScheduler(update_queue_request_concurrency, nameof(BeatmapUpdaterMetadataLookup));
|
|
|
|
public BeatmapUpdater(IWorkingBeatmapCache workingBeatmapCache, BeatmapDifficultyCache difficultyCache, IAPIProvider api, Storage storage)
|
|
{
|
|
this.workingBeatmapCache = workingBeatmapCache;
|
|
this.difficultyCache = difficultyCache;
|
|
|
|
metadataLookup = new BeatmapUpdaterMetadataLookup(api, storage);
|
|
}
|
|
|
|
public void Queue(Live<BeatmapSetInfo> beatmapSet, MetadataLookupScope lookupScope = MetadataLookupScope.LocalCacheFirst)
|
|
{
|
|
Logger.Log($"Queueing change for local beatmap {beatmapSet}");
|
|
Task.Factory.StartNew(() => beatmapSet.PerformRead(b => Process(b, lookupScope)), CancellationToken.None, TaskCreationOptions.HideScheduler | TaskCreationOptions.RunContinuationsAsynchronously,
|
|
updateScheduler);
|
|
}
|
|
|
|
public void Process(BeatmapSetInfo beatmapSet, MetadataLookupScope lookupScope = MetadataLookupScope.LocalCacheFirst)
|
|
{
|
|
beatmapSet.Realm!.Write(_ =>
|
|
{
|
|
// Before we use below, we want to invalidate.
|
|
workingBeatmapCache.Invalidate(beatmapSet);
|
|
|
|
if (lookupScope != MetadataLookupScope.None)
|
|
metadataLookup.Update(beatmapSet, lookupScope == MetadataLookupScope.OnlineFirst);
|
|
|
|
foreach (BeatmapInfo beatmap in beatmapSet.Beatmaps)
|
|
{
|
|
var working = workingBeatmapCache.GetWorkingBeatmap(beatmap);
|
|
|
|
difficultyCache.Invalidate(beatmap, working.BeatmapInfo);
|
|
|
|
var ruleset = working.BeatmapInfo.Ruleset.CreateInstance();
|
|
var calculator = ruleset.CreateDifficultyCalculator(working);
|
|
|
|
beatmap.StarRating = calculator.Calculate().StarRating;
|
|
beatmap.UpdateStatisticsFromBeatmap(working.Beatmap);
|
|
}
|
|
|
|
// And invalidate again afterwards as re-fetching the most up-to-date database metadata will be required.
|
|
workingBeatmapCache.Invalidate(beatmapSet);
|
|
});
|
|
}
|
|
|
|
public void ProcessObjectCounts(BeatmapInfo beatmapInfo, MetadataLookupScope lookupScope = MetadataLookupScope.LocalCacheFirst)
|
|
{
|
|
beatmapInfo.Realm!.Write(_ =>
|
|
{
|
|
// Before we use below, we want to invalidate.
|
|
workingBeatmapCache.Invalidate(beatmapInfo);
|
|
|
|
var working = workingBeatmapCache.GetWorkingBeatmap(beatmapInfo);
|
|
var beatmap = working.Beatmap;
|
|
|
|
beatmapInfo.EndTimeObjectCount = beatmap.HitObjects.Count(h => h is IHasDuration);
|
|
beatmapInfo.TotalObjectCount = beatmap.HitObjects.Count;
|
|
|
|
// And invalidate again afterwards as re-fetching the most up-to-date database metadata will be required.
|
|
workingBeatmapCache.Invalidate(beatmapInfo);
|
|
});
|
|
}
|
|
|
|
#region Implementation of IDisposable
|
|
|
|
public void Dispose()
|
|
{
|
|
if (metadataLookup.IsNotNull())
|
|
metadataLookup.Dispose();
|
|
|
|
if (updateScheduler.IsNotNull())
|
|
updateScheduler.Dispose();
|
|
}
|
|
|
|
#endregion
|
|
}
|
|
}
|