mirror of
https://github.com/ppy/osu.git
synced 2026-05-19 14:40:24 +08:00
Bartłomiej Dach
ceb58a1141
This fell out of my work on hit window-related replay issues. In my WIP branch (that is probably going to get PR'd as draft soon) I refactored `HitWindows` and found a few straggling test failures due to some places reading hit windows for results that were not actually supported by the underlying `HitWindows` implementations, leading to returning garbage (mostly zeroes). Importantly, there is one actual usage in game code with impact here - `TaikoModSingleTap` was attempting to read the hit window for MEH, when MEH was never actually a valid hit result in taiko (OK is). This was a result of a copy-paste oversight from osu!, specifically from https://github.com/ppy/osu/blob/51cf835fb6300aca53b5b98143d606f64d7a4d49/osu.Game.Rulesets.Osu/Mods/InputBlockingMod.cs#L58
ceb58a1141
·
2025-05-09 09:40:20 +02:00
History