Bartłomiej Dach 6416f59c7b Disallow placing gameplay leaderboard in skins outside player ...

Closes https://github.com/ppy/osu/issues/33542.

For a diff this simple this took much more hemming and hawing because
things are a bit annoying here from a few angles:

- The only way that is considered idiomatic right now for a skin
  component to not be applicable to a screen is to require a dependency
  from DI that is only provided by applicable screens.
  `DrawableGameplayLeaderboard` has a few of those dependencies, but the
  scope of all the usages makes it so that the only really viable one to
  use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
  and also the usage of multiplayer spectator, where the leaderboard is
  *not* under a player instance).

- The smelly part of this is that the `Player` inheritance hierarchy
  must ensure that *every* non-abstract class has an
  `IGameplayLeaderboardProvider` cached. It is not trivial - if not
  straight up impossible - to force this via some `Player` level
  abstract method, because such a method would need to somehow
  accommodate all possible leaderboard providers. That however also
  means that every possible future `Player` implementor *must inherently
  know* to also cache a leaderboard provider lest it die at runtime. I
  don't love that, but I also don't see better alternatives.

- Speaking of which, I also noticed that solo spectator and playlists
  don't have gameplay leaderboards. At all. Which I don't believe to be
  something that I broke with the leaderboard work - I'm pretty sure
  that was the pre-existing state - however I don't see any reason why
  they *couldn't* receive gameplay leaderboards. I'm not doing that
  here, though, just leaving TODOs for later.

6416f59c7b · 2025-06-09 13:11:29 +02:00

History

..

EditorPlayer.cs

Disallow placing gameplay leaderboard in skins outside player

2025-06-09 13:11:29 +02:00

EditorPlayerLoader.cs

Avoid passing beatmap in from editor when it's already present

2024-05-29 21:32:55 +09:00