mirror of
https://github.com/ppy/osu.git
synced 2024-11-15 13:47:24 +08:00
ffc7eaa3f2
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
25 lines
658 B
C#
25 lines
658 B
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using osu.Game.Rulesets.Objects.Types;
|
|
using osuTK;
|
|
|
|
namespace osu.Game.Rulesets.Objects.Legacy.Osu
|
|
{
|
|
/// <summary>
|
|
/// Legacy osu! Hit-type, used for parsing Beatmaps.
|
|
/// </summary>
|
|
internal sealed class ConvertHit : ConvertHitObject, IHasPosition, IHasCombo
|
|
{
|
|
public Vector2 Position { get; set; }
|
|
|
|
public float X => Position.X;
|
|
|
|
public float Y => Position.Y;
|
|
|
|
public bool NewCombo { get; set; }
|
|
|
|
public int ComboOffset { get; set; }
|
|
}
|
|
}
|