mirror of
https://github.com/ppy/osu.git
synced 2026-05-18 16:10:48 +08:00
Bartłomiej Dach
131f828e6a
In stable mania, Hard Rock and Easy mods do not work the same way as they do on all of the rulesets. The difference is that mania HR and EZ, rather than apply a multiplier to the map's original Overall Difficulty, apply multipliers to *the durations of hit windows themselves*. Prior to the last release, lazer was oblivious to this reality and just treated mania HR / EZ as it did every other ruleset. Last release, for the sake for gameplay parity across rulesets, the mods in question were adjusted to match stable, but in the process, it started looking like HR / EZ did not change OD anymore. The problem is that they do, but applying a multiplier to the map's OD and applying a multiplier to the hit window duration is not the same thing. The second thing is actually *much harsher* in magnitude, to the point where applying HR to any map is almost guaranteed to exceed "the effective OD" of 10, and applying EZ to any map is almost guaranteed to result in "negative effective OD". This change attempts to convey that reality by displaying "effective OD", similar to what's already done in other rulesets when rate-changing mods are active. Note that the values this will display *do not match* stable *and that is correct*, because stable song select *lies* about the actual impact on OD by just assuming it can treat all rulesets in the same way. --- Would close https://github.com/ppy/osu/issues/34150 I guess. And yes I would like *all of the above* to land on the changelog if possible if this is merged. For further convincing that this makes any semblance of sense please see the following: https://www.desmos.com/calculator/yigt7jycdv
54 lines
1.8 KiB
C#
54 lines
1.8 KiB
C#
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
|
|
// See the LICENCE file in the repository root for full licence text.
|
|
|
|
using System.Collections.Generic;
|
|
using NUnit.Framework;
|
|
using osu.Game.Beatmaps;
|
|
using osu.Game.Rulesets.Catch.Mods;
|
|
|
|
namespace osu.Game.Rulesets.Catch.Tests
|
|
{
|
|
[TestFixture]
|
|
public class CatchRateAdjustedDisplayDifficultyTest
|
|
{
|
|
private static IEnumerable<float> difficultyValuesToTest()
|
|
{
|
|
for (float i = 0; i <= 10; i += 0.5f)
|
|
yield return i;
|
|
}
|
|
|
|
[TestCaseSource(nameof(difficultyValuesToTest))]
|
|
public void TestApproachRateIsUnchangedWithRateEqualToOne(float originalApproachRate)
|
|
{
|
|
var ruleset = new CatchRuleset();
|
|
var difficulty = new BeatmapDifficulty { ApproachRate = originalApproachRate };
|
|
|
|
var adjustedDifficulty = ruleset.GetAdjustedDisplayDifficulty(difficulty, []);
|
|
|
|
Assert.That(adjustedDifficulty.ApproachRate, Is.EqualTo(originalApproachRate));
|
|
}
|
|
|
|
[Test]
|
|
public void TestRateBelowOne()
|
|
{
|
|
var ruleset = new CatchRuleset();
|
|
var difficulty = new BeatmapDifficulty();
|
|
|
|
var adjustedDifficulty = ruleset.GetAdjustedDisplayDifficulty(difficulty, [new CatchModHalfTime()]);
|
|
|
|
Assert.That(adjustedDifficulty.ApproachRate, Is.EqualTo(1.67).Within(0.01));
|
|
}
|
|
|
|
[Test]
|
|
public void TestRateAboveOne()
|
|
{
|
|
var ruleset = new CatchRuleset();
|
|
var difficulty = new BeatmapDifficulty();
|
|
|
|
var adjustedDifficulty = ruleset.GetAdjustedDisplayDifficulty(difficulty, [new CatchModDoubleTime()]);
|
|
|
|
Assert.That(adjustedDifficulty.ApproachRate, Is.EqualTo(7.67).Within(0.01));
|
|
}
|
|
}
|
|
}
|